mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>,
	Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bryan O'Donoghue <bod@kernel.org>,
	Todor Tomov <todor.too@gmail.com>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com,
	tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com,
	yijie.yang@oss.qualcomm.com
Subject: Re: [PATCH 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding
Date: Mon, 20 Oct 2025 12:16:28 +0200	[thread overview]
Message-ID: <7140b8a8-1380-4859-84a3-681b3f1ce505@kernel.org> (raw)
In-Reply-To: <ac96922e-d2a3-4a99-8f34-a822c3dd2d02@kernel.org>

On 16/10/2025 12:43, Krzysztof Kozlowski wrote:
> On 16/10/2025 10:47, Loic Poulain wrote:
>> On Thu, Oct 16, 2025 at 7:52 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>
>>> On 15/10/2025 05:21, Hangxiang Ma wrote:
>>>>>> +      - const: csiphy4
>>>>>> +      - const: csiphy5
>>>>>> +      - const: vfe0
>>>>>> +      - const: vfe1
>>>>>> +      - const: vfe2
>>>>>> +      - const: vfe_lite0
>>>>>> +      - const: vfe_lite1
>>>>> Wouldn't it make sense to simplify this and have different camss nodes
>>>>> for the 'main' and 'lite' paths?
>>>>>
>>>>> [...]
>>>> No such plan till now. Other series may take this into consideration.
>>>
>>> We don't care much about your plan. You are expected to send correct
>>> hardware description.
>>
>> To be fair, other platforms like sc8280xp-camss already have the
>> all-in big camss node.
>> Point is that if Lite and Main blocks are distinct enough we could
>> have two simpler nodes.
>> Would it make things any better from a dts and camss perspective?
>>
>>  camss: isp@9253000 {
>>     compatible = "qcom,kaanapali-camss";
>>     [...]
>> }
>>
>> camss-lite:ips@9273000 {
>>    compatible = "qcom,kaanapali-lite-camss";
>>     [...]
>> }
>>
>> That approach would create two distinct CAMSS instances and separate
>> media pipelines.
>> However, it may not work with the current implementation, as the CSI
>> PHYs would need to be shared between them.
>>
>> I guess this should be part of the broader discussion around
>> splitting/busifying CAMSS.
> 
> And this discussion CAN happen now, stopping this camss and any future
> camss till we conclude the discussion. Whatever internal plans of that
> teams are, rejecting technical discussion based on "no plans for that"
> is a really bad argument, only stalling this patchset and raising eyebrows.


To be clear, I expect Loic's comment to be fully and technically
addressed, not with "no plan for that".

This blocks this patchset and any new versions.

Best regards,
Krzysztof

  reply	other threads:[~2025-10-20 10:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25  0:02 [PATCH 0/6] media: qcom: camss: Add Kaanapali support Jingyi Wang
2025-09-25  0:02 ` [PATCH 1/6] dt-bindings: i2c: qcom-cci: Document Kaanapali compatible Jingyi Wang
2025-09-25 19:32   ` Loic Poulain
2025-10-15  3:15     ` Hangxiang Ma
2025-09-25  0:02 ` [PATCH 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding Jingyi Wang
2025-09-25  3:12   ` Dmitry Baryshkov
2025-10-06 20:04   ` Loic Poulain
2025-10-15  3:21     ` Hangxiang Ma
2025-10-16  5:52       ` Krzysztof Kozlowski
2025-10-16  8:47         ` Loic Poulain
2025-10-16 10:43           ` Krzysztof Kozlowski
2025-10-20 10:16             ` Krzysztof Kozlowski [this message]
2025-10-20 10:56               ` Bryan O'Donoghue
2025-10-20 17:42                 ` Vijay Kumar Tumati
     [not found]                 ` <4fb3c83a-2bef-4b15-b676-73e8e8957452@oss.qualcomm.com>
2025-10-20 18:09                   ` Bryan O'Donoghue
2025-10-20 18:12                     ` Bryan O'Donoghue
2025-09-25  0:02 ` [PATCH 3/6] media: qcom: camss: Add Kaanapali compatible camss driver Jingyi Wang
2025-09-25  0:02 ` [PATCH 4/6] media: qcom: camss: csiphy: Add support for v2.4.0 two-phase CSIPHY Jingyi Wang
2025-09-25 12:57   ` Bryan O'Donoghue
2025-10-15  3:41     ` Hangxiang Ma
2025-09-25  0:02 ` [PATCH 5/6] media: qcom: camss: csid: Add support for CSID 1080 Jingyi Wang
2025-09-25 23:30   ` Bryan O'Donoghue
2025-10-15  3:44     ` Hangxiang Ma
2025-09-25  0:02 ` [PATCH 6/6] media: qcom: camss: vfe: Add support for VFE 1080 Jingyi Wang
2025-09-25 22:59   ` Bryan O'Donoghue
2025-09-25 22:48 ` [PATCH 0/6] media: qcom: camss: Add Kaanapali support Bryan O'Donoghue
2025-10-15  3:17   ` Hangxiang Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7140b8a8-1380-4859-84a3-681b3f1ce505@kernel.org \
    --to=krzk@kernel.org \
    --cc=aiqun.yu@oss.qualcomm.com \
    --cc=andi.shyti@kernel.org \
    --cc=bod@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hangxiang.ma@oss.qualcomm.com \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=todor.too@gmail.com \
    --cc=trilok.soni@oss.qualcomm.com \
    --cc=vladimir.zapolskiy@linaro.org \
    --cc=yijie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®