From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752524AbbKIQqO (ORCPT ); Mon, 9 Nov 2015 11:46:14 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:53202 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590AbbKIQqL (ORCPT ); Mon, 9 Nov 2015 11:46:11 -0500 From: Arnd Bergmann To: John Garry Cc: JBottomley@odin.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxarm@huawei.com, john.garry2@mail.dcu.ie, hare@suse.de, xuwei5@hisilicon.com, zhangfei.gao@linaro.org Subject: Re: [PATCH v3 00/32] HiSilicon SAS driver Date: Mon, 09 Nov 2015 17:40:18 +0100 Message-ID: <7145880.UVekNWKRMt@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1447086757-147706-1-git-send-email-john.garry@huawei.com> References: <1447086757-147706-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:q8ymUFZduOJIKtbhXSq2kPNXOs3Ik265sAIdzBcjcjkgwjBW/kY Bfpk7UdGIDySajKTAvacqtGbhfHEJMJQ4DXeBGfJVGWa3PYvBZw0BjdJpLmZh8gOBiRAXk1 UaYq9ZGGDI39q2VSzB1A2PSXcxmNKoX+nlje8jthmWXXQWNVi+K5GxrV59DH4KgdZD8BPLC uygDsQdUDPyhh2kIZHqGQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:JbXVVGa6Xvo=:N7jp5wab1QL7WLqQraoeNe QZRsQqJy9uCUSZ7VkyaQ7BKyD4zrLVhIJEz7QRTNcCXjo0bWX5Q+v905YB8BrSgZm4aCycgQy qOen2YBnz6QKlqZGnCvoMYuH+hFMKDF1RkMXDqQcbNxJYfh9CKSiH8tnOiT9OdfF90BGPEJgW U9NMsGYmcrDJl10otT2Gyw9jRHtXR9SWmbg7XYTkrq9rUg9JSjQyumILVGHMK1TmtZqL0eb0q WVTosKBNWoD9F/upr6J5JfvFuv3+pDPFQtKirxaO9yMY8jh2YKgo20r1FspR3OyOTsFvo5aUX fw9IqvRnO+ITob8cu3S4vx4V8f3+B7K+h9BkFLaNLI9BAg0DCU3wWT88bVUxGRZGKI/9Cyo2h cvxkEVnsupDvs5SdE9cv3E6LUjuSLAl+9wOxdAPr+otHJXKH9pTRSRJrp+XrKIim4h0OG01fv WI7QV2c5BikbI2M4hh18Jvm5dwgd20nj2GfIv7JWyS8xYbSg7XK1n/+Hd1Ae1WSyiWNh0sNjW DstxKbB9s0IkYXCNiNGG+3Zp/DK+VWlTRpaWOu0kxoELzlteZcv5ycUVjMb8NE5OW0yQnF3Ee WnMMtK0kTxVijgE+4t9EwOZcfloc3nn7r3QEtDG0z+GP0oVZxyae1UIVLHDqhJOtwcb4C+R81 YNMlnZ2MoM8tqLddKTyyDu0PkOq880qBsdSQ0IDwtPvwH+Yqopg0bAQkDyKhw6FOhDwxfNIRd o5bZwvGsgeP1pkVq Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 10 November 2015 00:32:05 John Garry wrote: > This is the driver patchset for the HiSilicon SAS driver. The driver > is a platform driver. > > The driver will support multiple revisions of HW. Currently only "v1" > HW is supported. > > The driver uses libsas framework within the SCSI framework. > > The v1 HW supports SSP and SMP, but not STP/SATA. I have one remaining comment that I now posted, all my previous comments have been addressed as far as I can tell. Very nice work! Reviewed-by: Arnd Bergmann Note that my comments were mostly about general driver design, I have very little SAS specific knowledge and someone else should look over those parts.