From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B73EBC7EE2E for ; Fri, 9 Jun 2023 06:18:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237598AbjFIGSC (ORCPT ); Fri, 9 Jun 2023 02:18:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237178AbjFIGRx (ORCPT ); Fri, 9 Jun 2023 02:17:53 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5866E1FE6; Thu, 8 Jun 2023 23:17:51 -0700 (PDT) Received: from dggpeml500002.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QcrNV1sZkz18M2t; Fri, 9 Jun 2023 14:12:58 +0800 (CST) Received: from [10.67.103.44] (10.67.103.44) by dggpeml500002.china.huawei.com (7.185.36.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 9 Jun 2023 14:17:48 +0800 Subject: Re: [PATCH v3 2/3] drivers/perf: hisi: Add support for HiSilicon UC PMU driver To: Jonathan Cameron References: <20230608113719.27433-1-hejunhao3@huawei.com> <20230608113719.27433-3-hejunhao3@huawei.com> <20230608142200.0000753c@Huawei.com> CC: , , , , , , , , From: hejunhao Message-ID: <7148da77-056a-06aa-89bf-25f775535685@huawei.com> Date: Fri, 9 Jun 2023 14:17:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20230608142200.0000753c@Huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.44] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500002.china.huawei.com (7.185.36.158) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Jonathan On 2023/6/8 21:22, Jonathan Cameron wrote: > On Thu, 8 Jun 2023 19:37:18 +0800 > Junhao He wrote: > > >> On HiSilicon Hip09 platform, there is 4 UC (unified cache) module > are 4 UC (unified cache) modules Ok, will fix it. Thanks. >> on each chip CCL (CPU Cluster). UC is a cache that provides >> coherence between NUMA and UMA domains. It is located between L2 >> and Memory System. And many PMU events are supported. Let's support > Many PMU events are supported. Ok, will fix it. Thanks. >> the UC PMU driver using the HiSilicon uncore PMU framework. >> >> * rd_req_en : rd_req_en is the abbreviation of read request tracetag >> enable and allows user to count only read operations. Details are listed >> in the hisi-pmu document at Documentation/admin-guide/perf/hisi-pmu.rst >> >> * srcid_en & srcid: Allows users to filter statistical information based >> on specific CPU/ICL by srcid. >> srcid_en depending on rd_req_en enabled. > srcid_en depends on rd_req_en being enabled. Ok, will fix it. Thanks. >> * uring_channel: Allows users to filter statistical information based on >> the specified tx request uring channel. >> uring_channel only supported events: [0x47 ~ 0x59]. >> >> Signed-off-by: Junhao He >> Reviewed-by: Yicong Yang > The editorial stuff above is trivial and original text can be easily > understood. So maintainers may not care. If you happen to be re rolling > the patch then nice to clean it up. > > Reviewed-by: Jonathan Cameron > . Sure, Will fix in next version. Thanks.