From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>,
phone-devel@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Luca Weiss <luca@z3ntu.xyz>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] arm64: dts: qcom: Use plural _gpios node label for PMIC gpios
Date: Sat, 10 Dec 2022 11:50:51 +0100 [thread overview]
Message-ID: <714ac62a-7bab-e16e-e3b6-bdd86e422699@linaro.org> (raw)
In-Reply-To: <20221209220450.1793421-1-marijn.suijten@somainline.org>
On 09/12/2022 23:04, Marijn Suijten wrote:
> The gpio node in PMIC dts'es define access to multiple GPIOs. Most Qcom
> PMICs were already using the plural _gpios label to point to this node,
> but a few PMICs were left behind including the recently-pulled
> pm(i)8950.
>
> Rename it from *_gpio to *_gpios for pm6125, pm6150(l), pm8005,
> pm(i)8950, and pm(i)8998.
>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
>
> ---
>
> This was brought up for discussion in [1] but hasn't seen any relevant
> reply, unfortunately.
This is just a label, it does not matter. Why changing all exisitng
files? I don't think it was a part of previous discussions...
To me it is unneeded churn.
>
> [1]: https://lore.kernel.org/linux-arm-msm/20221104234435.xwjpwfxs73puvfca@SoMainline.org/
> ---
> arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts | 8 ++++----
> .../dts/qcom/msm8998-oneplus-cheeseburger.dts | 4 ++--
> .../boot/dts/qcom/msm8998-oneplus-common.dtsi | 6 +++---
> .../qcom/msm8998-sony-xperia-yoshino-maple.dts | 4 ++--
> .../dts/qcom/msm8998-sony-xperia-yoshino.dtsi | 16 ++++++++--------
> .../arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts | 4 ++--
> arch/arm64/boot/dts/qcom/pm6125.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/pm6150.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/pm6150l.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/pm8005.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/pm8950.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/pm8998.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/pmi8950.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 4 ++--
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 16 ++++++++--------
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 4 ++--
> .../boot/dts/qcom/sdm845-oneplus-common.dtsi | 6 +++---
> .../arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 4 ++--
> .../boot/dts/qcom/sdm845-sony-xperia-tama.dtsi | 2 +-
> .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 4 ++--
> .../boot/dts/qcom/sdm845-xiaomi-polaris.dts | 4 ++--
> .../dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 2 +-
> 25 files changed, 64 insertions(+), 64 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts b/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
> index 310f7a2df1e8..0e273938b59d 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
> @@ -113,7 +113,7 @@ gpio-keys {
> <&cam_snapshot_pin_a>;
> button-vol-up {
> label = "Volume Up";
> - gpios = <&pm8998_gpio 6 GPIO_ACTIVE_LOW>;
> + gpios = <&pm8998_gpios 6 GPIO_ACTIVE_LOW>;
> linux,input-type = <EV_KEY>;
> linux,code = <KEY_VOLUMEUP>;
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-10 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 22:04 Marijn Suijten
2022-12-10 9:34 ` Konrad Dybcio
2022-12-10 10:50 ` Krzysztof Kozlowski [this message]
2022-12-10 14:25 ` Konrad Dybcio
2022-12-10 17:05 ` Marijn Suijten
2022-12-11 20:07 ` Krzysztof Kozlowski
2022-12-14 20:37 ` Marijn Suijten
2022-12-28 4:36 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=714ac62a-7bab-e16e-e3b6-bdd86e422699@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®