From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbdARQyO (ORCPT ); Wed, 18 Jan 2017 11:54:14 -0500 Received: from mout.web.de ([212.227.17.11]:54164 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414AbdARQyM (ORCPT ); Wed, 18 Jan 2017 11:54:12 -0500 Subject: [PATCH 1/3] m68k: Return directly after a failed capable() in sys_cacheflush() To: linux-m68k@vger.kernel.org, Geert Uytterhoeven References: <558ff501-7440-a97f-4494-f48591644092@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <71513091-bc01-ce70-893f-3f376062d833@users.sourceforge.net> Date: Wed, 18 Jan 2017 17:47:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <558ff501-7440-a97f-4494-f48591644092@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:evEJ8RvJyjN59ymbBgzNa3ikdOdkxEcC13LGku1sXkdtA68umru 8BXGhf33pBkGVTB0hV55cIIDgMDDak3Yx97Nsy0tevNDWaRRsGRaK7e1mwYg18EIjf8oc5w HGS0LmOC7njzjbPimByAEzbP5kfXcO6tLwB2FLlE3Pvk777HvKTpTkgwC9maCJG/gUcsHDO 90rMyI8NqzpIfudeLH5QQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:R3j6Rslxzy8=:GIYLfC/0AAtd0cwgT5z4aj iXOP9OKAYZbgVfFxv4LOnbN6GhPrDX7axJizxalaget2PcZ62DJgzrclpVZLyS2ukpFRtb0u2 Gipszg9hkZxiieF3N06tDjkVGIsvCnzWcTUBx5Ddy+3Bs6Z38oWPJ9CNFLaDNAtgq1VXTbHbH J27t03IhZR2X7UzuQMS4LH2X/ghhPI5yT0Yv/Nq/GG5fws3WjwZ3s0S0rUxZcK8gfdxijQCU+ 59INeBdEQbvMzqIvZm6IyPMjYiRsuzkAyuLuTjdUWW4ielpSuCU1L4FAEAG2V69P19gwTyOZ3 LQ4PB3vl5h+7PnfpbhMD8k2lQxMvQS3pxmxQaed6kTSK1tsnQSB3vCD5cHP3Borwr/ap5/KYn bWdfjikKbqLb64kGtNprK7dBha2+kuQA8sgL5b+SXbyyJpyyWl/gUMF6MQFie+QujpDcTsCwc GK872hc5+/4VfVfuPZUs4I6WnZaF1qh7vIwfAyzlsF782y/+bc8nvIuV7Ad46nlVOHa6yIQ7W q2MeHzX9ABTtDPento20YEZZSxqpb9SrpgfqouwjGd2DXbiKMcceG890YwpCAInSF4JMS4+4U 2c9r6kNJBjPkpJhxNimAU1elnIRcvvmw4TXBKWOUyFnKDO7TsMP/4+1Q1SPvIofBP46NEPgyz WjEQzbt/8jx0mAs1FhZoU0REhu64ZMUqZZQADrGyDpYFkGnq2fDIZOccpI+gumw0CwnabEqV7 RvuXS/SB5E+AFZJcNQpB//4cvrvlbATjUz8sV9HWGKqyNiBtomS3ON+baccv1MHZcmjOhXh5Q bNOAghu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 18 Jan 2017 16:30:36 +0100 Return directly after a call of the function "capable" failed at the beginning. Signed-off-by: Markus Elfring --- arch/m68k/kernel/sys_m68k.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/m68k/kernel/sys_m68k.c b/arch/m68k/kernel/sys_m68k.c index 9aa01adb407f..62bfeb3716a7 100644 --- a/arch/m68k/kernel/sys_m68k.c +++ b/arch/m68k/kernel/sys_m68k.c @@ -384,9 +384,8 @@ sys_cacheflush (unsigned long addr, int scope, int cache, unsigned long len) if (scope == FLUSH_SCOPE_ALL) { /* Only the superuser may explicitly flush the whole cache. */ - ret = -EPERM; if (!capable(CAP_SYS_ADMIN)) - goto out; + return -EPERM; } else { struct vm_area_struct *vma; -- 2.11.0