From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FB4F3E51DE for ; Mon, 17 Aug 2026 11:03:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786964639; cv=none; b=dkrtKV9XOR3bQroN5dLAv9IJRV87J9VpuDMdyrZw/SV5Dvg3ZYnABG6uu/eSY0yKN00Nago7VXDubhzoKUOgdjR4snY2+IkakOawkE2sgSMgAwYS1x8T6JxeEwnpyE0gdfr2rdfjP21Ojh2e06PCCncmY/2/qRqgnnu1m0Vhnpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786964639; c=relaxed/simple; bh=UVOCMtcyrfHs/Axz/F/mt3T12esPR3HkihmXhokS90k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gdth7aeEQJsuIjl1DJhEtoELBDo/ha8GtjkqRhKXKPzHoYJIe+1HBIVmI83VkEunP9FhqRacrIOJ4jhQ0TFmPHriEIUzHf1FsZeoWyoMfhtKh27SPQdnpTCd2EP9ZI6m6nD/vJGZGef6jRu3m0yecuKSJc6s0uHT2fn6iG2DiDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pAvJo8WU; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pAvJo8WU" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5aebd52488cso3452113e87.2 for ; Mon, 17 Aug 2026 04:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786964635; x=1787569435; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5roxsSwPYXmdBRG7+L0luHhV1ywCWm3yG7rXSaCHp/g=; b=pAvJo8WU+ZEoxbj0AhDNp9JFeiAbxjm+qOaUTbuE87KAzHHFNyGijMgZZUs1+O1as8 6Fmp4uU3jLVN3/17YMUEVHtp8t7XwCqDyksEELv9HDQOz0kV+7EvaCi6biFa/dEIMr4Q 1EaPRUpghXUmTkTRdiGXt9FHiEeP3IfqWsbk0Eigj8BMPlUT54RzaKutm5fVjwSWdPdA /tOER1VbQD1T0JAsh09lVEwlBQ7zMJcQ9uFGy7gktZY2/NFUWpOGT3rAMYWF7ENBbMln YXrTlefsDj6UdKLRSjltLdBxxkq8kUCrplDCwj/PIu+DgH4DQ7Jwugfz4B4KRgr7tXv6 cv6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786964635; x=1787569435; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5roxsSwPYXmdBRG7+L0luHhV1ywCWm3yG7rXSaCHp/g=; b=kU+zFRRHLtFQAigG91ViUH8v/VXSqyLI4wjcIhb1+lx1ywVTwTWKu/2VujjmAxn+71 26CRUB3o2ps9J5r+afcpxxS1S9yLiiIr8MXg4ky8jl+RP1qLT9T4QZ81BjE7axPihJQD GD/OOVoNOwZe2A3deIEFeMaD/OsxIVaDAcibOXIGH4EXrP6/qIHGGH76wfirJaFMpVIY Z85KYPuWQGBDvflQGFXwyXjysPgnBqUlLBQ41oR+EBd39U/N6iAWrasJ2KOcjPUEJhCV DPDekdJXq4buigaBJHUC+rmS5gt+5MvPuDdc0pDU6ysVqjg55fswH4HYaQslRtKCex9m +uBQ== X-Forwarded-Encrypted: i=1; AHgh+RrBFZw9YndhmmN6GFuojT2JsXtvniFu5fBvEMo8ov2q1GJOzzuxRzIctapGLgE4/P81zoNxmzOnneybauU=@vger.kernel.org X-Gm-Message-State: AOJu0YztvVYRiEIlKnp/gKEZek9KRl5sDDvsdrGVc++aQ/0HZi9Du1/W B6geFsY7BFQ6LlCaZNQmfpyZu3+aMjxWYH9Ho31QvPblYRfkX2+0Pm8N X-Gm-Gg: AR+sD12F/6j/kwtGSwecZQ2cTm5NscpT0LFeHf6PXnhHX7zppclTA10b3+VPj4BPvKE SKPR/xouqzNURNTd5zct2zwD2lp6ok4J+6SnKyU4B1mTD6nTPAu2m0j340j/lKEWLm0tJ3cZPNj pQE817QRNWhnvVohll42nTgcc6rzDEnpTOIOH/2/3uRLuIhMWq/hiHv+7AZ8ueu4ZacuR6OAEJs JAlvIZq/3CLZ/iI2SIQ70ew/gplOOFi75vY+udRJF5xaDktm125WhlKmMBwVAHHvyjhpY9bC5m1 SAXdj+Bpyn5697iaJO4Q5laXbTJE1XCMLXMCNqZRyy5IxGcgqh3gj6f+S3/PphhCSJklBQxtuqO XGy7A2t50rQEk0/DPzxCFy9OjDg6fGI1t7x/cFMi6EjU1hlZc6nT8UhV6vZ+GaVW7xq4F9/l1w9 noO2zgsqzJ+GUZtze+EstEFQ7/GjpZOoX+MX500/Aajn3T9D+D+RiALDHPH5CeCzoJsbq15rZvZ 7esOT9VCd/96BcTzCA0RXsUemkRfnKESbD4Eq9LFcGz X-Received: by 2002:a05:6512:159c:b0:5b1:5a31:85fa with SMTP id 2adb3069b0e04-5b459112f5bmr3161805e87.16.1786964635159; Mon, 17 Aug 2026 04:03:55 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b46cf95db3sm306642e87.12.2026.08.17.04.03.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 04:03:54 -0700 (PDT) Message-ID: <7155f6fd-435a-4176-aa9a-79888e0b5ccc@gmail.com> Date: Mon, 17 Aug 2026 14:03:53 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: gts-helper: fix error headers To: Javier Carrasco , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260815-iio-gts-err-headers-v1-1-3a668373aaae@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20260815-iio-gts-err-headers-v1-1-3a668373aaae@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/08/2026 01:23, Javier Carrasco wrote: > Both industrialio-gts-helper.c and iio-gts-helper.h use error codes > defined in (usually included via > ), but only industrialio-gts-helper.c includes it. On the > other hand, that file also uses error macros like IS_ERR() and > PTR_ERR(), which are included in . > > Add the right includes to provide the used elements from the error > headers: > > - in iio-gts-helper.h > > - in industrialio-gts-helper.c, which in turn includes > , which only includes > > Signed-off-by: Javier Carrasco > --- > I stumbled upon this while refactoring veml6031x00.c > (which uses IIO GTS) just because clangd threw a couple of errors where > -EINVAL is returned in iio-gts-helper.h > > In the end everything compiles anyway, and therefore I have not > added a "Fixes:" tag, but please let me know if that is really required > for something like this. It is also true that if the gts header is > included first, the compiler will throw the same error clangd showed me > and the kernel won't compile... Unlikely to ever happen, though. Unlikely or not, this sounds like an error to me. Hence, I don't think a fixes-tag would be wrong either. Anyways - thanks! Reviewed-by: Matti Vaittinen > > I have compiled and tested this implementation with the driver I am > attempting to upstream without any issues. > --- > drivers/iio/industrialio-gts-helper.c | 2 +- > include/linux/iio/iio-gts-helper.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/industrialio-gts-helper.c b/drivers/iio/industrialio-gts-helper.c > index 4f52dc373abf..af6ed37fb34a 100644 > --- a/drivers/iio/industrialio-gts-helper.c > +++ b/drivers/iio/industrialio-gts-helper.c > @@ -5,7 +5,7 @@ > */ > > #include > -#include > +#include > #include > #include > #include > diff --git a/include/linux/iio/iio-gts-helper.h b/include/linux/iio/iio-gts-helper.h > index 66f830ab9b49..f63a482b82b8 100644 > --- a/include/linux/iio/iio-gts-helper.h > +++ b/include/linux/iio/iio-gts-helper.h > @@ -7,6 +7,7 @@ > #ifndef __IIO_GTS_HELPER__ > #define __IIO_GTS_HELPER__ > > +#include > #include > > struct device; > > --- > base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482 > change-id: 20260814-iio-gts-err-headers-d7ecb6b5ebb7 > > Best regards, -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~