From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05BAC3242BC for ; Wed, 26 Nov 2025 11:38:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764157128; cv=none; b=fGoU+MEbcv95jXtWDzKnB7wpVHb07NBqUpDt2y9rcjNhquwZHAn0UeokO//RHh3uoiBHW9UYzuM7S5yPdK0OuX9PP1PWmV1XTHKb1BI74QG8eu+jPxVQmg7HzcLRmOitlwy5jUpwprR3Of8wm5oGeP7ncZDLXj5DUmbeiMeLx7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764157128; c=relaxed/simple; bh=uetH1gpQCMGCArNEY+4ysespicgo0/ixJStFpGQYZds=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oSzmQyrQFSoaV8k9xsN6lkdyDSKoo38yxrXAyizdjndjdzpMd5A2gueKO+wP4SXlQ6tPfb51gkqN9UAR4mQdfIGYPmKV1bGDOWDrWaYvaEiXoO3438XvsMpGIWfJw7rA8vDrMYNayDcWgQ/p8FMPKZU3X6fyLDSKrA1/O/uCDA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WORbRial; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BNMMkg5s; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WORbRial"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BNMMkg5s" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AQ9Y46C3317496 for ; Wed, 26 Nov 2025 11:38:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cMZ8nP22oqBJZ2lViVsuNFVcop8rQmSYUY6cSSx6MyM=; b=WORbRialXIZdcz8Z yz1HjchUH9I43W8/w702FxGXAJLYv6Tn8lK3CjrqRKNGYWlna8xzVSXz/KRP+ORr FgohVxnaGiviCgdrdZiXx0dfm2BQLI+UbmK4xuZOryk4bM10x2mrW9yWBnBgL4H3 k/jeqGH/zyfo/iCbwtsL5EnZW7RAy33xuvNrfhSSlahzd54pvQH9rZRhW/Nggpkp fZOI2YWPrkMCqYOVS84m9dWEK4aeIA2CwBgf5n8DUs5Fn9OfNH/TY19SHKaU/fNz JQH2IRB9u8u8ZejOWBFtqrN8IjDioxAPtCS4JmMbn0eFe4zrlwvGGXJMfseBZutk QWbcGQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4and2qkdu4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Nov 2025 11:38:42 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-341cd35b0f3so668181a91.0 for ; Wed, 26 Nov 2025 03:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764157121; x=1764761921; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cMZ8nP22oqBJZ2lViVsuNFVcop8rQmSYUY6cSSx6MyM=; b=BNMMkg5spKjdpryTsgog2MjjCdJqJPNCw50qOxC+GTpbWHkWK75Fn7fiEsTKgde3GB WdvkvcKiRkooeTSyLDuPNrUW9VOh8qYZocSG2bZOPDmU22ASZpRR2VA/uXwz9+PT7Lf3 FWg9R5ltB1bdJkU3HhLnMmu/JcwkgaSOXmp7OTbP8iPwNG0eLGU+ISveE83kqyqZSd8O UKAK6oAOkmbYP2vfaluaN1g9Nc/k0bEwXmErFhgbyqFXD+wYMqvBvERtU3GrKNsP+3g9 XT/x0NAJcoRni0tn2q8r1mGcyJjRBO/r91LB1Vs+/qKbbjakCeMWtWXLeB48nnuUPqEa PH6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764157121; x=1764761921; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cMZ8nP22oqBJZ2lViVsuNFVcop8rQmSYUY6cSSx6MyM=; b=vt3WYhC3y+D0xgLhtXGDZHQJPNjFI45kRNLv5I/5Xni8yyFGEvZfCEcsVadlSGXi3O rQmyj7AQydDa2sIYb6Np6fTUxzqEMb8lHjwPQj5HG+H/9rP/yWg3Gy6Sxk/KlyQnavOQ roADSMiFxkt6DAdx4+7unIAe/l2Qm7ESVGrXrGVoJDf0SCM/eQiJx5MzPx5AarRMUbBh 3V+Il8rsqa8izdYivkS4sdNoPNQCUmOl5D18uFDRLMkuyygyM7z74xeMAkfz4grgBTKa CZGu4p6ZmaSbsYYGUqOHDrDeXcZqQutw3hZLl+KID54P1BsjY989j9pLCPsPOFzjV+E2 5KeQ== X-Forwarded-Encrypted: i=1; AJvYcCUyI2M/VOcgitGg8e9x/aJwGhO28lQS70uz6+orvU4H5TcuMHtQo2+TrJ//YbbHd6/yEXIPrIpvKryowXc=@vger.kernel.org X-Gm-Message-State: AOJu0YwLp8NlPvMNX/r+iSiXuCqjxoDJ/olrX8Fm3SdetMh9Dd3IzW1p h15++jt4WZNSmBj7HJqISkI/ltsMy9BUnjVmQ9/McgbgdMJvaDN+6vKcFXWxIFcGZC/R+teF3/A +yTq3MAHBwx/ICWCupkcc6XMpXvdK+APHcf7Pm6sZY8bGaml6vezR1dk+/SHSOxUcobM= X-Gm-Gg: ASbGncu6p46xlIH2NtK+G0Cf3LJw8oBJKLhkSCiXwL7hrJYg3aj1joH3nYl9TARunMG nuCT5gfcmiR0H43V31x1D70fcpZAjmlwQ5J/CSbGSctq32A4IJOrwnMJjZrchZoVTxmXhr7lLQY GPogQNAC01v3F5t21e/79WsotVK56oenZhEyqpqc8lva8OwEei4jPhq+7tCCOhCmA+N1i9lK/tQ 69k7pXgHWpwpv2g5Z40QF9tdvQOWi5VC4PWMY8mL0IpYq38qYb5dAcde2EB6H0PRZnqd1jbtpDh ddvzq8viHOl5/8r5BRjBtNaUiq0wWGEzz1ykfTGcheOW48ox5VGfGKQivhrKVjstVxW/IhSEa+f 6lyLHeGMYZhqEFnduDEHB81i7jwarcrFrTHsc4NffhKAkICrhrlDNK/bi97SsdZ/iIigzHXwCZL x3jcdJHASf3MddbqlasBTxDwp3SpyW X-Received: by 2002:a17:90b:2d4d:b0:340:9d78:59 with SMTP id 98e67ed59e1d1-3472983a0a1mr22911525a91.3.1764157121318; Wed, 26 Nov 2025 03:38:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEBT+pTARfErEXVdl1abES4By5ZJEcqIH74/QYD4cbt7jTWebv+5raGl664Wuvz/agcEfkOw== X-Received: by 2002:a17:90b:2d4d:b0:340:9d78:59 with SMTP id 98e67ed59e1d1-3472983a0a1mr22911487a91.3.1764157120852; Wed, 26 Nov 2025 03:38:40 -0800 (PST) Received: from [10.190.200.209] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3476a7a6105sm2319202a91.10.2025.11.26.03.38.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Nov 2025 03:38:40 -0800 (PST) Message-ID: <7158bde2-bf70-4a2d-b19f-fcc24cc37d28@oss.qualcomm.com> Date: Wed, 26 Nov 2025 17:08:35 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] soc: qcom: llcc: Fix usecase id macro alignment To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Conor Dooley , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251125-glymur_llcc_enablement-v2-0-75a10be51d74@oss.qualcomm.com> <20251125-glymur_llcc_enablement-v2-2-75a10be51d74@oss.qualcomm.com> <20251126-gigantic-dinosaur-of-bloom-aca95f@kuoka> Content-Language: en-US From: Pankaj Patil In-Reply-To: <20251126-gigantic-dinosaur-of-bloom-aca95f@kuoka> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDA5NSBTYWx0ZWRfX2hA6dtWtSCsA pjkOlbT+qDJ9BoAQaVNoACHvMZtzN/VruvjSa+weZeedu4nnCavL9Bfs8DnWGywsVp9uhHCm56g +UOPZjiJ5RVypAzQsJw7oQ1gA3ziIXI1+prYLW+udhrTHTCbvHud0FHUhDwxSnP1Pw4FYdCruy7 bN+nLWEYvvP7fZkXbSQk5OmA9RmoZWCfPs/lflu2Q8ucLvwt+UDieJAtK0KvjJmUt6EC+ULcjkJ rAq+q8XCt7Dx/Rj1r3s8OJ66CoLOKIjWR6sTbuepkpNhL6WAiquYphlts3xoC90QCjwYOJsCj85 7uK4G5Dd9alLNFRc+mAOEQvW1ScNYJJsuS6aI8u3cWO7J9FP1UrfoKixtGgTyWFojBvruGc/J9C YdC2iyL7Ax0V4Q4oQ5P3fYqWCqPmBA== X-Authority-Analysis: v=2.4 cv=dZyNHHXe c=1 sm=1 tr=0 ts=6926e6c2 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=JLVAI_iM7606iRLUKQwA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: 0gwq7UeCHZQx5ocukmBDYLTKksCf1ycL X-Proofpoint-GUID: 0gwq7UeCHZQx5ocukmBDYLTKksCf1ycL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 spamscore=0 clxscore=1015 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260095 On 11/26/2025 2:29 PM, Krzysztof Kozlowski wrote: > On Tue, Nov 25, 2025 at 02:46:23PM +0530, Pankaj Patil wrote: >> Aligned macro values for usecase id along the column length >> -#define LLCC_CAMOFE 71 >> -#define LLCC_CAMRTIP 72 >> -#define LLCC_CAMSRTIP 73 >> -#define LLCC_CAMRTRF 74 >> -#define LLCC_CAMSRTRF 75 >> -#define LLCC_VIDEO_APV 83 >> -#define LLCC_COMPUTE1 87 >> -#define LLCC_CPUSS_OPP 88 >> -#define LLCC_CPUSSMPAM 89 >> -#define LLCC_CAM_IPE_STROV 92 >> -#define LLCC_CAM_OFE_STROV 93 >> -#define LLCC_CPUSS_HEU 94 >> -#define LLCC_MDM_PNG_FIXED 100 >> +#define LLCC_CPUSS 1 >> +#define LLCC_VIDSC0 2 >> +#define LLCC_VIDSC1 3 >> +#define LLCC_ROTATOR 4 >> +#define LLCC_VOICE 5 > This does not look right - you still have here spaces, so nothing fixed. > > I don't think this change is useful. You replaced one poor alignment > into another poor alignment, so IMO better not to touch this at all. > > Best regards, > Krzysztof > Sure, Will drop this patch in next revision