From: Dan Carpenter <dan.carpenter@linaro.org>
To: Alexon Oliveira <alexondunkan@gmail.com>
Cc: gregkh@linuxfoundation.org, martyn@welchs.me.uk,
manohar.vanga@gmail.com, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] staging: vme_user: fix check alignment should match open parenthesis
Date: Fri, 4 Aug 2023 16:46:00 +0300 [thread overview]
Message-ID: <7159231c-9e87-4a3b-bc0d-a6ade6c04c65@kadam.mountain> (raw)
In-Reply-To: <ZMkwA8TnMBAgPRgR@alolivei-thinkpadt480s.gru.csb>
On Tue, Aug 01, 2023 at 01:17:07PM -0300, Alexon Oliveira wrote:
> First patch was intended to fix all "CHECK: Alignment should match open parenthesis",
> but added new warnings in the process. This patch is intended to fixed them all,
> on lines 133, 142, 144, 145 and 173.
>
Since you're going to be re-writing the commit message anyway, please
leave off the line numbers. Line numbers are not really useful. Just
say:
Fix the checkpatch warnings which complain about "CHECK: Alignment
should match open parenthesis".
regards,
dan carpenter
next prev parent reply other threads:[~2023-08-04 13:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 16:17 Alexon Oliveira
2023-08-04 13:23 ` Greg KH
2023-08-04 14:07 ` Alexon Oliveira
2023-08-04 14:11 ` Dan Carpenter
2023-08-04 14:16 ` Alexon Oliveira
2023-08-04 13:46 ` Dan Carpenter [this message]
2023-08-04 14:13 ` Alexon Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7159231c-9e87-4a3b-bc0d-a6ade6c04c65@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=alexondunkan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®