From: Akira Yokosawa <akiyks@gmail.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: corbet@lwn.net, konstantin@linuxfoundation.org,
krzysztof.kozlowski@linaro.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@leemhuis.info,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH v3] Documentation/process: Add text to indicate supporters should be mailed
Date: Sun, 2 Oct 2022 09:27:59 +0900 [thread overview]
Message-ID: <71599eac-04ef-66d1-50d5-ebc564a6bf1d@gmail.com> (raw)
In-Reply-To: <70759d05-2646-57e5-0b87-3a196488f622@linaro.org>
On Sat, 1 Oct 2022 11:37:03 +0100, Bryan O'Donoghue wrote:
> On 01/10/2022 03:37, Theodore Ts'o wrote:
>> FWIW, I actually think the output of get_maintainer.pl is pretty
>> broken in this regard. (Then again, I've never thought all that
>> highly of get_maintainer.pl,*especially* because of the bogus git
>> fallback, but that's another story.)
>>
>> Consider:
>>
>> % ./scripts/get_maintainer.pl --file drivers/acpi/power.c
>> "Rafael J. Wysocki"<rafael@kernel.org> (supporter:ACPI)
>> Len Brown<lenb@kernel.org> (reviewer:ACPI)
>> linux-acpi@vger.kernel.org (open list:ACPI)
>> linux-kernel@vger.kernel.org (open list)
>>
>> I'm sorry, but that's just*wrong*. Rafael is the*maintainer* of the
>> ACPI subsystem, and the term "supporter" is rarely if ever used
>> anywhere in our docs. As I said earlier, trying to treat S: field to
>> say anything about the entitles listed under the M: field of the
>> Maintainers file is a category error.
>
> I agree, I made exactly this error.
>
> I wasn't sure how people would necessarily feel about having
> get_maintainer produce the string 'maintainer' for both Maintained and
> Supported but, IMO it is more consistent to have it do so, since we refer
> to maintainers all throughout the doucmentation and as you say above Rafael
> is the person you *need* to mail there because he's the maintainer.
You'd better CC Joe Perches, who is the maintainer of get_maintainer.pl.
You might want to start a new thread with a different subject.
The main point becomes the behavior of get_maintainer.pl.
>
> Lets consider
>
> - maintainer as a string for "S: Supported"
> - Documentation update to reflect Krzysztof's point on git-fallback
Sounds reasonable to me.
Good luck!
Thanks,
Akira
>
> ---
> bod
next prev parent reply other threads:[~2022-10-02 0:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 6:46 [PATCH v3 0/1] Expand get_maintainer to be explicit about supporters Bryan O'Donoghue
2022-09-30 6:46 ` [PATCH v3] Documentation/process: Add text to indicate supporters should be mailed Bryan O'Donoghue
2022-09-30 14:47 ` Akira Yokosawa
2022-09-30 16:18 ` Bryan O'Donoghue
2022-09-30 16:34 ` Bryan O'Donoghue
2022-10-01 2:37 ` Theodore Ts'o
2022-10-01 10:37 ` Bryan O'Donoghue
2022-10-02 0:27 ` Akira Yokosawa [this message]
2022-10-02 7:58 ` Krzysztof Kozlowski
2022-10-02 15:49 ` Joe Perches
2022-10-02 23:04 ` Akira Yokosawa
2022-10-02 23:55 ` Joe Perches
2022-10-03 1:17 ` Akira Yokosawa
2022-10-03 1:28 ` Joe Perches
2022-09-30 18:41 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71599eac-04ef-66d1-50d5-ebc564a6bf1d@gmail.com \
--to=akiyks@gmail.com \
--cc=bryan.odonoghue@linaro.org \
--cc=corbet@lwn.net \
--cc=konstantin@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®