From: "Cheatham, Benjamin" <benjamin.cheatham@amd.com>
To: Richard Cheng <icheng@nvidia.com>, <jic23@kernel.org>,
<dave@stgolabs.net>, <dave.jiang@intel.com>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<iweiny@kernel.org>
Cc: <ming.li@zohomail.com>, <kaihengf@nvidia.com>, <kobak@nvidia.com>,
<newtonl@nvidia.com>, <kristinc@nvidia.com>, <mochs@nvidia.com>,
<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] PCI/CXL: Guard reset recovery against inaccessible devices
Date: Fri, 30 Oct 2026 16:04:27 -0500 [thread overview]
Message-ID: <715b5f44-2f0f-4c96-886e-a78d57ee17f0@amd.com> (raw)
In-Reply-To: <20260929020405.9724-1-icheng@nvidia.com>
I noticed that linux-pci isn't CC'ed. Seems like a big oversight considering 3/4 of the patches
are in the PCI code...
I'd resend to this with that list in the CC, or at least include it in a v2.
Thanks,
Ben
On 9/28/2026 9:04 PM, Richard Cheng wrote:
> During FLR testing, PCI configuration reads returned all ones. The
> kernel could mistake this for reset completion and proceed with MSI-X
> restoration. The resulting MMIO access triggered DPC containment.
>
> This series addresses four issues:
>
> 1. Reject all-ones responses in pci_dev_wait(). Use Command-register
> polling for VFs, whose Vendor ID legitimately reads as all ones.
>
> 2. Return -ETIMEDOUT when readiness polling expires, preventing fallback
> to another reset method.
>
> 3. Check configuration accessibility before restoring PCI state, while
> preserving driver reset callbacks.
>
> 4. Skip CXL decoder MMIO accesses when configuration is inaccessible
> or memory decoding is disabled.
>
>
> Best regards,
> Richard Cheng.
>
> Richard Cheng (4):
> PCI: Reject all-ones responses in pci_dev_wait()
> PCI: Return -ETIMEOUT when reset readiness polling expires
> PCI: Skip state restoration when configuration is inaccessible
> cxl/pci: Guard decoder accesses after reset
>
> drivers/cxl/pci.c | 6 ++++++
> drivers/pci/pci.c | 16 +++++++++-------
> 2 files changed, 15 insertions(+), 7 deletions(-)
>
>
> base-commit: 9eb6419022d81aac6d1d9ead0e1865b451153da5
prev parent reply other threads:[~2026-10-30 21:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 2:04 Richard Cheng
2026-09-29 2:04 ` [PATCH 1/4] PCI: Reject all-ones responses in pci_dev_wait() Richard Cheng
2026-09-29 2:04 ` [PATCH 2/4] PCI: Return -ETIMEOUT when reset readiness polling expires Richard Cheng
2026-10-30 21:04 ` Cheatham, Benjamin
2026-09-29 2:04 ` [PATCH 3/4] PCI: Skip state restoration when configuration is inaccessible Richard Cheng
2026-10-30 21:04 ` Cheatham, Benjamin
2026-09-29 2:04 ` [PATCH 4/4] cxl/pci: Guard decoder accesses after reset Richard Cheng
2026-10-30 17:34 ` Dave Jiang
2026-10-30 9:54 ` [PATCH 0/4] PCI/CXL: Guard reset recovery against inaccessible devices Richard Cheng
2026-10-30 21:04 ` Cheatham, Benjamin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=715b5f44-2f0f-4c96-886e-a78d57ee17f0@amd.com \
--to=benjamin.cheatham@amd.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=icheng@nvidia.com \
--cc=iweiny@kernel.org \
--cc=jic23@kernel.org \
--cc=kaihengf@nvidia.com \
--cc=kobak@nvidia.com \
--cc=kristinc@nvidia.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.li@zohomail.com \
--cc=mochs@nvidia.com \
--cc=newtonl@nvidia.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®