From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B72322129E for ; Thu, 24 Apr 2025 10:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745490971; cv=none; b=Rk/vEHPvKW7fOx31Km0uEt/+4qKxU6d6lLNkjFm9U0S6pykX8lpGqoyQ8omWrxu4Utpt/xzPlPI+eDkq3S7W/oFC20Z3fFBstHhndc680ymL1REtPFsHi3Z+PuzY7h2DtYH7/pEmn8HWNeZ4cvaXb7p6zyLDbqeWc0eDxx3qeMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745490971; c=relaxed/simple; bh=o9S3xS6x/7ltvjnbA8prO8mDFGuFdVAzu8uNbExAUYs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bvpIBa9VVBZf/fn0pIjl5VC9fYHPjSlNf29TfOe+rPza76TH6YPEQJu5gQCycDV4w6W1H5X+5oXN9+wrFwz/b7hZ4z88ELAHOT4TFMry1NJJn7y8y8coWb7Vmz+RmK3002yhWDwUtZ9sGfLHRo7f8DskILhhTdIRyB0N3fclJgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=RCIVoVZr; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=wmiYlx81; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=RCIVoVZr; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=wmiYlx81; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="RCIVoVZr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="wmiYlx81"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="RCIVoVZr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="wmiYlx81" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 68F8B1F44E; Thu, 24 Apr 2025 10:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745490960; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LMsTwHgoOwVW/cg0h8z/MHHeXCOyNAgrsW4S8mz0gNI=; b=RCIVoVZrHp1ewBFK6UtPQC80lU88rn3AkqYuU78L0WwpRUtcIWoOlDZZfI/qWUL4q8CRfi 2J+hSQ5aHX/hIc0BJ87M9eSdZF9pzRztzIGVsei6MT77TeleukgUMgdqW5YaDXuRHOk1Kf mkfitFTVm07aiAq3KJyXOz4pv0gmDsA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745490960; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LMsTwHgoOwVW/cg0h8z/MHHeXCOyNAgrsW4S8mz0gNI=; b=wmiYlx8144vEFING7hgW1LPApBpDO7uI4wUqLgrBaBmZbHl6M3bMIMtKwzKCXZ60XQxxuN OJsP6XxL0+cx3xCg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RCIVoVZr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wmiYlx81 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745490960; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LMsTwHgoOwVW/cg0h8z/MHHeXCOyNAgrsW4S8mz0gNI=; b=RCIVoVZrHp1ewBFK6UtPQC80lU88rn3AkqYuU78L0WwpRUtcIWoOlDZZfI/qWUL4q8CRfi 2J+hSQ5aHX/hIc0BJ87M9eSdZF9pzRztzIGVsei6MT77TeleukgUMgdqW5YaDXuRHOk1Kf mkfitFTVm07aiAq3KJyXOz4pv0gmDsA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745490960; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LMsTwHgoOwVW/cg0h8z/MHHeXCOyNAgrsW4S8mz0gNI=; b=wmiYlx8144vEFING7hgW1LPApBpDO7uI4wUqLgrBaBmZbHl6M3bMIMtKwzKCXZ60XQxxuN OJsP6XxL0+cx3xCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5322D139D0; Thu, 24 Apr 2025 10:36:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id n97RExAUCmg3LQAAD6G6ig (envelope-from ); Thu, 24 Apr 2025 10:36:00 +0000 Message-ID: <7162ce42-9992-4005-b1fc-6763366f91dd@suse.de> Date: Thu, 24 Apr 2025 12:35:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme-tcp: select tls config when tcp tls is enabled To: Alistair Francis , hch@lst.de, sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Alistair Francis References: <20250424101333.2908504-1-alistair.francis@wdc.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250424101333.2908504-1-alistair.francis@wdc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 68F8B1F44E X-Spam-Score: -4.51 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_TO(0.00)[gmail.com,lst.de,grimberg.me,nvidia.com,lists.infradead.org]; FUZZY_BLOCKED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Level: On 4/24/25 12:13, Alistair Francis wrote: > Ensure that TLS support is enabled in the kernel when > NVME_TARGET_TCP_TLS is enabled. This allows TLS secure channels to be > used out of the box. > > Signed-off-by: Alistair Francis > --- > drivers/nvme/target/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig > index fb7446d6d682..4c253b433bf7 100644 > --- a/drivers/nvme/target/Kconfig > +++ b/drivers/nvme/target/Kconfig > @@ -98,6 +98,7 @@ config NVME_TARGET_TCP_TLS > bool "NVMe over Fabrics TCP target TLS encryption support" > depends on NVME_TARGET_TCP > select NET_HANDSHAKE > + select TLS > help > Enables TLS encryption for the NVMe TCP target using the netlink handshake API. > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich