From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753536Ab3JKWvx (ORCPT ); Fri, 11 Oct 2013 18:51:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48405 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984Ab3JKWvw (ORCPT ); Fri, 11 Oct 2013 18:51:52 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20131011151402.33dfe46e@tlielax.poochiereds.net> References: <20131011151402.33dfe46e@tlielax.poochiereds.net> <20131011161659.15534.27955.stgit@warthog.procyon.org.uk> To: Jeff Layton Cc: dhowells@redhat.com, jmorris@namei.org, Scott Mayhew , keyrings@linux-nfs.org, Dave Wysochanski , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH] KEYS: Fix a race between negating a key and reading the error set Date: Fri, 11 Oct 2013 23:51:46 +0100 Message-ID: <7165.1381531906@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeff Layton wrote: > > - if (kflags & (1 << KEY_FLAG_NEGATIVE)) > > + if (kflags & (1 << KEY_FLAG_NEGATIVE)) { > > Not specifically related to this bug, but why are you open-coding > test_bit() here and elsewhere? Because kflags is read once and kept in a variable. Might not be necessary - and I should probably use ACCESS_ONCE() when I do. David