From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Aditya Garg <aditya.garg@linux.dev>
Cc: Andre Eikmeyer <dev@deq.rocks>,
linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org,
Yossef Osman <Yossef.Osman@proton.me>
Subject: Re: [PATCH] wifi: brcmfmac: disable TX beamforming on BCM4364
Date: Tue, 17 Nov 2026 20:46:42 +0100 [thread overview]
Message-ID: <716869b3-adaf-4155-88bf-638952dd358f@broadcom.com> (raw)
In-Reply-To: <2FBC4AA9-16FE-4710-B43D-9004B0B17DFA@linux.dev>
On 17/11/2026 18:50, Aditya Garg wrote:
>
>
>> On 17 Nov 2026, at 2:07 AM, Arend van Spriel <arend.vanspriel@broadcom.com> wrote:
>>
>> On Wed, 4 Nov 2026 16:16:23 +0100, Andre Eikmeyer <dev@deq.rocks> wrote:
>>> With "txbf" enabled, the BCM4364 firmware (9.30.514.0.32.5.94, as shipped
>>> by Apple for the MacBookPro15,1) transmits a single beamformed spatial
>>> stream (nrate VHT MCS9 NSS1 TXBF) towards a two stream AP. With "txbf"
>>> cleared it picks two streams (VHT MCS9 NSS2) on its own. The firmware
>>> enables "txbf" by default, so the driver has to clear it.
>>>
>>> [...]
>>>
>>> Tested-by: Yossef Osman <Yossef.Osman@proton.me>
>>> Tested-by: Aditya Garg <aditya.garg@linux.dev>
>>> Signed-off-by: Andre Eikmeyer <dev@deq.rocks>
>>
>> [...]
>>
>>> @@ -450,8 +451,12 @@ int brcmf_c_preinit_dcmds(struct brcmf_if *ifp)
>>> goto done;
>>> }
>>>
>>> - /* Enable tx beamforming, errors can be ignored (not supported) */
>>> - (void)brcmf_fil_iovar_int_set(ifp, "txbf", 1);
>>> + /* Enable tx beamforming, errors can be ignored (not supported).
>>> + * BCM4364 firmware enables it by default and then transmits a single
>>> + * beamformed stream instead of two, halving its uplink throughput.
>>> + */
>>> + (void)brcmf_fil_iovar_int_set(ifp, "txbf",
>>> + drvr->bus_if->chip != BRCM_CC_4364_CHIP_ID);
>>> done:
>>> return err;
>>> }
>>
>> The chip ID check has the same problem as in the ARP/ND offload patch [1]:
>> the issue is described as specific to the firmware shipped by Apple
>> (9.30.514.0.32.5.94), but the quirk applies to every BCM4364. Please
>> restrict it as suggested there.
>>
>> Also, the comment says "Enable tx beamforming" while the code now
>> conditionally disables it. Please make the code self-explanatory, e.g. a
>> local variable or an explicit if (chip == BRCM_CC_4364_CHIP_ID) with the
>> txbf value spelled out, instead of passing a bool expression as the
>> iovar value.
>>
>> Minor: typo "refression" in the commit message, and the subject lacks
>> the target tree (wireless-next) which wifibot flagged.
>>
>> Since this is a throughput quirk (not a fix) I would also like to know
>> whether TX beamforming is functional at all on the BCM4364 or just
>> mis-selected by rate control, so the commit message can state the actual
>> root cause.
>
> Unrelated but Airdrop conversation seems to have been stalled :(.
Indeed unrelated so let me respond to your earlier email that was more
on the subject.
Regards,
Arend
prev parent reply other threads:[~2026-11-17 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 15:16 Andre Eikmeyer
2026-11-16 20:37 ` Arend van Spriel
2026-11-17 17:50 ` Aditya Garg
2026-11-17 19:46 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=716869b3-adaf-4155-88bf-638952dd358f@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Yossef.Osman@proton.me \
--cc=aditya.garg@linux.dev \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=dev@deq.rocks \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®