From: David Ahern <dsahern@kernel.org>
To: Breno Leitao <leitao@debian.org>,
weiwan@google.com, kuba@kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: leit@meta.com,
"open list:NETWORKING [IPv4/IPv6]" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] net/ipv6: Remove unnecessary pr_debug() logs
Date: Mon, 8 Jan 2024 12:20:11 -0700 [thread overview]
Message-ID: <716b825f-67b7-4d08-9bd6-41c9bc4deb3d@kernel.org> (raw)
In-Reply-To: <20240108191254.3422696-1-leitao@debian.org>
On 1/8/24 12:12 PM, Breno Leitao wrote:
> In the ipv6 system, we have some logs basically dumping the name of the
> function that is being called. This is not ideal, since ftrace give it
> to us "for free". Moreover, checkpatch is not happy when touching that
> code:
>
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
>
> Remove debug functions that only print the current function name.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> net/ipv6/ip6_fib.c | 4 ----
> 1 file changed, 4 deletions(-)
>
net-next is currently closed; repost in 2 weeks once it is re-opened.
You can add this to both patches:
Reviewed-by: David Ahern <dsahern@kernel.org>
prev parent reply other threads:[~2024-01-08 19:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 19:12 Breno Leitao
2024-01-08 19:12 ` [PATCH net-next 2/2] net/ipv6: resolve warning in ip6_fib.c Breno Leitao
2024-01-08 19:20 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=716b825f-67b7-4d08-9bd6-41c9bc4deb3d@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leit@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®