From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 477EA329E70 for ; Fri, 27 Feb 2026 03:41:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772163695; cv=none; b=Ef6M5RsfJmF8qQ98qYmqq7l+H1dydF2Ayo1GwrhNzfzyxOhRUR71u0uk5GluAr/KKzmx5RDZCvSM/N0WQ5QzIKH557z5zWOuZ5AcOc+WmGoxCHpWskn4yB8Eqmw7DQ2enZrQIYgxMgmTE/OmMEYcnrkIe4JG/Y4hcPRzuUnjUio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772163695; c=relaxed/simple; bh=ReP/t+sNuI+NeqvfEBmucucDNKOKIbHaD81OVga54ZY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ykvg8b4h5WB18vSvlwJ5ohUxu4aouLpWuUIva1tw2x6CmkbArcjtc2Fpzllrwv20wvdrn8pQGurJPZ5OETFGtuNeyQDV2rl21bIWwRNFQGMTx36Wb8fN7hPb132tiangBgopng6sKdz5q4HCcVY62OMH68m6xiDu6zcShkVpsVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=BxwDclgX; arc=none smtp.client-ip=115.124.30.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="BxwDclgX" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1772163690; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=MIEGvNRSN8Ft3JD1G/auxIPgpq3JvDOmV7i/jfxfhDU=; b=BxwDclgXLlT1t9DZvn5mxSYOoCbRFsfKlgLN6KdHAXtAm0LjvugEZaTW36b4xG7YvPGNSJzgX1mt1RmGHwWXbK6SufCcxOizQ0UwduL6Hd/MSuWtc7LOq3eDa1p5LUH0zMDZYW3cs7zYW8m3TH6qbuvhPF+u4iHsqNPAZJjqC2Y= Received: from 30.221.131.231(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Wzt0qjS_1772163689 cluster:ay36) by smtp.aliyun-inc.com; Fri, 27 Feb 2026 11:41:29 +0800 Message-ID: <716c0229-85f1-44a4-aec3-a64ed6360761@linux.alibaba.com> Date: Fri, 27 Feb 2026 11:41:28 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] erofs: set fileio bio failed in short read case To: Sheng Yong , xiang@kernel.org Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Sheng Yong , chenguanyou , Yunlei He References: <20260227023008.147813-1-shengyong2026@sina.com> From: Gao Xiang In-Reply-To: <20260227023008.147813-1-shengyong2026@sina.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Yong, On 2026/2/27 10:30, Sheng Yong wrote: > From: Sheng Yong > > For file-backed mount, IO requests are handled by vfs_iocb_iter_read(). > However, it can be interrupted by SIGKILL, returning the number of > bytes actually copied. Unused folios in bio are unexpectedly marked > as uptodate. > > vfs_read > filemap_read > filemap_get_pages > filemap_readahead > erofs_fileio_readahead > erofs_fileio_rq_submit > vfs_iocb_iter_read > filemap_read > filemap_get_pages <= detect signal > erofs_fileio_ki_complete <= set all folios uptodate > > This patch addresses this by setting short read bio with an error > directly. > > Fixes: bc804a8d7e86 ("erofs: handle end of filesystem properly for file-backed mounts") > Reported-by: chenguanyou > Signed-off-by: Yunlei He > Signed-off-by: Sheng Yong LGTM, yet I still need more time to run some tests before upstreaming this in order to miss any corner cases. You could run more tests in the same time, thanks! Reviewed-by: Gao Xiang Thanks, Gao Xiang