From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2ACECAAD3 for ; Wed, 14 Sep 2022 12:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230181AbiINMTX (ORCPT ); Wed, 14 Sep 2022 08:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230036AbiINMTR (ORCPT ); Wed, 14 Sep 2022 08:19:17 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12FB680377; Wed, 14 Sep 2022 05:19:15 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id CA1F56602024; Wed, 14 Sep 2022 13:19:12 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1663157953; bh=DCleAYfEI4FJICAKJmFAzxyRVAsE5kyhf9NIXG8/TQg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iLNpgK4Z8geWBsieZdhoFb89uWkA+E0sHPCj139QVypsVXlxeCsTgUOj/UNUgt7Ih Prb1DDFgDgnfvWFu15+3ZWQJ681MbW/Wz44S5Z63Jr9NQePTvxKaphp2dUWUxiooTC 5ayh0D2LyUEKhfCULmEsUC/5wP80dzkhDG8RZlmoygwlWjTOy3uapatuQ75hSV8sd0 49Sopl5KuwI2m7dxKaXbYgpyG/s6Y8LZliDZJj3a1NqFcXsN19/ttr32ZRrZov5Y7r JVjGbP0eCFFNi1bzZTlQOqD+jwbUvI8K/jDtAW9GIaHLSoVK/wApxUBxRjcrN9mc3C htufRQwrpSmXA== Message-ID: <716d6471-f0e2-489e-5f9e-9e38e9e7953a@collabora.com> Date: Wed, 14 Sep 2022 14:19:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v9,2/7] dt-bindings: thermal: Add dt-binding document for LVTS thermal controllers Content-Language: en-US To: bchihi@baylibre.com, rafael@kernel.org, rui.zhang@intel.com, daniel.lezcano@linaro.org, amitk@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, khilman@baylibre.com, mka@chromium.org, robh+dt@kernel.org, krzk+dt@kernel.org, matthias.bgg@gmail.com, p.zabel@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, james.lo@mediatek.com, fan.chen@mediatek.com, louis.yu@mediatek.com, rex-bc.chen@mediatek.com, abailon@baylibre.com References: <20220817080757.352021-1-bchihi@baylibre.com> <20220817080757.352021-3-bchihi@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220817080757.352021-3-bchihi@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 17/08/22 10:07, bchihi@baylibre.com ha scritto: > From: Alexandre Bailon > > Add dt-binding document for mt8192 and mt8195 LVTS thermal controllers. > > Signed-off-by: Alexandre Bailon > Co-developed-by: Balsam CHIHI > Signed-off-by: Balsam CHIHI > --- > .../thermal/mediatek,lvts-thermal.yaml | 152 ++++++++++++++++++ > 1 file changed, 152 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > new file mode 100644 > index 000000000000..31d9e220513a > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > @@ -0,0 +1,152 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek SoC LVTS thermal controller title: MediaTek SoC Low Voltage Thermal Sensor (LVTS) > + > +maintainers: > + - Yu-Chia Chang > + - Ben Tseng > + > +description: | description: LVTS is a thermal management architecture composed of three subsystems, a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU), a Convertor - Low Voltage Thermal Sensor convertor (LVTS), and a Digital controller (LVTS_CTRL). > + LVTS (Low Voltage Thermal Sensor). > + The architecture will be first used on mt8192 and mt8195. > + > +properties: > + compatible: > + enum: > + - mediatek,mt8192-lvts-ap > + - mediatek,mt8192-lvts-mcu > + - mediatek,mt8195-lvts-ap > + - mediatek,mt8195-lvts-mcu > + > + "#thermal-sensor-cells": > + const: 1 > + > + reg: > + maxItems: 1 > + description: LVTS instance registers. This description looks obvious, as it doesn't really say anything "new"... I would rather drop it. > + > + interrupts: > + maxItems: 1 > + description: LVTS instance interrupts. Same here > + > + clocks: > + maxItems: 1 > + description: LVTS instance clock. and here. > + > + resets: > + maxItems: 1 > + description: | > + LVTS instance SW reset for HW AP/MCU domain to clean temporary data > + on HW initialization/resume. What about something like... resets: items: - description: LVTS reset for clearing temporary data on AP/MCU > + > + nvmem-cells: > + minItems: 1 > + maxItems: 2 > + description: Calibration efuse data for LVTS nvmem-cells: minItems: 1 items: - description: Calibration eFuse data for LVTS - description: Additional eFuse data (?) > + > + nvmem-cell-names: > + minItems: 1 > + maxItems: 2 > + description: Calibration efuse cell names for LVTS Actually, maxItems is not really two, but it depends on how many eFuse arrays / nvmem cells we have for each SoC, so I was thinking... ...what about doing something like nvmem-cell-names: minItems: 1 items: pattern: 'lvts-calib-data[0-9]+$' and then, if: properties: compatible: contains: enum: - mediatek,blahblah-something then: properties: nvmem-cell-names: maxItems: 2 (or 3, 4, 5...) P.S.: I haven't tried any binding check on the proposed lines. Krzysztof, any opinions on that? Regards, Angelo