mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@nbd.name>
To: Kai Heng Feng <kai.heng.feng@canonical.com>,
	Kalle Valo <kvalo@codeaurora.org>
Cc: ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath9k: turn on btcoex_enable as default
Date: Sat, 10 Feb 2018 15:05:05 +0100	[thread overview]
Message-ID: <7170e2d5-a59d-8260-fa8e-f02f583b773f@nbd.name> (raw)
In-Reply-To: <E500FA42-23F1-433F-9BFB-78A2FD1946AF@canonical.com>

On 2018-02-10 14:56, Kai Heng Feng wrote:
> 
>> On 9 Feb 2018, at 3:16 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Sure, but we have to make sure that we don't create regressions on
>> existing systems. For example, did you test this with any system which
>> don't support btcoex? (just asking, haven't tested this myself)
> 
> No not really, but I will definitely test it.
> The only module I have that uses ath9k is Dell’s DW1707.
> How do I check if it support btcoex or not?
I just reviewed the code again, and I am sure that we cannot merge this
patch. Enabling the btcoex parameter makes the driver enable a whole
bunch of code starting timers, listening to some GPIOs, etc.

On non-btcoex systems, some of those GPIOs might be floating or even
connected to different things, which could cause a lot of undefined
behavior.

This is simply too big a risk, so there absolutely needs to be a
whitelist for systems that need this, otherwise it has to remain
disabled by default.

- Felix

  reply	other threads:[~2018-02-10 14:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-08  5:28 Kai-Heng Feng
2018-02-08 11:02 ` Felix Fietkau
2018-02-09  4:21   ` Kai Heng Feng
2018-02-09  7:16     ` Kalle Valo
2018-02-10 13:56       ` Kai Heng Feng
2018-02-10 14:05         ` Felix Fietkau [this message]
2018-02-12  4:15           ` Kai Heng Feng
2018-08-23  1:33             ` Kai-Heng Feng
2018-08-23 11:18               ` Kalle Valo
2018-08-23 17:06                 ` Tom Psyborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7170e2d5-a59d-8260-fa8e-f02f583b773f@nbd.name \
    --to=nbd@nbd.name \
    --cc=ath9k-devel@qca.qualcomm.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®