From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: Toshi Kani <toshi.kani@hp.com>,
linux-acpi@vger.kernel.org, tangchen@cn.fujitsu.com,
wency@cn.fujitsu.com, laijs@cn.fujitsu.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
Date: Tue, 02 Apr 2013 01:48:02 +0200 [thread overview]
Message-ID: <7171436.IWIKuTHVjL@vostro.rjw.lan> (raw)
In-Reply-To: <5153878B.2050307@jp.fujitsu.com>
On Thursday, March 28, 2013 08:58:03 AM Yasuaki Ishimatsu wrote:
> Hi Rafael,
>
> 2013/03/26 22:41, Rafael J. Wysocki wrote:
> > On Tuesday, March 26, 2013 08:57:05 AM Yasuaki Ishimatsu wrote:
> >> 2013/03/23 5:24, Toshi Kani wrote:
> >>> On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
> >>>> acpi_memory_info has enabled bit and failed bit for controlling memory
> >>>> hotplug. But we don't need to keep both bits.
> >>>>
> >>>> The patch removes acpi_memory_info->failed bit.
> >>>>
> >>>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> >>>
> >>> Thanks for the update. It looks good. For the series:
> >>>
> >>> Acked-by: Toshi Kani <toshi.kani@hp.com>
> >>
> >> Thanks!
> >
> > Both patches applied to linux-pm.git/linux-next.
>
> Thank you for applying both patches.
> If you don't mind, I hope these patches are merged into linux-3.9
> since this is bug fix.
I honestly don't think that [2/2] is 3.9 material, but I can push [1/2]
for 3.9 provided that you also regard it as material for 3.8-stable.
Thanks,
Rafael
> >>>> ---
> >>>>
> >>>> v3 : Continue to memory hot remove when (!info->enabled) case.
> >>>> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
> >>>>
> >>>> ---
> >>>> drivers/acpi/acpi_memhotplug.c | 15 ++-------------
> >>>> 1 files changed, 2 insertions(+), 13 deletions(-)
> >>>>
> >>>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> >>>> index ea78988..5e6301e 100644
> >>>> --- a/drivers/acpi/acpi_memhotplug.c
> >>>> +++ b/drivers/acpi/acpi_memhotplug.c
> >>>> @@ -73,7 +73,6 @@ struct acpi_memory_info {
> >>>> unsigned short caching; /* memory cache attribute */
> >>>> unsigned short write_protect; /* memory read/write attribute */
> >>>> unsigned int enabled:1;
> >>>> - unsigned int failed:1;
> >>>> };
> >>>>
> >>>> struct acpi_memory_device {
> >>>> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
> >>>> * returns -EEXIST. If add_memory() returns the other error, it
> >>>> * means that this memory block is not used by the kernel.
> >>>> */
> >>>> - if (result && result != -EEXIST) {
> >>>> - info->failed = 1;
> >>>> + if (result && result != -EEXIST)
> >>>> continue;
> >>>> - }
> >>>>
> >>>> info->enabled = 1;
> >>>>
> >>>> @@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
> >>>> nid = acpi_get_node(mem_device->device->handle);
> >>>>
> >>>> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
> >>>> - if (info->failed)
> >>>> - /* The kernel does not use this memory block */
> >>>> - continue;
> >>>> -
> >>>> if (!info->enabled)
> >>>> - /*
> >>>> - * The kernel uses this memory block, but it may be not
> >>>> - * managed by us.
> >>>> - */
> >>>> - return -EBUSY;
> >>>> + continue;
> >>>>
> >>>> if (nid < 0)
> >>>> nid = memory_add_physaddr_to_nid(info->start_addr);
> >>>>
> >>>
> >>>
> >>
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-04-01 23:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 6:54 [Bug fix PATCH] ACPI,acpi_memhotplug: enable acpi_memory_info->enabled of memory device presented at boot-time Yasuaki Ishimatsu
2013-03-13 14:50 ` Toshi Kani
2013-03-18 2:19 ` [PATCH] Remove acpi_memory_info->failed bit Yasuaki Ishimatsu
2013-03-19 15:03 ` Toshi Kani
2013-03-20 23:57 ` Yasuaki Ishimatsu
2013-03-21 4:36 ` [Bug fix PATCH v2 1/2] ACPI,acpi_memhotplug: enable acpi_memory_info->enabled of memory device presented at boot-time Yasuaki Ishimatsu
2013-03-21 4:39 ` [PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit Yasuaki Ishimatsu
2013-03-21 4:45 ` Yasuaki Ishimatsu
2013-03-22 0:29 ` Toshi Kani
2013-03-22 1:35 ` Yasuaki Ishimatsu
2013-03-22 1:53 ` [PATCH v3 " Yasuaki Ishimatsu
2013-03-22 20:24 ` Toshi Kani
2013-03-25 23:57 ` Yasuaki Ishimatsu
2013-03-26 13:41 ` Rafael J. Wysocki
2013-03-27 23:58 ` Yasuaki Ishimatsu
2013-04-01 23:48 ` Rafael J. Wysocki [this message]
2013-04-02 0:12 ` Yasuaki Ishimatsu
2013-04-02 12:57 ` Rafael J. Wysocki
2013-04-02 23:55 ` Yasuaki Ishimatsu
2013-03-21 4:44 ` [Bug fix PATCH v2 1/2] ACPI,acpi_memhotplug: enable acpi_memory_info->enabled of memory device presented at boot-time Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7171436.IWIKuTHVjL@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangchen@cn.fujitsu.com \
--cc=toshi.kani@hp.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®