From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAE282DB7BE for ; Sat, 11 Jul 2026 05:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783748808; cv=none; b=qt4jPd51Y1mCnHkR8GqWucmWLiR7lqjNePMYCWRBsGn1dByFSwD/6j8m4h2nozOF6O2iIBb5FjSM+35a/rHq3e55uGGPFrK9ZfoyEv7/IiT+1623ArsXXJN6AWicuDeb/jP8TVRng9PF3242WTRK38Kx/4SMGF2iepULyGXf7So= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783748808; c=relaxed/simple; bh=KdwWMKt9xEN3xDtoDCATPMzZIWVY48mme+8NbD8tZCQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AjtQ/K4HsyikIY597DV/oMgfH20MeWl1jSluhEVq+ZwQGXBZV82A0aU/Vl6EdkKwPFydP6wRE/97w92sytugKCGoIy/lhxHxkcpmVfba1E6chvDBq4Ght/hY1IzFaQ4LpAaz1Ak73MFVos2h/9E+CjLlsZsxNdROwcF7flbD8+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lKdLSv3u; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MtycTzj2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lKdLSv3u"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MtycTzj2" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66B54lEt2808350 for ; Sat, 11 Jul 2026 05:46:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gevgTNUs9RHgkaUGheSyiQ8zKdBVGGi1fUkWXs8Qot0=; b=lKdLSv3ufnyHePk8 t9OJTg5Utyn+lWFHsXShB2UmSqXPgXtY+jwBr43owVpAxTiDjxXY6H/pTAKFTwQ4 7NlZIlP5+wpiNecH3NkFD+nxiAQLv0T5j/ZqVmY2t+PXGCpkubkxjEeYHoMRBXJC OHk7Ele1xaAGjvpiBAeHsPvy8QnlkvgEoAGjJR6mbmfb0SjxXKBkeQygXybzwcEM 2xMFRSlQkF+y4fsP6zPXqiqi3nJBrgmkKsROISmnlQrCtRXQLAfhA7uIWVCOwpWH 5GG7Tt2FCTKIVh8tW3vyU31r1cKZ7xSLXVz7awBvY+tBITj3tS+1Aso+3wmrT7GI EjAYvw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbf48032k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 11 Jul 2026 05:46:45 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c075c1e25so13080991cf.3 for ; Fri, 10 Jul 2026 22:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783748805; x=1784353605; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gevgTNUs9RHgkaUGheSyiQ8zKdBVGGi1fUkWXs8Qot0=; b=MtycTzj2J+UuPZ3Isrzz2FSwzudfXRtx9HkeWkgaKfn10NfT38Bs0exrIOuTQbgSwi QCKmJIv7UQwPtoDHT7F6cltEslrJTswXNxpaPcDEMIg93f5e0EVwrX30xSWEHcZpPR+s exXJYOeoy3BOapf7I6XmdKvqRj6BBDHh7W77TB2eH8GZkx9RCxHljn26r/q36/czHDDR KKjGqX0+w72f6UMyALnscatMgHnQldTTDE5GY0bu0KpdO+RSFl6ggdlJkc+EH9Ys9pZO snEGOH7Ggaw/qvU4K5/AfMKDPA5Djp5/0kX/Fby8IJ/Aih5XSpvOqdgnSahiB1ZxQNOz 87hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783748805; x=1784353605; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gevgTNUs9RHgkaUGheSyiQ8zKdBVGGi1fUkWXs8Qot0=; b=bYtuUPwShbXN+Pxwypmj+vN0FVnlHeswAxFb14uDVhJq3Dz0JuStO7poQzJftyOEu8 oN4kumLfpc0gLI966PLjJrmrn4q+G1s4FLl78KdU2V5Rz/GNh6Lbh/EuD5Fg1tw2IXO0 v5wzQ4CZiiW9/S26Qf2hXnhtnGc3e7+JiH45D3L9EtNwXqkxZm1yrZfLe/wZCOst36pu oWa+leGzHrO7zXt04h5BFc2rikivAjFz61RtA+ghwck5nnVNvKlfjGO0hOG+4B2nIe/i MTSH4B++1r5md5e9+8h7fp4DGLalxTsZJ5Ba3kyVuITGqu5RFiUeOcw9uw2mqw+QKW9R zpEQ== X-Forwarded-Encrypted: i=1; AHgh+RoEHladexGDif1BKRDvs/5AaoeZ6K+iIuZgjPXrDiyZNHHoGzZ7sRBPUmvgDi63DoriTWFt5yUXeezpMAo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+oeiXiKp26mDAbzrSZWDA1chJshV3e2wFCSDQkJF9Bl0HEyUW 5j9282hmelvNxPTmnT/OjJMr6K5eSl/KB69OR2OcFJxXxDKieXz7uEJZa9mo7wVEPpCm75Sy2JZ YGcQ8kU2qc7Kj/s4NZhH9MFKY7IYkukWLx3FuvpJG7QYPoolty+rnusiuOXdruoj9RZI= X-Gm-Gg: AfdE7clV596SSM0nkaWZIgaAh45G+LuTMwdO/xc9vHKTj//LCLK5KoV//u3fk05PJyX WcILj1/NWox3W1BVcV5PELcEWFjedZsMIwjycIrSV20xSYnh+fdg/0FFA6/+6+z/Zc9Wo47Bs6R tWrKgEReN2LvIJ7LO5E8Cg7vg+Wgv53pmj4nGwyG0kO8kCeh4V28i9zgvGWW1kSmZ1re5H+dkQP F5buKkFCu/GPcWbn+o7HMysbyUBjMSxuPThcUVfWfiBXMzZ25wfh8BVa2vL3PazLRHq7BBmaBFJ vzf9X5441Nb356LoiVvq10pTpEAzaixJEIAJ2QrrvGcGwZCQIH8jvHixd1UC7vE7zbZQ4pFYmmB hd2Ie7whu0Lj95zOF0nEQ5cC4fOVRG18ltNbe61UpXPu1 X-Received: by 2002:a05:622a:2616:b0:517:9095:c329 with SMTP id d75a77b69052e-51cbf1fef01mr18790551cf.45.1783748804653; Fri, 10 Jul 2026 22:46:44 -0700 (PDT) X-Received: by 2002:a05:622a:2616:b0:517:9095:c329 with SMTP id d75a77b69052e-51cbf1fef01mr18790251cf.45.1783748804101; Fri, 10 Jul 2026 22:46:44 -0700 (PDT) Received: from [192.168.0.172] ([49.205.248.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15d81bbceesm457348966b.41.2026.07.10.22.46.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 22:46:41 -0700 (PDT) Message-ID: <71733afc-732e-47f9-8497-b09600f93612@oss.qualcomm.com> Date: Sat, 11 Jul 2026 11:16:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 01/11] dt-bindings: media: qcom,sm8550-iris: Add vpu sub nodes To: Dmitry Baryshkov Cc: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy References: <20260709-vpu_iommu_iova_handling-v1-0-72bb62cb2dfd@oss.qualcomm.com> <20260709-vpu_iommu_iova_handling-v1-1-72bb62cb2dfd@oss.qualcomm.com> <201e8354-fc34-4d2a-89d5-8661a3a66133@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzExMDA1MSBTYWx0ZWRfX3IQFLxaQXndV xx/rUf1h/gs1d8jp04SfJ7M387UobElqaqppHD920ccgZlI6aDSVS9p9bqRbvr39Sjf6veYlD+V iD7jZxn39TvrcRGtCIZv5G4wqlgo/gQ= X-Authority-Analysis: v=2.4 cv=OsJ/DS/t c=1 sm=1 tr=0 ts=6a51d8c5 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=wRxn6a4LM5KCmfMgYXCo/g==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=e5mUnYsNAAAA:8 a=EUspDBNiAAAA:8 a=2_L87j3xYGeytyR3NxoA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=Vxmtnl_E_bksehYqCbjh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzExMDA1MSBTYWx0ZWRfXx7e/kGCR+Sm/ 0oP5tlBHptnbLDm/YrhPuKLiSVd+7UW1ZjMHaGjiKoWNiIjf7xc0t2Ht2cJf5FJ8XAel1BNiEsn cnaEmRJkL+mhZeRA48p8fFbZLuRFp7iWW0zRSxJ0CtW6BLuJpMNt1nzuOY24KIepTxULfnXfYVM rOSFI/HREoI8EhB7Aby5WzacM7N78rAdhty7emtBTPrgGySVT/2AOAIpl8dd1arAmvkHuWY6DB/ mqimZbw7vevpFhZ/3YdUEUTH/aqytId5Alv0g10p37TxV1kWoz0PR8DuMk/Sm1YamNY/+N2ypPv 8lEMFhRu5IjKNHsfko/oJUj6PMEptLW42L1fc52IhioYny/vFB81SkfrYMzUDe3e0dEigjIKpPH szX82QqIBaMxKFCHYS4LnYQfO/7zNkx6Aksq+AVAixyJ8B10wNr4UT0VyjYCts8W9NDlpx0pc3I sVFsmm9/7dzgOlV5sXA== X-Proofpoint-GUID: YGnmhcZtQzAknCZkMKYKEVknj5bnGxdg X-Proofpoint-ORIG-GUID: YGnmhcZtQzAknCZkMKYKEVknj5bnGxdg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-11_01,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 clxscore=1015 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607110051 On 7/10/2026 9:23 PM, Dmitry Baryshkov wrote: > On Fri, Jul 10, 2026 at 11:32:20AM +0530, Vikash Garodia wrote: >> >> On 7/9/2026 6:20 PM, Dmitry Baryshkov wrote: >>> On Thu, Jul 09, 2026 at 06:05:47PM +0530, Vikash Garodia wrote: >>>> VPU hardwares have a limitation where VPU streams are associated with >>>> dedicated addressable address range, as illustrated below >>>> >>>> +-----------------------------------------------------------+ >>>> | Stream A reserved region (600 MB) | >>>> | 0x00000000 - 0x25800000 | >>>> +-----------------------------------------------------------+ >>>> | Stream B reserved region (3.5 GB) | >>>> | 0x00000000 - 0xe0000000 | >>>> +-----------------------------------------------------------+ >>>> | Other reserved regions | >>>> +-----------------------------------------------------------+ >>>> >>>> Mapping a stream outside its expected range can cause unintended >>>> behavior, including device crashes, as reported at: >>>> https://gitlab.freedesktop.org/drm/msm/-/work_items/100 >>>> >>>> To address this limitation, the subset of stream/s are now represented as >>>> sub nodes, so that they can be associated to the respective addressable >>>> range. >>>> The limitation could be exposed when running usecase like concurrent >>>> video sessions. The binding have been validated with higher concurrent >>>> sessions across the SOCs supported under this schema. >>>> >>>> Co-developed-by: Vishnu Reddy >>>> Signed-off-by: Vishnu Reddy >>>> Signed-off-by: Vikash Garodia >>>> --- >>>> .../bindings/media/qcom,sm8550-iris.yaml | 66 +++++++++++++++++++++- >>>> 1 file changed, 63 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >>>> index 0400ca1bff05dcef6b742c3fbf77e38adca9f280..bf4d24ce90bd38666704274390b98be450f708c0 100644 >>>> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >>>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >>>> @@ -91,6 +91,51 @@ properties: >>>> opp-table: >>>> type: object >>>> + '#address-cells': >>>> + const: 2 >>>> + >>>> + '#size-cells': >>>> + const: 2 >>>> + >>>> + non-pixel: >>>> + type: object >>>> + description: >>>> + Non pixel context bank is needed when video hardware have distinct iommus for non pixel >>>> + buffers. Non pixel buffers are compressed and internal buffers. >>>> + properties: >>>> + iommus: >>>> + maxItems: 1 >>>> + memory-region: >>>> + maxItems: 1 >>>> + required: >>>> + - iommus >>>> + - memory-region >>>> + additionalProperties: false >>>> + >>>> + pixel: >>>> + type: object >>>> + description: >>>> + Pixel context bank is needed when video hardware have distinct iommus for pixel buffers. >>>> + Pixel buffers are uncompressed buffers. >>>> + properties: >>>> + iommus: >>>> + maxItems: 1 >>>> + required: >>>> + - iommus >>>> + additionalProperties: false >>>> + >>>> + firmware: >>>> + type: object >>>> + description: >>>> + Firmware context bank represents the firmware processing domain of the VPU. Required to boot >>>> + VPU when no hypervisor is present. >>>> + properties: >>>> + iommus: >>>> + maxItems: 1 >>>> + required: >>>> + - iommus >>>> + additionalProperties: false >>>> + >>>> required: >>>> - compatible >>>> - power-domain-names >>>> @@ -98,9 +143,15 @@ required: >>>> - interconnect-names >>>> - resets >>>> - reset-names >>>> - - iommus >>>> - dma-coherent >>>> +oneOf: >>>> + - required: >>>> + - iommus >>>> + - required: >>>> + - non-pixel >>>> + - pixel >>>> + >>>> allOf: >>>> - if: >>>> properties: >>>> @@ -177,12 +228,21 @@ examples: >>>> resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>; >>>> reset-names = "bus"; >>>> - iommus = <&apps_smmu 0x1940 0x0000>, >>>> - <&apps_smmu 0x1947 0x0000>; >>>> dma-coherent; >>>> operating-points-v2 = <&iris_opp_table>; >>>> + #address-cells = <2>; >>>> + #size-cells = <2>; >>> >>> I think you need "ranges;" here. Also an empty line before the subnodes. >> >> Could you please elaborate on what would be the use of "ranges;" in this >> case ? > > That the subblock has the same address space as the parent. I might be > completely wrong here. Yes, i explored with the same definition of "ranges", but could not see a use of it in our case. I am dropping this for now, unless there are suggestion on this on applicability of it in this case. > >> >>> >>>> + iris_non_pixel: non-pixel { >>> >>> Drop useless labels. >> >> Ack, labels can be dropped from schema. >> >>> >>>> + iommus = <&apps_smmu 0x1940 0x0000>; >>>> + memory-region = <&iris_resv>; >>>> + }; >>>> + >>>> + iris_pixel: pixel { >>>> + iommus = <&apps_smmu 0x1947 0x0000>; >>>> + }; >>>> + >>>> iris_opp_table: opp-table { >>>> compatible = "operating-points-v2"; >>>> >>>> -- >>>> 2.34.1 >>>> >>> >> >> Regards, >> Vikash >> >