From: Johannes Berg <johannes@sipsolutions.net>
To: Deepakkumar Karn <dkarn@redhat.com>
Cc: Shaul Triebitz <shaul.triebitz@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+5bb5f06f99924ea0cf86@syzkaller.appspotmail.com
Subject: Re: [PATCH] mac80211_hwsim: fix divide error in mac80211_hwsim_link_info_changed
Date: Fri, 05 Dec 2025 18:39:49 +0100 [thread overview]
Message-ID: <717b98574a9037a5e81c929f97cc1258e00ee2f7.camel@sipsolutions.net> (raw)
In-Reply-To: <20251205153502.273426-1-dkarn@redhat.com>
On Fri, 2025-12-05 at 21:05 +0530, Deepakkumar Karn wrote:
> Prevent a division by zero crash when userspace provides a zero beacon
> interval value. The crash occurs in the beacon timer setup code path when
> info->beacon_int is 0, causing bcn_int to be 0 and triggering a divide
> error in the do_div() macro.The issue can be triggered from userspace via
> nl80211/cfg80211 when configuring a virtual interface in AP mode with an
> invalid beacon interval.
Seems like we should not let userspace do that, to protect all other
drivers too, not just hwsim.
johannes
next prev parent reply other threads:[~2025-12-05 17:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 15:35 Deepakkumar Karn
2025-12-05 17:39 ` Johannes Berg [this message]
2025-12-05 23:03 ` Deepakkumar Karn
2025-12-06 14:56 ` Johannes Berg
2025-12-06 17:33 ` Deepakkumar Karn
2025-12-08 8:29 ` Johannes Berg
2025-12-10 18:56 ` Deepak Karn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=717b98574a9037a5e81c929f97cc1258e00ee2f7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dkarn@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=shaul.triebitz@intel.com \
--cc=syzbot+5bb5f06f99924ea0cf86@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®