From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D87C4338F for ; Wed, 4 Aug 2021 09:06:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C0F660E52 for ; Wed, 4 Aug 2021 09:06:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236862AbhHDJGW (ORCPT ); Wed, 4 Aug 2021 05:06:22 -0400 Received: from mga12.intel.com ([192.55.52.136]:36588 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235488AbhHDJGV (ORCPT ); Wed, 4 Aug 2021 05:06:21 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10065"; a="193475844" X-IronPort-AV: E=Sophos;i="5.84,293,1620716400"; d="scan'208";a="193475844" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2021 02:06:09 -0700 X-IronPort-AV: E=Sophos;i="5.84,293,1620716400"; d="scan'208";a="521763590" Received: from rongch2-mobl.ccr.corp.intel.com (HELO [10.255.30.199]) ([10.255.30.199]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2021 02:06:07 -0700 Subject: Re: [kbuild-all] Re: include/linux/atomic-arch-fallback.h:60:32: error: implicit declaration of function 'arch_cmpxchg64'; did you mean 'arch_cmpxchg'? To: Mark Rutland , kernel test robot Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Peter Zijlstra References: <202107110643.63fELxVr-lkp@intel.com> <20210712143151.GB94622@C02TD0UTHF1T.local> From: "Chen, Rong A" Message-ID: <717d9f89-078b-1698-46fb-9b3393ecddc4@intel.com> Date: Wed, 4 Aug 2021 17:06:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210712143151.GB94622@C02TD0UTHF1T.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/12/2021 10:31 PM, Mark Rutland wrote: > On Sun, Jul 11, 2021 at 06:44:47AM +0800, kernel test robot wrote: >> Hi Mark, >> >> FYI, the error/warning still remains. > > I thought we'd already identified that this was an existing bug, and all that > has changed is the specific error that manifests. Hi Mark, Thanks for the feedback, We won't report the error again. Best Regards, Rong Chen > > In v5.13 this would fail with: > > | CC drivers/iommu/io-pgtable-arm.o > | In file included from ./include/linux/atomic.h:84, > | from drivers/iommu/io-pgtable-arm.c:12: > | drivers/iommu/io-pgtable-arm.c: In function 'arm_lpae_install_table': > | ./include/linux/atomic-fallback.h:60:27: error: implicit declaration of function 'cmpxchg64'; did you mean 'cmpxchg'? [-Werror=implicit-function-declaration] > | 60 | #define cmpxchg64_relaxed cmpxchg64 > | | ^~~~~~~~~ > | drivers/iommu/io-pgtable-arm.c:320:8: note: in expansion of macro 'cmpxchg64_relaxed' > | 320 | old = cmpxchg64_relaxed(ptep, curr, new); > | | ^~~~~~~~~~~~~~~~~ > > ... which has the same underlying problem -- the architecture has not provided > a cmpxchg64() implementation, but the IO pagetable code depends upon > cmpxchg64(). > > Thanks, > Mark. > >> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >> head: 1e16624d7b4376797ede36e3c955375cf0f23298 >> commit: bccf1ec369ac126b0997d01a6e1deae00e2cf6b3 locking/atomics: atomic-instrumented: simplify ifdeffery >> date: 6 weeks ago >> config: arc-allyesconfig (attached as .config) >> compiler: arceb-elf-gcc (GCC) 9.3.0 >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bccf1ec369ac126b0997d01a6e1deae00e2cf6b3 >> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> git fetch --no-tags linus master >> git checkout bccf1ec369ac126b0997d01a6e1deae00e2cf6b3 >> # save the attached .config to linux build tree >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All errors (new ones prefixed by >>): >> >> In file included from include/linux/atomic.h:80, >> from drivers/iommu/io-pgtable-arm.c:12: >> drivers/iommu/io-pgtable-arm.c: In function 'arm_lpae_install_table': >>>> include/linux/atomic-arch-fallback.h:60:32: error: implicit declaration of function 'arch_cmpxchg64'; did you mean 'arch_cmpxchg'? [-Werror=implicit-function-declaration] >> 60 | #define arch_cmpxchg64_relaxed arch_cmpxchg64 >> | ^~~~~~~~~~~~~~ >> include/asm-generic/atomic-instrumented.h:1261:2: note: in expansion of macro 'arch_cmpxchg64_relaxed' >> 1261 | arch_cmpxchg64_relaxed(__ai_ptr, __VA_ARGS__); \ >> | ^~~~~~~~~~~~~~~~~~~~~~ >> drivers/iommu/io-pgtable-arm.c:320:8: note: in expansion of macro 'cmpxchg64_relaxed' >> 320 | old = cmpxchg64_relaxed(ptep, curr, new); >> | ^~~~~~~~~~~~~~~~~ >> cc1: some warnings being treated as errors >> >> >> vim +60 include/linux/atomic-arch-fallback.h >> >> 37f8173dd84936 Peter Zijlstra 2020-01-24 56 >> 37f8173dd84936 Peter Zijlstra 2020-01-24 57 #ifndef arch_cmpxchg64_relaxed >> 37f8173dd84936 Peter Zijlstra 2020-01-24 58 #define arch_cmpxchg64_acquire arch_cmpxchg64 >> 37f8173dd84936 Peter Zijlstra 2020-01-24 59 #define arch_cmpxchg64_release arch_cmpxchg64 >> 29f006fdefe6f8 Peter Zijlstra 2020-08-29 @60 #define arch_cmpxchg64_relaxed arch_cmpxchg64 >> 37f8173dd84936 Peter Zijlstra 2020-01-24 61 #else /* arch_cmpxchg64_relaxed */ >> 37f8173dd84936 Peter Zijlstra 2020-01-24 62 >> >> :::::: The code at line 60 was first introduced by commit >> :::::: 29f006fdefe6f88abde973a0b0f20d2704e93fd4 asm-generic/atomic: Add try_cmpxchg() fallbacks >> >> :::::: TO: Peter Zijlstra >> :::::: CC: Ingo Molnar >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org >