From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Mike Snitzer <snitzer@kernel.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org, Matthew Sakai <msakai@redhat.com>
Subject: drivers/md/dm-vdo/data-vio.c:976 vdo_launch_bio() warn: inconsistent returns '&pool->lock'.
Date: Mon, 21 Oct 2024 10:19:31 +0300 [thread overview]
Message-ID: <717e8949-55c4-4461-8951-3e582e9b77ef@stanley.mountain> (raw)
Hi Mike,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3d5ad2d4eca337e80f38df77de89614aa5aaceb9
commit: f36b1d3ba533d21b5b793623f05761b0297d114e dm vdo: use a proper Makefile for dm-vdo
config: x86_64-randconfig-161-20241019 (https://download.01.org/0day-ci/archive/20241019/202410191209.osrd8z9H-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202410191209.osrd8z9H-lkp@intel.com/
smatch warnings:
drivers/md/dm-vdo/data-vio.c:976 vdo_launch_bio() warn: inconsistent returns '&pool->lock'.
vim +976 drivers/md/dm-vdo/data-vio.c
79535a7881c0cb Matthew Sakai 2023-11-16 958 void vdo_launch_bio(struct data_vio_pool *pool, struct bio *bio)
79535a7881c0cb Matthew Sakai 2023-11-16 959 {
79535a7881c0cb Matthew Sakai 2023-11-16 960 struct data_vio *data_vio;
79535a7881c0cb Matthew Sakai 2023-11-16 961
79535a7881c0cb Matthew Sakai 2023-11-16 962 ASSERT_LOG_ONLY(!vdo_is_state_quiescent(&pool->state),
79535a7881c0cb Matthew Sakai 2023-11-16 963 "data_vio_pool not quiescent on acquire");
79535a7881c0cb Matthew Sakai 2023-11-16 964
79535a7881c0cb Matthew Sakai 2023-11-16 965 bio->bi_private = (void *) jiffies;
79535a7881c0cb Matthew Sakai 2023-11-16 966 spin_lock(&pool->lock);
79535a7881c0cb Matthew Sakai 2023-11-16 967 if ((bio_op(bio) == REQ_OP_DISCARD) &&
79535a7881c0cb Matthew Sakai 2023-11-16 968 !acquire_permit(&pool->discard_limiter, bio))
79535a7881c0cb Matthew Sakai 2023-11-16 969 return;
^^^^^^
79535a7881c0cb Matthew Sakai 2023-11-16 970
79535a7881c0cb Matthew Sakai 2023-11-16 971 if (!acquire_permit(&pool->limiter, bio))
79535a7881c0cb Matthew Sakai 2023-11-16 972 return;
^^^^^^
Still holding pool->lock on these paths.
79535a7881c0cb Matthew Sakai 2023-11-16 973
79535a7881c0cb Matthew Sakai 2023-11-16 974 data_vio = get_available_data_vio(pool);
79535a7881c0cb Matthew Sakai 2023-11-16 975 spin_unlock(&pool->lock);
79535a7881c0cb Matthew Sakai 2023-11-16 @976 launch_bio(pool->completion.vdo, data_vio, bio);
79535a7881c0cb Matthew Sakai 2023-11-16 977 }
79535a7881c0cb Matthew Sakai 2023-11-16 978
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-10-21 7:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 7:19 Dan Carpenter [this message]
2024-10-28 23:00 ` Matthew Sakai
2024-10-29 3:03 ` Philip Li
2024-10-29 7:15 ` Philip Li
2024-10-29 8:07 ` Dan Carpenter
2024-10-29 8:12 ` Dan Carpenter
2024-10-29 8:19 ` Dan Carpenter
2024-10-29 17:03 ` Matthew Sakai
2024-10-29 19:49 ` Dan Carpenter
2024-10-29 7:38 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=717e8949-55c4-4461-8951-3e582e9b77ef@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=msakai@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®