From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8F3426E701 for ; Mon, 13 Oct 2025 13:07:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760360842; cv=none; b=nnqoqec6LO9LM42AvuCrypzkqLFa1HS3nip1DCLXVJhACVavfieGqEiB5TxX+yWjSwPqoF8l2g2417SrcbZLeOmO8B0z41AOLnoHc+lBfx9lQz7w/NWe36sFPRZ4nroFBsVwgkRTlH/2dLrgcNDGD0+zWwEvsTHaCErX8q6dl+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760360842; c=relaxed/simple; bh=pPObb5pBdsRGPG8Grs/uUoENsrXsjRgx2vyD8QUzvr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FPVYcmvUBjJRPC+LtMoCd4FL+qzelbw+F49Th78M/s4Ph38Ntk6fkRQ+iESTayCsEd6f+wArjLxMROSkMpcYorm5Ibnl3aqMqJE4hE59N09NhuvGLEUBye44DoMv7dYjaF9JFL5tOi/GTtZSHpnwdJkT1kDb6fZ6+2j2soZzg6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=WxSHAw4I; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=rWFoi5F2; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=HaLN6Qo9; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=9sAjJpKY; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="WxSHAw4I"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="rWFoi5F2"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="HaLN6Qo9"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="9sAjJpKY" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D7649219A7; Mon, 13 Oct 2025 13:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1760360839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=E3CnuRpErbgZ0qQjMayTZw+D5tyXqR2/i+elJ1QiCcg=; b=WxSHAw4IMFUn7RLE+0EdtM9sipT0TUIxYsQyP5uz53WvLjsoEZj6Ww0Nqk1rDjaJ/96gSv I8+UWL2fVrMsqfMmGnAg+Q7GO75F6SFChwIGrX2NMjjvjN94Awrjflq1h7ZjxixlPnZwQJ J1r5DxJPeqpD4DrkGgQCauYuQ/uk9GQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1760360839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=E3CnuRpErbgZ0qQjMayTZw+D5tyXqR2/i+elJ1QiCcg=; b=rWFoi5F2xi8+vhJ0Pn83W+YKOGfOpipbLwAmGBOky1uY+O5EKhSryQkguzE/ipdSfApR9U yjkd0JCjeNzKK1CA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1760360838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=E3CnuRpErbgZ0qQjMayTZw+D5tyXqR2/i+elJ1QiCcg=; b=HaLN6Qo9bnVAG0mENAom18/5bu7/rEo8RaEuoaCvS6oa40IU9UHmnzogATaknE4j2rnnU5 NpRof9hmAWxibTKVn1RPb3irg7bLhzO8t+IwPOan3uCQ9LefRXWh7pZB643F5GqZdCnSHG 4WGWM2kKLaQOXiQVNJzDEpj1KRFo9EM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1760360838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=E3CnuRpErbgZ0qQjMayTZw+D5tyXqR2/i+elJ1QiCcg=; b=9sAjJpKYn6yzEh84RG9SAxBlyXHF3iNOHS/Oe4RiDRCSlmBJ1HaVeUSq4fmHF+1vtPNxlt X2q1L7YEZ+AvYNAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C28FD1374A; Mon, 13 Oct 2025 13:07:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aNYuL4b57GhTRwAAD6G6ig (envelope-from ); Mon, 13 Oct 2025 13:07:18 +0000 Message-ID: <71803dce-3fa6-494c-a4b1-55d98fc4aadb@suse.cz> Date: Mon, 13 Oct 2025 15:07:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC RFC PATCH] mm: convert VM flags from macros to enum Content-Language: en-US To: Lorenzo Stoakes , David Hildenbrand Cc: Ye Liu , Andrew Morton , Ye Liu , "Liam R. Howlett" , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20251011093054.886460-1-ye.liu@linux.dev> <809f552d-3282-4746-ba49-066d2bd8d44f@lucifer.local> <7ca0960f-9d1a-4ba4-b074-a6502578b82e@redhat.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[11]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:mid,imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO X-Spam-Score: -4.30 X-Spam-Level: On 10/13/25 14:57, Lorenzo Stoakes wrote: > On Mon, Oct 13, 2025 at 02:31:35PM +0200, David Hildenbrand wrote: >> On 13.10.25 13:33, Lorenzo Stoakes wrote: >> > On Mon, Oct 13, 2025 at 01:12:20PM +0200, David Hildenbrand wrote: >> > > On 13.10.25 13:04, Lorenzo Stoakes wrote: >> > > > On Sat, Oct 11, 2025 at 05:30:52PM +0800, Ye Liu wrote: >> > > > > From: Ye Liu >> > > > > >> > > > > Hello MM maintainers and drgn community, >> > > > > >> > > > > This RFC proposes to convert VM_* flags from #define macros to enum >> > > > > vm_flags. The motivation comes from recent drgn development where we >> > > > > encountered difficulties in implementing VM flag parsing due to the >> > > > > current macro-based approach. >> > > > >> > > > This isn't going to work sorry, it's not valid to have flag values as an enum >> > > >> > > I don't follow, can you elaborate? IIRC, the compiler will use an integer >> > > type to back the enum that will fit all values. >> > >> > switch (flags) { >> > case VAL1: >> > case VAL2: >> > etc. >> > } >> > >> > Is broken (compiler will say you cover all cases when you don't...) >> >> I assume you mean theoretically, because there is no such code, right? > > Right, it's a general point about why enum's are not such a great idea for this. > >> >> > >> > An enum implies independent values that exhaustively describe all state, however >> > these flag values are not that - they're intended to be bit fields. >> > >> >> Observe how we use an enum for FOLL_* flags, vm_fault_reason, fault_flag and >> probably other things. > > FOLL_* flags are an anonymous enum, enum fault_flag is not used as a type > anywhere, nor is vm_fault_reason. So those are both kinda weird as to why we > even name the type (they're in effect anonymous). > > But also 'we do X in the kernel' doesn't mean doing X is right :) I think the example to follow could be GFP flags. Nowadays there's an enum below it, and a layer that adds (__force gfp_t), so you could do similar thing with vm_flags_t. However I'm not sure how compatible is that with Lorenzo's plans.