From: Joe Perches <joe@perches.com>
To: Rene Rebe <rene@exactcode.com>, linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, himanshu.madhani@oracle.com
Subject: Re: [PATCH v2] use cpu_to_le{16,32} instead of __constant_cpu_to_*
Date: Wed, 02 Sep 2020 18:58:59 -0700 [thread overview]
Message-ID: <71837114676678d44500f146a2d98bbe9e541c65.camel@perches.com> (raw)
In-Reply-To: <20200902.232949.1343752343092794969.rene@exactcode.com>
On Wed, 2020-09-02 at 23:29 +0200, Rene Rebe wrote:
> As per recommendation, convert a few remaining __constant_cpu_to_le{16,32}
> instances in the qla2xxx, qla4xxx and cifs to just cpu_to_le{16,32}.
[]
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
[]
> @@ -3583,7 +3583,7 @@ static int __qlt_send_term_imm_notif(struct scsi_qla_host *vha,
>
> /* terminate */
> nack->u.isp24.flags |=
> - __constant_cpu_to_le16(NOTIFY_ACK_FLAGS_TERMINATE);
> + cpu_to_le16(NOTIFY_ACK_FLAGS_TERMINATE);
trivia: this now fits on a single line.
next prev parent reply other threads:[~2020-09-03 1:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b7719680-e451-5687-1fb7-c8c059a880d4@acm.org>
[not found] ` <2C755628-1426-4BA4-B2A3-AD059BB0F605@exactcode.com>
[not found] ` <c7daea00-410d-2073-bf52-2abda9acdf8e@acm.org>
2020-08-27 21:01 ` [PATCH] use cpu_to_le{16,32} instead of __constant_cpu_to_ Rene Rebe
2020-08-27 21:59 ` Himanshu Madhani
2020-09-02 20:40 ` Arnd Bergmann
2020-09-02 21:29 ` [PATCH v2] use cpu_to_le{16,32} instead of __constant_cpu_to_* Rene Rebe
2020-09-03 1:58 ` Joe Perches [this message]
2020-09-04 17:24 ` [PATCH v3] " Rene Rebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71837114676678d44500f146a2d98bbe9e541c65.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=himanshu.madhani@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rene@exactcode.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®