mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
	linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Markus Pargmann <mpa@pengutronix.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Lee Jones <lee.jones@linaro.org>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Denis Carikli <denis@eukrea.com>
Subject: Re: [PATCH] iio: adc: imx25-gcq: Fix module autoload
Date: Sat, 7 Jan 2017 22:15:34 +0000	[thread overview]
Message-ID: <7184b366-f628-0c21-c459-c53e32fd4946@kernel.org> (raw)
In-Reply-To: <1483361146-913-1-git-send-email-javier@osg.samsung.com>

On 02/01/17 12:45, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/iio/adc/fsl-imx25-gcq.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/iio/adc/fsl-imx25-gcq.ko | grep alias
> alias:          of:N*T*Cfsl,imx25-gcqC*
> alias:          of:N*T*Cfsl,imx25-gcq
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied to the togreg branch of iio.git. Will push out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> ---
> 
>  drivers/iio/adc/fsl-imx25-gcq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
> index 72b32c1ab257..ea264fa9e567 100644
> --- a/drivers/iio/adc/fsl-imx25-gcq.c
> +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> @@ -401,6 +401,7 @@ static const struct of_device_id mx25_gcq_ids[] = {
>  	{ .compatible = "fsl,imx25-gcq", },
>  	{ /* Sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, mx25_gcq_ids);
>  
>  static struct platform_driver mx25_gcq_driver = {
>  	.driver		= {
> 

      reply	other threads:[~2017-01-08 10:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 12:45 Javier Martinez Canillas
2017-01-07 22:15 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7184b366-f628-0c21-c459-c53e32fd4946@kernel.org \
    --to=jic23@kernel.org \
    --cc=arnd@arndb.de \
    --cc=denis@eukrea.com \
    --cc=javier@osg.samsung.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®