From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DFE4C43334 for ; Mon, 27 Jun 2022 10:52:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234356AbiF0Kwo (ORCPT ); Mon, 27 Jun 2022 06:52:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234327AbiF0Kwm (ORCPT ); Mon, 27 Jun 2022 06:52:42 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19682645D; Mon, 27 Jun 2022 03:52:37 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 53F8B6601695; Mon, 27 Jun 2022 11:52:35 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656327156; bh=31OkOrWw1DO+tikKFkTVP/vIL3n46LNH7u7zf1VVoas=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MRasHgN6imMVi+Ky842kdEK+bxObEBRRTatA44k84AXhPMGg05eYOWJbWgHD/TDqL kYNd6ix6N4opgw0Qiu/Y+hYouCkqO/sh+bJrTqRR+xvnqC7PVw/6aEx/+4rKhhjCM8 gq0bTq9MY68dEk9kPWKeVyQPICrSzu2BEv22hTp+sSnGVw7VyU75o6/kGfZvOpv/sf smoJJp1e2KaGhqmhGFpzr07/Tk8iFaIpEQSrirGm6RvWAeFtKmEXh39H79lbzxKcsV Gi0KkvYbOGxOaojJMhoY3W/BDntZs80zZDWEAs9avTiVjwbAAG7Wwd/Ei/d5OKR6ee sYrZl91FY0RZA== Message-ID: <718cdb35-1d87-3900-6de2-690964ff991b@collabora.com> Date: Mon, 27 Jun 2022 12:52:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v14 14/15] drm/mediatek: dpi: Add dp_intf support Content-Language: en-US To: Bo-Chen Chen , chunkuang.hu@kernel.org, p.zabel@pengutronix.de, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, airlied@linux.ie Cc: msp@baylibre.com, granquet@baylibre.com, jitao.shi@mediatek.com, wenst@chromium.org, ck.hu@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220624030946.14961-1-rex-bc.chen@mediatek.com> <20220624030946.14961-15-rex-bc.chen@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220624030946.14961-15-rex-bc.chen@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 24/06/22 05:09, Bo-Chen Chen ha scritto: > From: Guillaume Ranquet > > Dpintf is the displayport interface hardware unit. This unit is similar > to dpi and can reuse most of the code. > > This patch adds support for mt8195-dpintf to this dpi driver. Main > differences are: > - 4 pixels for one iteration for dp_intf while dpi is 1 pixel for one > iteration. Therefore, we add a new config "pixels_per_iter" to control > quantity of transferred pixels per iteration. > - Input of dp_intf is two pixels per iteration, so we add a new config > "input_2pixel" to control this. > - Some register contents differ slightly between the two components. To > work around this I added register bits/masks with a DPINTF_ prefix > and use them where different. > > Based on a separate driver for dpintf created by > Jitao shi . > > Signed-off-by: Markus Schneider-Pargmann > Signed-off-by: Guillaume Ranquet > [Bo-Chen: Modify reviewers' comments.] > Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno