From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: "Prakash, Prashanth" <pprakash@codeaurora.org>,
Hoan Tran <hotran@apm.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
lho@apm.com, Duc Dang <dhdang@apm.com>
Subject: Re: [PATCH v4] mailbox: PCC: Fix lockdep warning when request PCC channel
Date: Thu, 24 Nov 2016 02:28:57 +0100 [thread overview]
Message-ID: <7194620.HeEvFEaecv@vostro.rjw.lan> (raw)
In-Reply-To: <6cdda541-7db1-4970-9497-d75b9017e97f@codeaurora.org>
On Monday, November 14, 2016 01:50:02 PM Prakash, Prashanth wrote:
> Hi Hoan,
>
> On 11/14/2016 12:19 PM, Hoan Tran wrote:
> > This patch fixes the lockdep warning below
> >
> > [ 7.229767] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags))
> > [ 7.229776] ------------[ cut here ]------------
> > [ 7.229787] WARNING: CPU: 1 PID: 1 at linux-next/kernel/locking/lockdep.c:2876 loc
> > kdep_trace_alloc+0xe0/0xf0
> > [ 7.229790] Modules linked in:
> > [ 7.229793]
> > [ 7.229798] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.8.0-11756-g86c5152 #46
> > ...
> > [ 7.229900] Call trace:
> > [ 7.229903] Exception stack(0xffff8007da837890 to 0xffff8007da8379c0)
> > [ 7.229906] 7880: ffff8007da834000 0001000000000000
> > [ 7.229909] 78a0: ffff8007da837a70 ffff0000081111a0 00000000600000c5 000000000000003d
> > [ 7.229912] 78c0: 9374bc6a7f3c7832 0000000000381878 ffff000009db7ab8 000000000000002f
> > [ 7.229915] 78e0: ffff00000811aabc ffff000008be2548 ffff8007da837990 ffff00000811adf8
> > [ 7.229918] 7900: ffff8007da834000 00000000024080c0 00000000000000c0 ffff000009021000
> > [ 7.229921] 7920: 0000000000000000 0000000000000000 ffff000008c8f7c8 ffff8007da579810
> > [ 7.229923] 7940: 000000000000002f ffff8007da858000 0000000000000000 0000000000000001
> > [ 7.229926] 7960: 0000000000000001 0000000000000000 ffff00000811a468 0000000000000002
> > [ 7.229929] 7980: 656c62617369645f 0000000000038187 00000000000000ee ffff8007da837850
> > [ 7.229932] 79a0: ffff000009db50c0 ffff000009db569d 0000000000000006 ffff000089db568f
> > [ 7.229936] [<ffff0000081111a0>] lockdep_trace_alloc+0xe0/0xf0
> > [ 7.229940] [<ffff0000081f4950>] __kmalloc_track_caller+0x50/0x250
> > [ 7.229945] [<ffff00000857c088>] devres_alloc_node+0x28/0x60
> > [ 7.229949] [<ffff0000081220e0>] devm_request_threaded_irq+0x50/0xe0
> > [ 7.229955] [<ffff0000087e6220>] pcc_mbox_request_channel+0x110/0x170
> > [ 7.229960] [<ffff0000084b2660>] acpi_cppc_processor_probe+0x264/0x414
> > [ 7.229963] [<ffff0000084ae9f4>] __acpi_processor_start+0x28/0xa0
> > [ 7.229966] [<ffff0000084aeab0>] acpi_processor_start+0x44/0x54
> > [ 7.229970] [<ffff00000857897c>] driver_probe_device+0x1fc/0x2b0
> > [ 7.229974] [<ffff000008578ae4>] __driver_attach+0xb4/0xc0
> > [ 7.229977] [<ffff00000857683c>] bus_for_each_dev+0x5c/0xa0
> > [ 7.229980] [<ffff000008578110>] driver_attach+0x20/0x30
> > [ 7.229983] [<ffff000008577c20>] bus_add_driver+0x110/0x230
> > [ 7.229987] [<ffff000008579320>] driver_register+0x60/0x100
> > [ 7.229991] [<ffff000008d478b8>] acpi_processor_driver_init+0x2c/0xb0
> > [ 7.229996] [<ffff000008083168>] do_one_initcall+0x38/0x130
> > [ 7.230000] [<ffff000008d20d6c>] kernel_init_freeable+0x210/0x2b4
> > [ 7.230004] [<ffff000008945d90>] kernel_init+0x10/0x110
> > [ 7.230007] [<ffff000008082e80>] ret_from_fork+0x10/0x50
> >
> > It's because the spinlock inside pcc_mbox_request_channel() is
> > kept too long. This patch releases spinlock before request_irq()
> > and free_irq() to fix this issue as spinlock is only needed to
> > protect the channel data.
> >
> > Signed-off-by: Hoan Tran <hotran@apm.com>
> Reviewed-by: Prashanth Prakash <pprakash@codeaurora.org>
Applied.
Thanks,
Rafael
prev parent reply other threads:[~2016-11-24 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 19:19 Hoan Tran
2016-11-14 20:50 ` Prakash, Prashanth
2016-11-24 1:28 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7194620.HeEvFEaecv@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=dhdang@apm.com \
--cc=hotran@apm.com \
--cc=jassisinghbrar@gmail.com \
--cc=lho@apm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pprakash@codeaurora.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®