From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 900D3C2D0C3 for ; Tue, 31 Dec 2019 02:16:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B0B6206CB for ; Tue, 31 Dec 2019 02:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726709AbfLaCQn (ORCPT ); Mon, 30 Dec 2019 21:16:43 -0500 Received: from mail.windriver.com ([147.11.1.11]:46477 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbfLaCQn (ORCPT ); Mon, 30 Dec 2019 21:16:43 -0500 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.2/8.15.2) with ESMTPS id xBV2GOY1022853 (version=TLSv1 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 30 Dec 2019 18:16:24 -0800 (PST) Received: from [128.224.162.195] (128.224.162.195) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.468.0; Mon, 30 Dec 2019 18:16:24 -0800 Subject: Re: [PATCH] stmmac: debugfs entry name is not be changed when udev rename device name. To: Randy Dunlap , , CC: , , , , , References: <20191231020302.71792-1-jiping.ma2@windriver.com> <5b10a5ff-8428-48c7-a60d-69dd62009716@infradead.org> From: Jiping Ma Message-ID: <719d8dd3-0119-0c93-b299-d2b3d66b1e06@windriver.com> Date: Tue, 31 Dec 2019 10:16:20 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5b10a5ff-8428-48c7-a60d-69dd62009716@infradead.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/31/2019 10:11 AM, Randy Dunlap wrote: > Hi, > > On 12/30/19 6:03 PM, Jiping Ma wrote: >> Add one notifier for udev changes net device name. >> >> Signed-off-by: Jiping Ma >> --- >> .../net/ethernet/stmicro/stmmac/stmmac_main.c | 38 ++++++++++++++++++- >> 1 file changed, 37 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> index b14f46a57154..c1c877bb4421 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> @@ -4038,6 +4038,40 @@ static int stmmac_dma_cap_show(struct seq_file *seq, void *v) >> } >> DEFINE_SHOW_ATTRIBUTE(stmmac_dma_cap); >> >> +/** > Just use /* here since this is not a kernel-doc comment. > /** is reserved for kernel-doc comments/notation. I use checkpatch.pl to check my patch, it show one warning, then I change * to **.   I will change it back to *. WARNING: networking block comments don't use an empty /* line, use /* Comment... #23: FILE: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4042: +/* + * Use network device events to create/remove/rename > >> + * Use network device events to create/remove/rename >> + * debugfs file entries >> + */ >> +static int stmmac_device_event(struct notifier_block *unused, >> + unsigned long event, void *ptr) >> +{ > >> @@ -4050,7 +4084,6 @@ static int stmmac_init_fs(struct net_device *dev) >> >> return -ENOMEM; >> } >> - >> /* Entry to report DMA RX/TX rings */ >> priv->dbgfs_rings_status = >> debugfs_create_file("descriptors_status", 0444, > I don't see a problem with the blank line. Why remove it? I will change it back. > > > thanks.