Re: [PATCH v6 0/7] rust/hrtimer: Various hrtimer + time additions

[Daniel Almeida <daniel.almeida@collabora.com>]

Hi Lyude,

> On 24 Jul 2025, at 15:49, Lyude Paul <lyude@redhat.com> wrote:
> 
> This is a collection of various bindings that I added to hrtimer when I
> was originally getting it ready to be used in rvkms. I've mostly been
> waiting for Andreas's hrtimer series to go upstream before submitting
> these.
> 
> All of these are currently being used within rvkms for vblank emulation.
> 
> Previous versions:
>  Version 1: https://lkml.org/lkml/2025/4/2/1474
>  Version 2: https://lkml.org/lkml/2025/4/15/1750
>  Version 3 (only a revision of one patch): https://lkml.org/lkml/2025/4/15/1780
>  Version 4: https://lkml.org/lkml/2025/4/29/1715
>  Version 5: https://lkml.org/lkml/2025/6/13/1785
> 
> Usage example:
> (keep in mind, I haven't rebased the example entirely - but the only
>  differences there is a few comments)
> 
>  https://gitlab.freedesktop.org/lyudess/linux/-/tree/rvkms-slim/rust/kernel?ref_type=heads
> 
> Lyude Paul (7):
>  rust: hrtimer: Document the return value for HrTimerHandle::cancel()
>  rust: hrtimer: Add HrTimerInstant
>  rust: hrtimer: Add HrTimer::raw_forward() and forward()
>  rust: hrtimer: Add HrTimerCallbackContext and ::forward()
>  rust: hrtimer: Add forward_now() to HrTimer and HrTimerCallbackContext
>  rust: time: Add Instant::from_nanos()
>  rust: hrtimer: Add HrTimer::expires()
> 
> rust/kernel/time.rs                 |  22 ++++
> rust/kernel/time/hrtimer.rs         | 152 +++++++++++++++++++++++++++-
> rust/kernel/time/hrtimer/arc.rs     |   9 +-
> rust/kernel/time/hrtimer/pin.rs     |   9 +-
> rust/kernel/time/hrtimer/pin_mut.rs |  12 ++-
> rust/kernel/time/hrtimer/tbox.rs    |   9 +-
> 6 files changed, 204 insertions(+), 9 deletions(-)
> 
> 
> base-commit: dff64b072708ffef23c117fa1ee1ea59eb417807
> -- 
> 2.50.0
> 
> 


Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>

A few very minor nits will follow.

— Daniel