From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932289AbbJMBnS (ORCPT ); Mon, 12 Oct 2015 21:43:18 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:36343 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932110AbbJMBnQ convert rfc822-to-8bit (ORCPT ); Mon, 12 Oct 2015 21:43:16 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.0 \(3094\)) Subject: Re: [RFC] mm: fix a BUG, the page is allocated 2 times From: yalin wang In-Reply-To: <20151012135250.GA3625@techsingularity.net> Date: Tue, 13 Oct 2015 09:43:11 +0800 Cc: akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com, rientjes@google.com, js1304@gmail.com, kirill.shutemov@linux.intel.com, hannes@cmpxchg.org, alexander.h.duyck@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <71CD787F-57A8-4F95-9D16-BA73E1F87FE1@gmail.com> References: <1444617606-8685-1-git-send-email-yalin.wang2010@gmail.com> <20151012135250.GA3625@techsingularity.net> To: Mel Gorman X-Mailer: Apple Mail (2.3094) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Oct 12, 2015, at 21:52, Mel Gorman wrote: > > There is a redundant check and a memory leak introduced by a patch in > mmotm. This patch removes an unlikely(order) check as we are sure order > is not zero at the time. It also checks if a page is already allocated > to avoid a memory leak. > > This is a fix to the mmotm patch > mm-page_alloc-reserve-pageblocks-for-high-order-atomic-allocations-on-demand.patch > > Signed-off-by: yalin wang > Acked-by: Mel Gorman no problem, i have send the patch again using your change log . Thanks