From: Minchan Kim <minchan.kim@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>,
Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Minchan Kim <minchan.kim@gmail.com>
Subject: [PATCH v3 01/10] compaction: trivial clean up acct_isolated
Date: Tue, 7 Jun 2011 23:38:14 +0900 [thread overview]
Message-ID: <71a79768ff8ef356db09493dbb5d6c390e176e0d.1307455422.git.minchan.kim@gmail.com> (raw)
In-Reply-To: <cover.1307455422.git.minchan.kim@gmail.com>
In-Reply-To: <cover.1307455422.git.minchan.kim@gmail.com>
acct_isolated of compaction uses page_lru_base_type which returns only
base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE.
In addtion, cc->nr_[anon|file] is used in only acct_isolated so it doesn't have
fields in conpact_control.
This patch removes fields from compact_control and makes clear function of
acct_issolated which counts the number of anon|file pages isolated.
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
mm/compaction.c | 18 +++++-------------
1 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 021a296..61eab88 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -35,10 +35,6 @@ struct compact_control {
unsigned long migrate_pfn; /* isolate_migratepages search base */
bool sync; /* Synchronous migration */
- /* Account for isolated anon and file pages */
- unsigned long nr_anon;
- unsigned long nr_file;
-
unsigned int order; /* order a direct compactor needs */
int migratetype; /* MOVABLE, RECLAIMABLE etc */
struct zone *zone;
@@ -212,17 +208,13 @@ static void isolate_freepages(struct zone *zone,
static void acct_isolated(struct zone *zone, struct compact_control *cc)
{
struct page *page;
- unsigned int count[NR_LRU_LISTS] = { 0, };
+ unsigned int count[2] = { 0, };
- list_for_each_entry(page, &cc->migratepages, lru) {
- int lru = page_lru_base_type(page);
- count[lru]++;
- }
+ list_for_each_entry(page, &cc->migratepages, lru)
+ count[!!page_is_file_cache(page)]++;
- cc->nr_anon = count[LRU_ACTIVE_ANON] + count[LRU_INACTIVE_ANON];
- cc->nr_file = count[LRU_ACTIVE_FILE] + count[LRU_INACTIVE_FILE];
- __mod_zone_page_state(zone, NR_ISOLATED_ANON, cc->nr_anon);
- __mod_zone_page_state(zone, NR_ISOLATED_FILE, cc->nr_file);
+ __mod_zone_page_state(zone, NR_ISOLATED_ANON, count[0]);
+ __mod_zone_page_state(zone, NR_ISOLATED_FILE, count[1]);
}
/* Similar to reclaim, but different enough that they don't share logic */
--
1.7.0.4
next prev parent reply other threads:[~2011-06-07 14:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 14:38 [PATCH v3 00/10] Prevent LRU churning Minchan Kim
2011-06-07 14:38 ` Minchan Kim [this message]
2011-06-09 13:33 ` [PATCH v3 01/10] compaction: trivial clean up acct_isolated Mel Gorman
2011-06-09 14:41 ` Minchan Kim
2011-06-09 14:47 ` Mel Gorman
2011-06-10 8:19 ` KOSAKI Motohiro
2011-06-12 14:24 ` Michal Hocko
2011-06-13 14:48 ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 02/10] Change isolate mode from int type to enum type Minchan Kim
2011-06-09 13:51 ` Mel Gorman
2011-06-09 14:56 ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 03/10] Add additional isolation mode Minchan Kim
2011-06-09 13:59 ` Mel Gorman
2011-06-09 15:00 ` Minchan Kim
2011-06-12 14:45 ` Michal Hocko
2011-06-13 14:54 ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 04/10] compaction: make isolate_lru_page with filter aware Minchan Kim
2011-06-09 14:03 ` Mel Gorman
2011-06-12 14:49 ` Michal Hocko
2011-06-07 14:38 ` [PATCH v3 05/10] vmscan: " Minchan Kim
2011-06-09 14:04 ` Mel Gorman
2011-06-09 15:02 ` Minchan Kim
2011-06-12 14:55 ` Michal Hocko
2011-06-13 1:04 ` KOSAKI Motohiro
2011-06-07 14:38 ` [PATCH v3 06/10] In order putback lru core Minchan Kim
2011-06-09 14:27 ` Mel Gorman
2011-06-09 15:15 ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 07/10] migration: clean up unmap_and_move Minchan Kim
2011-06-13 1:34 ` KOSAKI Motohiro
2011-06-07 14:38 ` [PATCH v3 08/10] migration: make in-order-putback aware Minchan Kim
2011-06-07 14:38 ` [PATCH v3 09/10] compaction: make compaction use in-order putback Minchan Kim
2011-06-07 14:38 ` [PATCH v3 10/10] add inorder-lru tracepoints for just measurement Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71a79768ff8ef356db09493dbb5d6c390e176e0d.1307455422.git.minchan.kim@gmail.com \
--to=minchan.kim@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®