From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE823C282C0 for ; Wed, 23 Jan 2019 20:18:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9ED7E21855 for ; Wed, 23 Jan 2019 20:18:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="OkznBCNb"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="amC/oJNu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726774AbfAWUSL (ORCPT ); Wed, 23 Jan 2019 15:18:11 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:50792 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbfAWUSK (ORCPT ); Wed, 23 Jan 2019 15:18:10 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1D033608FD; Wed, 23 Jan 2019 20:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548274689; bh=bwlsh6JqLJpEtXi+NJKYQn4LeIj58d2W7GMwAqEFXr8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=OkznBCNbJBIDcmrWi9fYISmY6LsaZoshbXR0OqVMuRoTQZNYRHL+mYwohiuGEWoCA 1R2JikFOC9eEjX0PITehrqgUwVmV3+ZeURbmrsk6npVO3uV9iM0jg0ExU0FOKvfYXB Oo4fWJhussKcql/S0Mr1JfG9o8CItv0aOrW5HXRM= Received: from [192.168.43.47] (unknown [223.227.14.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E10AF60850; Wed, 23 Jan 2019 20:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548274686; bh=bwlsh6JqLJpEtXi+NJKYQn4LeIj58d2W7GMwAqEFXr8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=amC/oJNu4Cz/MLnw+j9r0X59y1TNT/PYk/rywVnihcbuvToCoHCsMGOo9iu7fYNnm 4UVWXbeY9vZzxSrjUYzSw213FvPAWhZi/zJSL7QvuQJF9VRRUkTWfkGQcIreMU4lPZ dYISzhHMSBgZsCFjsDSTUIz5EwJzTtkRhiu7DYt8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E10AF60850 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=saiprakash.ranjan@codeaurora.org Subject: Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support To: Mathieu Poirier Cc: Suzuki K Poulose , Rob Herring , Leo Yan , Alexander Shishkin , Andy Gross , David Brown , Vivek Gautam , Doug Anderson , Stephen Boyd , Bjorn Andersson , devicetree@vger.kernel.org, Mark Rutland , Rajendra Nayak , Sibi Sankar , linux-arm-kernel , Linux Kernel Mailing List , linux-arm-msm , John Horley References: <1bd39862-0725-70ce-6535-fdb59569f683@arm.com> <75ed74af-6946-b86d-092e-42dc16e55308@codeaurora.org> <91a90daa-9e14-2d2e-e633-2ddfdc0955bf@arm.com> <3906faf1-abbd-9c28-ad55-ed3800f06352@codeaurora.org> <5b54c6e0-7d22-ecee-486f-31333f49f84a@codeaurora.org> From: Sai Prakash Ranjan Message-ID: <71ae9f41-50ff-742b-3e12-ca2ce84e0d3c@codeaurora.org> Date: Thu, 24 Jan 2019 01:47:56 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mathieu, On 1/24/2019 12:44 AM, Mathieu Poirier wrote: > On Wed, 23 Jan 2019 at 05:12, Sai Prakash Ranjan > wrote: > > That depends on whether the ETMs have been modified at all, something > Suzuki has asked to be clarified. If ETMs have been modified then we > need to understand how they differ from the driver's implementation. We had asked hardware team for clarification regarding this. Let me poke them again. As for the driver, downstream implementation also uses the same driver, so I am not sure what do you mean by differing from the driver's implementation. > If the implementations are the same: > >> >> @@ -1079,6 +1079,10 @@ static const struct amba_id etm4_ids[] = { >> ETM4x_AMBA_ID(0x000bb95a), /* Cortex-A72 */ >> ETM4x_AMBA_ID(0x000bb959), /* Cortex-A73 */ >> ETM4x_AMBA_ID(0x000bb9da), /* Cortex-A35 */ >> + ETM4x_AMBA_ID(0x000f0211), /* Qualcomm Kryo */ >> + ETM4x_AMBA_ID(0x000f0205), /* Qualcomm Kryo */ > > What version of the Kryo CPU? And the above will need to be in a > separate patch with the modifications to address the problem you > mentionned below. > There is no Kryo version for MSM8996 (its only given as Kryo), MSM8998 onwards we have Kryo versions like Kryo 280 and so on. Hence I skipped for this one and added the version for SDM845. >> + ETM4x_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385 >> Cortex-A75 */ >> + ETM4x_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385 >> Cortex-A55 */ > > Please add them in chronological order. > Sure, will do it. >> {}, >> }; >> >> For msm8996, cpu debug module pid returned is same as ETM >> which is causing the probe failure for cpu debug coresight module >> as shown in below logs. >> For this case, I tried adding these ids to cpu debug driver, but it >> splits some errors (coresight-cpu-debug: probe of 3840000.etm failed >> with error -16) since the ids are same. Can we override for this case >> or there is something else we can do here? > > That is another problem. See this patchset [1] from Mike Leach for a > description of the problem and how to fix it. > > [1]. https://lkml.org/lkml/2018/12/7/784 > Thanks a lot for this link. I will check this out. - Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation