From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m3269.qiye.163.com (mail-m3269.qiye.163.com [220.197.32.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57DEE38947F for ; Mon, 1 Jun 2026 11:22:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312939; cv=none; b=QXAqsGIW5ed/E7VOVTn3fHUe0IygI03DQi53OxMjOUJsAp3FkgqazzeawSqZplNOU4riA6Ff2S94wG3D6CwlfMV8lgK2/gTFPg7aV1G+25DUMg+lznmlydGqtPfr3NUDLA/dOz/rHr+Rb8YrQGgtDjPQ6MnPH1ooL4KiPgX1BQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312939; c=relaxed/simple; bh=8R97UY80PJl/HpqXX4YpcMWNbFGnVDwU5QfWv8fVEzg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vBG/af4r9mHyeOadLOCrFyK1TvXBAsNgNPKB2ha3+pY6uO06WQWdHVG4gx4WcBcw7R+3lY+fY+JltQF6dCE567aFWl+RqzDNgG4+Kj1eMDz4sdbNGngBWq5eQ85VuJqIqp5hbZQ5hOaSuO7gqfjce/jl+3tfqHdl9XUOCyOjtJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=Xr8G+B54; arc=none smtp.client-ip=220.197.32.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="Xr8G+B54" Received: from [172.16.12.77] (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 409783698; Mon, 1 Jun 2026 18:46:41 +0800 (GMT+08:00) Message-ID: <71b11cb4-9c9c-4875-a48f-98cb0e3e0517@rock-chips.com> Date: Mon, 1 Jun 2026 18:46:41 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] drm/rockchip: vop2: Drop redundant zero-init in setup_layer_mixer() To: Cristian Ciocaltea , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260504-vop2-layer-cfg-tmout-v1-0-730226a7331e@collabora.com> <20260504-vop2-layer-cfg-tmout-v1-4-730226a7331e@collabora.com> Content-Language: en-US From: Andy Yan In-Reply-To: <20260504-vop2-layer-cfg-tmout-v1-4-730226a7331e@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9e82cafc6109d8kunm2db9e1ee38d185 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlDSU5DVk9MQ0kYGE4YSBgfSVYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU 9PT0hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=Xr8G+B54eBQ9FXoDUYlHPIa6DdsjWDxLSkMD/pKLRF6rV+zF6Ax+Y/aClKKK0WwRf3l/eR49as8L4LLYG//fERlL4WJI3KHvReiVuY2neI4EptM4kzvxMzQyEu09lxoTvznKWSnkciEAyFZyhV4c1Rp38e7sbOSAtKvXA5iP0Wo=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=4erhXhxolnnqphWTttWW2Y4zr5sdcM4XBJBGs4a57V8=; h=date:mime-version:subject:message-id:from; Hello, On 5/5/26 02:24, Cristian Ciocaltea wrote: > The layer_sel and atv_layer_sel local variables in > rk3568_vop2_setup_layer_mixer() are unconditionally assigned from > vop2->old_layer_sel and the RK3568_OVL_LAYER_SEL register read, > respectively, before any use. > > Remove the superfluous zero-initializers. > > Signed-off-by: Cristian Ciocaltea Reviewed-by: Andy Yan > --- > drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c > index 1f5e8c2acecd..0849bd922ffb 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c > +++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c > @@ -2134,9 +2134,9 @@ static void rk3568_vop2_setup_layer_mixer(struct vop2_video_port *vp) > { > struct vop2 *vop2 = vp->vop2; > struct drm_plane *plane; > - u32 layer_sel = 0; > + u32 layer_sel; > u32 port_sel; > - u32 atv_layer_sel = 0; > + u32 atv_layer_sel; > u8 layer_id; > u8 old_layer_id; > u8 layer_sel_id; >