From: Alexandre Torgue <alexandre.torgue@st.com>
To: Vikas Manocha <vikas.manocha@st.com>, <linux-kernel@vger.kernel.org>
Cc: <patrice.chotard@st.com>
Subject: Re: [PATCH 0/3] Arm: dts: stm32: remove extra compatible uart string
Date: Thu, 5 Oct 2017 18:01:48 +0200 [thread overview]
Message-ID: <71b2711c-40cd-d09f-a879-218f688a3a51@st.com> (raw)
In-Reply-To: <1506639114-16913-1-git-send-email-vikas.manocha@st.com>
Hi Vikas
On 09/29/2017 12:51 AM, Vikas Manocha wrote:
> stm32 uart driver is using two compatible strings "st,stm32-usart"
> & "st,stm32-uart". One can be removed safely to save some space & time.
>
> Vikas Manocha (3):
> Arm: dts: stm32: remove extra compatible string for uart
> Arm: dts: stm32: remove extra compatible string from DT & driver
> ARM: dts: stm32h7: correct uart nodes compatible string
>
> Documentation/devicetree/bindings/dma/stm32-dma.txt | 2 +-
> Documentation/devicetree/bindings/serial/st,stm32-usart.txt | 10 +++-------
> arch/arm/boot/dts/stm32f429.dtsi | 12 ++++++------
> arch/arm/boot/dts/stm32f746.dtsi | 12 ++++++------
> arch/arm/boot/dts/stm32h743.dtsi | 4 ++--
> drivers/tty/serial/stm32-usart.c | 3 ---
> 6 files changed, 18 insertions(+), 25 deletions(-)
>
I think it is better to put people in CC of patch 1, 2, 3 also in CC of
cover-letter. I think you should split patches differently. Maybe one
for drivers and bindings (doc) updates. And others for DT updates.
Conerning DT patches, all headers should start by "ARM: dts: stm32: blabla"
Regards
Alex
next prev parent reply other threads:[~2017-10-05 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 22:51 Vikas Manocha
2017-09-28 22:51 ` [PATCH 1/3] Arm: dts: stm32: remove extra compatible string for uart Vikas Manocha
2017-10-05 23:32 ` Rob Herring
2017-09-28 22:51 ` [PATCH 2/3] Arm: dts: stm32: remove extra compatible string from DT & driver Vikas Manocha
2017-09-28 22:51 ` [PATCH 3/3] ARM: dts: stm32h7: correct uart nodes compatible string Vikas Manocha
2017-10-05 16:01 ` Alexandre Torgue [this message]
2017-10-05 17:36 ` [PATCH 0/3] Arm: dts: stm32: remove extra compatible uart string Vikas MANOCHA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71b2711c-40cd-d09f-a879-218f688a3a51@st.com \
--to=alexandre.torgue@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patrice.chotard@st.com \
--cc=vikas.manocha@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®