mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
	dri-devel@lists.freedesktop.org,
	David Airlie <airlied@redhat.com>
Cc: noralf@tronnes.org, David Airlie <airlied@linux.ie>,
	"open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" 
	<virtualization@lists.linux-foundation.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 08/16] drm/bochs: atomic: use suspend/resume helpers
Date: Fri, 11 Jan 2019 13:08:01 +0200	[thread overview]
Message-ID: <71b9afc8-c984-a837-c12d-a55c5468575f@gmail.com> (raw)
In-Reply-To: <20190111053752.4004-9-kraxel@redhat.com>

On 1/11/19 7:37 AM, Gerd Hoffmann wrote:
> Switch to atomic helpers: drm_mode_config_helper_suspend/resume().
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>   drivers/gpu/drm/bochs/bochs_drv.c | 11 ++---------
>   1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c
> index f3dd66ae99..08ba6029d2 100644
> --- a/drivers/gpu/drm/bochs/bochs_drv.c
> +++ b/drivers/gpu/drm/bochs/bochs_drv.c
> @@ -103,11 +103,8 @@ static int bochs_pm_suspend(struct device *dev)
>   	struct drm_device *drm_dev = pci_get_drvdata(pdev);
>   	struct bochs_device *bochs = drm_dev->dev_private;
>   
> -	drm_kms_helper_poll_disable(drm_dev);
> -
>   	drm_fb_helper_set_suspend_unlocked(&bochs->fb.helper, 1);
> -
> -	return 0;
> +	return drm_mode_config_helper_suspend(drm_dev);
>   }
>   
>   static int bochs_pm_resume(struct device *dev)
> @@ -116,12 +113,8 @@ static int bochs_pm_resume(struct device *dev)
>   	struct drm_device *drm_dev = pci_get_drvdata(pdev);
>   	struct bochs_device *bochs = drm_dev->dev_private;
>   
> -	drm_helper_resume_force_mode(drm_dev);
> -
>   	drm_fb_helper_set_suspend_unlocked(&bochs->fb.helper, 0);
> -
> -	drm_kms_helper_poll_enable(drm_dev);
> -	return 0;
> +	return drm_mode_config_helper_resume(drm_dev);
>   }
>   #endif
>   


  reply	other threads:[~2019-01-11 11:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190111053752.4004-1-kraxel@redhat.com>
2019-01-11  5:37 ` [PATCH v4 01/16] drm/bochs: encoder cleanup Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 02/16] drm/bochs: split bochs_hw_setmode Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 03/16] drm/bochs: atomic: add atomic_flush+atomic_enable callbacks Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 04/16] drm/bochs: atomic: add mode_set_nofb callback Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 05/16] drm/bochs: atomic: switch planes to atomic, wire up helpers Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 06/16] drm/bochs: atomic: use atomic set_config helper Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 07/16] drm/bochs: atomic: use atomic page_flip helper Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 08/16] drm/bochs: atomic: use suspend/resume helpers Gerd Hoffmann
2019-01-11 11:08   ` Oleksandr Andrushchenko [this message]
2019-01-11  5:37 ` [PATCH v4 09/16] drm/bochs: atomic: set DRIVER_ATOMIC Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 10/16] drm/bochs: remove old bochs_crtc_* functions Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 11/16] drm/bochs: drop unused gpu_addr arg from bochs_bo_pin() Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 12/16] drm/bochs: move ttm_bo_(un)reserve calls into bochs_bo_{pin,unpin} Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 13/16] drm/bochs: add basic prime support Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 14/16] drm/bochs: switch to generic drm fbdev emulation Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 15/16] drm/bochs: drop old fbdev emulation code Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 16/16] drm/bochs: move remaining fb bits to kms Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71b9afc8-c984-a837-c12d-a55c5468575f@gmail.com \
    --to=andr2000@gmail.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®