mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Andy Yan" <andyshrk@163.com>
To: "Chaoyi Chen" <kernel@airkyi.com>
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Alexey Charkov" <alchark@gmail.com>,
	"Shawn Lin" <shawn.lin@rock-chips.com>,
	"Chaoyi Chen" <chaoyi.chen@rock-chips.com>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re:[PATCH] arm64: dts: rockchip: Fix sdmmc pwren pinctrl for rk3576-evb2
Date: Thu, 26 Feb 2026 19:24:48 +0800 (CST)	[thread overview]
Message-ID: <71bf3205.7a33.19c99b1bcb7.Coremail.andyshrk@163.com> (raw)
In-Reply-To: <20260226102052.63-1-kernel@airkyi.com>


Hello,

At 2026-02-26 18:20:52, "Chaoyi Chen" <kernel@airkyi.com> wrote:
>From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
>
>In rk3576.dtsi, sdmmc0_pwren is configured as part of the sdmmc pinctrl.
>However, on the rk3576 evb2 board, sdmmc0_pwren is used as the regulator
>for vmmc-supply. Therefore, we need to reassign the sdmmc pinctrl and
>remove sdmmc0_pwren to avoid conflicts.
>
>Cc: Shawn Lin <shawn.lin@rock-chips.com>
>Fixes: 86a82f7a7eed ("arm64: dts: rockchip: Add rk3576 evb2 board")
>Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
   Tested-by: Andy Yan <andy.yan@163.com>


>---
> arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts b/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts
>index 6bdc232ab267..98d5d00d63b5 100644
>--- a/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts
>+++ b/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts
>@@ -951,6 +951,8 @@ &sdmmc {
> 	disable-wp;
> 	no-sdio;
> 	no-mmc;
>+	pinctrl-names = "default";
>+	pinctrl-0 = <&sdmmc0_clk &sdmmc0_cmd &sdmmc0_det &sdmmc0_bus4>;
> 	sd-uhs-sdr104;
> 	vmmc-supply = <&vcc3v3_sd>;
> 	vqmmc-supply = <&vccio_sd_s0>;
>-- 
>2.51.1
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-02-26 11:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 10:20 [PATCH] " Chaoyi Chen
2026-02-26 11:24 ` Andy Yan [this message]
2026-03-02 11:39 ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71bf3205.7a33.19c99b1bcb7.Coremail.andyshrk@163.com \
    --to=andyshrk@163.com \
    --cc=alchark@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kernel@airkyi.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®