mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chang S. Bae" <chang.seok.bae@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	"Brown, Len" <len.brown@intel.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	"Chatre, Reinette" <reinette.chatre@intel.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] Documentation/x86: Add the AMX enabling example
Date: Thu, 30 Jun 2022 09:17:26 -0700	[thread overview]
Message-ID: <71c0b3b3-f9a7-378d-89bb-3035a7b0b494@intel.com> (raw)
In-Reply-To: <66c4d3ce4c6f47d29bbb951739555eb0@intel.com>

On 6/30/2022 9:07 AM, Luck, Tony wrote:
>> But these state components are architectural. While this can help
>> userspace anyway, saying "XSTATE component" here and on the man-page is
>> probably it as they are already defined in the x86 spec.
> 
> An application writer can't use:
> 
> # include {x86 spec}"
> 
> to get these values ... if applications need them to find out if AMX is present,
> and to enable it, then they need an API.

Yeah, you're right.

> 
> Maybe your example code should just be a library routine? So application writers
> can just do:
> 
> if (!intel_amx_enable()) {
> error message, or fall back to non-AMX implementation
> }
> 
> without having to worry about those #defines.

I guess we cannot assume this. Given the arch_prctl() options, they can 
do this by themselves.

Let me include those defines on the next version.

Thanks,
Chang

  reply	other threads:[~2022-06-30 16:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 22:42 [PATCH v2 0/1] Documentation/x86: Update the dynamic XSTATE doc Chang S. Bae
2022-06-29 22:42 ` [PATCH v2 1/1] Documentation/x86: Add the AMX enabling example Chang S. Bae
2022-06-29 23:30   ` Luck, Tony
2022-06-30 15:26     ` Chang S. Bae
2022-06-30 16:07       ` Luck, Tony
2022-06-30 16:17         ` Chang S. Bae [this message]
2022-06-30  3:03   ` Bagas Sanjaya
2022-06-30 15:38     ` Chang S. Bae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71c0b3b3-f9a7-378d-89bb-3035a7b0b494@intel.com \
    --to=chang.seok.bae@intel.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=reinette.chatre@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®