From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outbound.st.icloud.com (p-east2-cluster1-host1-snip4-10.eps.apple.com [57.103.76.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E7473AD51F for ; Sun, 28 Jun 2026 16:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=57.103.76.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782663040; cv=none; b=FRScXpKQjKh9/EVD4DfDYJQJashTF9+hp6kqKImf6pkNu36G0Yi18C8ldqGCq6hoGREqYPSKcQVp2+GIFVYFEYTo8G1AP87/wGEuZR4m8RYRirusO6oPIEROO74ViXaJ0EveLBewz9h5L4ZIN5jyV5e/zFzVbXtJgR3SkD6PFuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782663040; c=relaxed/simple; bh=Ew3lUvxDAU0i04pP9OMra7iRyqb9tX2u5eM5WOx02Pg=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=BaiUO8tmTWhvekly4hxetpkHyV6+iGiIxAXqkmr+d2sIERGLDmXOoBFABrej71ecqqPOksxWKNtr65TF+3TSg4UYXwP7nPfGvlfOCBK6ee1LkHvUjhm5f2WnP+W23vB54yUd0ANtwcI4tKjc3aYJ1I6T5AteV2d6RFpxbcS8xQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com; spf=pass smtp.mailfrom=icloud.com; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b=Uv1cAx4I; arc=none smtp.client-ip=57.103.76.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=icloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b="Uv1cAx4I" Received: from outbound.st.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-east-1a-60-percent-11 (Postfix) with ESMTPS id 47C761800C36; Sun, 28 Jun 2026 16:10:32 +0000 (UTC) X-ICL-RepId: 019f0eff-313b-772f-b613-896e1996b055 X-ICL-Out-Info: HUtFAUMEWwJACUgATUQeDx5WFlZNRAJCTQhKB0MGWQReCEsLQwZcBlBcHA4XXhtCFUsVXANcDkswUBtfAkIPHBNWFRMLU1ZbE1UXRgkZCF0dGQpQUAVaEhhcFFxQWB5GElYNXQkZGEZeUBtfAkIPHBNWFRMdQxkPKwhKBEMHRQJeCyUTCVNWWxNVF0YJGQhdHRkVWgkKVwVBWkkCWgZcH0ULHQtAA18FRRRABF4GRgUUXEEEDAJZBhYMTHMEVAddBV1WUAJaVRIEQAhWUF4IXh9MHA== Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1782663038; x=1785255038; bh=Ew3lUvxDAU0i04pP9OMra7iRyqb9tX2u5eM5WOx02Pg=; h=Message-ID:Date:MIME-Version:To:Subject:From:Content-Type:x-icloud-hme; b=Uv1cAx4IHp+LngLoi2HkVwbRyqpi4cRLcjxl3m7MPerh40AGVv89OywMTPlB6U5qGvn+4ZqT9e7x7YFISEdyyv4nSetKNU5S6VDPX6mcpfUgAEk5XCy3IORcbdhIo+2tLS2RcqXpxnCF0NwFw5OrmeWVYLRs1UrYGhlUkbylZJ79tMDmnL5QeY5d3jGsiH6zqB62ZzEACQ3GZnWlf3yAxOZajIsdyimAZvfk4WEksNbn7UiGTpxug/otf6jbuqGgJJ6EUagLFpne+WTJVvw7KbTtMMix8cGcEGqLtTYN7s3gFk0j5xft+aQviakIGKEDrI7jdu08u/ZdHO/TqJ/zLA== Received: from [192.168.255.10] (unknown [17.42.251.67]) by p00-icloudmta-asmtp-us-east-1a-60-percent-11 (Postfix) with ESMTPSA id 60C781800123; Sun, 28 Jun 2026 16:10:26 +0000 (UTC) Message-ID: <71c11717-52e8-4475-8731-7de97a524f54@icloud.com> Date: Mon, 29 Jun 2026 00:10:20 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: david@kernel.org Cc: akpm@linux-foundation.org, axelrasmussen@google.com, baohua@kernel.org, bruzzhang@tencent.com, hannes@cmpxchg.org, kasong@tencent.com, liam@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org, mhocko@kernel.org, mhocko@suse.com, qi.zheng@linux.dev, rppt@kernel.org, shakeel.butt@linux.dev, surenb@google.com, vbabka@kernel.org, weixugc@google.com, yuanchu@google.com, zippermonkey@icloud.com References: <5c665b98-088a-401f-aab8-7c9c4d4f484d@kernel.org> Subject: Re: [PATCH v4 3/5] mm/vmscan: extract pageout_one() from shrink_folio_list() From: Zhang Peng In-Reply-To: <5c665b98-088a-401f-aab8-7c9c4d4f484d@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: DZzefIPOFiNZyZyNcxQB3XGMydJ2m4dG X-Proofpoint-ORIG-GUID: DZzefIPOFiNZyZyNcxQB3XGMydJ2m4dG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI4MDE0NCBTYWx0ZWRfX75ShFZc+UaDw ktX248gnG+szdXwsCN8a5uA37eBqtz3enQJUFin3DtO/KXR8BcDO3RJ83LVV2BKyciNd8z1xfLk Dxy33qTPeQ+jPsEbhCqJPQrGkuROIPr4ZrjvdJ/PGpj8DwgFa6HgakYk0G38gQ7sOJVnJXe7YNr QgXQC4wfZNCFXywR1/M2GHBRf6ZzoZqV5Es27Q0iRkItuX6uRS87zYnMkOnxwA2IOnQ1diEWpKP o74jSMIi7meR3f73Xi6X1nIKgH0+AhTb2+hcE+Fl27bCNnFtCPczEaZOGF9PhD1PxzgjhA02jCW /FsGnkZchAEo5QdhldN On Wed, Jun 17, 2026 at 02:19:38PM +0200, David Hildenbrand wrote: > Two tabs please. > Same comment regarding returning a bool. > Can both be const I assume. On Wed, Jun 17, 2026 at 02:25:07PM +0200, David Hildenbrand wrote: > Thinking again, should we call this "folio_try_pageout" or something > like that (and keep the bool)? Renamed to folio_try_pageout() — consistent with the other helpers. Fixed alignment, added const to nr_pages and mapping, reflowed the comments to use the wider columns.