mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Val Packett <val@packett.cool>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Krishna Kurapati PSSNV <krishna.kurapati@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Abel Vesa <abel.vesa@linaro.org>,
	Rajendra Nayak <quic_rjendra@quicinc.com>,
	Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Subject: Re: [PATCH 0/2] Modify USB controller nodes for USB on X1E80100
Date: Sat, 22 Nov 2025 19:18:12 -0300	[thread overview]
Message-ID: <71c15a78-7a50-4913-b677-e5308fcabfad@packett.cool> (raw)
In-Reply-To: <22ad48ac-e054-4f2f-a5a5-8047266ff4cc@oss.qualcomm.com>


On 10/27/25 8:46 AM, Konrad Dybcio wrote:
> On 10/19/25 1:35 PM, Krishna Kurapati PSSNV wrote:
>>
>> On 10/14/2025 2:30 PM, Val Packett wrote:
>>> Hi,
>>>
>>> On 10/13/25 11:21 PM, Krishna Kurapati wrote:
>>>> This series aims to flatten usb dt nodes and use latest bindings.
>>>> While at it, fix a compile time warning on the HS only controller node.
>>>>
>>>> Tests done:
>>>> 1. On CRD, verified host mode operation of the 3 exposed Type-C ports
>>>> and enumeration of the Goodix fingerprint sensor on the multiport
>>>> usb controller.
>>>>
>>>> 2. Modified the dr_mode to otg for the first 3 controllers and
>>>> verified role switching and device mode operation on the 3 exposed
>>>> Type-C ports.
>>>>
>>>> HS only controller was not tested on any platform.
>>> have you tested suspend-resume?
>>>
>>> The flattened dwc driver seems to break it for me on Latitude 7455, upon trying to resume the screen never comes back up and the system just reboots from zero in a couple seconds instead.
>>>
>>> I've looked at the code and I couldn't find the cause so far, but it is fine with the legacy driver and not fine with this one :(
>>>
>> Hi Val,
>>
>>   Thanks for reporting this. I did test runtime suspend resume on all 3 typec ports as mentioned. But I didn't check system suspend case.
>>
>>   I will try to reproduce the issue, fix it and then resend the patches.
> I can repro on the CRD..
>
> It's the USB3_0 host that causes the issue
>
> Removing the clk_bulk_disable_unprepare() call in dwc3_qcom_suspend()
> helps..
>
> Konrad

friendly ping.. has there been any progress on solving this properly and 
switching to the flattened nodes?

~val


  reply	other threads:[~2025-11-22 22:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14  2:21 Krishna Kurapati
2025-10-14  2:21 ` [PATCH 1/2] arm64: dts: qcom: x1e80100: Flatten usb controller nodes Krishna Kurapati
2025-10-14  2:21 ` [PATCH 2/2] arm64: dts: qcom: x1e80100: Fix compile warnings for USB HS controller Krishna Kurapati
2025-10-14  9:00 ` [PATCH 0/2] Modify USB controller nodes for USB on X1E80100 Val Packett
2025-10-19 11:35   ` Krishna Kurapati PSSNV
2025-10-27 11:46     ` Konrad Dybcio
2025-11-22 22:18       ` Val Packett [this message]
2025-10-14 13:29 ` Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71c15a78-7a50-4913-b677-e5308fcabfad@packett.cool \
    --to=val@packett.cool \
    --cc=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krishna.kurapati@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sibi.sankar@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®