From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DF7A5228 for ; Wed, 5 Mar 2025 01:00:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741136428; cv=none; b=SM1dCV/eV/vRAEyRJuwmV5sHV1wSiOPpFPYHht0kG07OCi1X7NYMmVBRazZ3Q61CXPys5TeaSnOEdNM8UF7pFzzJ3w/6dtIzF9EcDosdfurmy9gtx16yDgdljt22DMlF/yx9QZctfNXeJl8R0GoYu0a45R8BFeoZVCD3EE9Mstk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741136428; c=relaxed/simple; bh=FRqmXYpYVBt8WeZOTp6ZTdH2x+Rqo3KDqIOZpuj4mN4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gI8eodQ1hDuoXBfzMp9KrluNnq9V9g7Y+amXTX5kd3phbKSrmDO5nrothyif4VcpQY9kSdOvYO5NLiiemUWvKbCEha2RmKeb9GY+hSwGE+9YwLqXnVdDM0knLflzgeaKDbn6lORvTyaVf45Vt9DI7yKNTRJPTw6lkJ4yyILuElk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=AjnalfrL; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="AjnalfrL" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-aaec61d0f65so1273177066b.1 for ; Tue, 04 Mar 2025 17:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1741136424; x=1741741224; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=chlUX2BPGTU5TeZ1kFFp37lGXktq1FgiG+bxYUO8kTk=; b=AjnalfrLCIreR9PBMDyUPDsCkViRaWgsDAoL+b4DrtIlMlzstx+58eTkM7sEbHA48h nsQ7PezbNoI92/AqBg8Ptp2uk0ryrLcNvF4RT61p//vIpHJHc6M77jgHZfoRHTCfKRC5 HupfNj9Vrr84qsV1F+kvPYXcJSw6C7gPk/zwGODA2ECmQ2f6+yEv3oo3wLtaYhhcf51K Ol/VN5PEvPmHHegyynZkUrSLEFB7NpfwgXXv9Q7POgWjbabkTzlwd8UxtT3ncIW1kuyp L8WZtL4+86rOZuQXVXXjCL+PAUPf/Hw+ghzrgC9GmXvvoak1iQ/53Z+X0TBGESixVdqA KwhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741136424; x=1741741224; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=chlUX2BPGTU5TeZ1kFFp37lGXktq1FgiG+bxYUO8kTk=; b=quJilALifZmtPvZZxg8y2OFER8u8092P5pb0KAqnDy/xJbc5KJ68GxM4uUzGAWnhoY f+eFuBb0OHKoSGpXXGzSKFsJQIFnWG4E/wqKFn+hIg9tZRLpI0Wh+hsXyt1S4iECkRej qhm9LjME0Y6k+tNoO5KJnJJI5YF2LFDRDq1fl5AQ+8kCXmRLFRxM1Gped7rJNSamI43t STBKiu5SrT0XJxpr58uG1XgnefImF71vbm4knR3b6ePT052LPyldryGyzkkoZr4h9TuZ yOWI8t0if1kqQ+HBgn6qZsWoh9o6gYkaWVhCzYGS1zEa9V0z2MBxuEwgVUI+j3JsLvt6 0YtQ== X-Forwarded-Encrypted: i=1; AJvYcCWhzHcnjmwsMytgUN8CG/pZ+5pe94rdoKCUqaLWrQfwtuJFUXaRe+LGopeMftrMa8IwVF+2rF4744RBu+s=@vger.kernel.org X-Gm-Message-State: AOJu0YxWqKU8bzYgLmS7CFmVD1PLWRBYAkUxHmRYNtst+aCkl54TtzbB hAIhLEAhEuNSF/Ephc4xWtf1XpCLA//n/zZICCB7xkuDg4ccEhJ8hRWsilk/82M= X-Gm-Gg: ASbGncsugwkLnQy8RZGCy4NBnX+XNEVHv+gtpskLM9F+m1WLg3NDFpNydd/B5afQ5Cu 5nPEN59xQ6l6WP0AOUnB56fQwSqWHvn1AT/OeFnj59JNPBrDd5YvkmP45y0GANH3LjlNF1Rp0Bd X0QkXYde0XKhvY2NlXV5TY+CDN0Tr1P6ZhAz87ICOQs+xcaa8fy3j10Eo/f5aPM4A4QU2lNRPj7 OZeLyBgn31vrxstnUP8hKJ4X8n8ZwTf3Cy0LpHcxD25x6Qcl1j+/dN0g6jaKUUjXFcC2RZQqcuU iTF+kJp5BDJePZiXnh7MniOCihn8Qi6cvYGvMcsgcXCwVklaWCxeoByMgUK17nUprHZNHJQW+FI sD5gkX98= X-Google-Smtp-Source: AGHT+IGwWVFOLcxV0LkUngHq3HFjXHad4jOYWm8uX/RmfUfR8dI9IG0CksFEVnyNPrbp4SNz8LPd6Q== X-Received: by 2002:a17:907:94d1:b0:ac1:def4:ce20 with SMTP id a640c23a62f3a-ac20d8bc96fmr114851166b.18.1741136423329; Tue, 04 Mar 2025 17:00:23 -0800 (PST) Received: from ?IPV6:2001:67c:2fbc:1:2107:3d4f:958a:fa5f? ([2001:67c:2fbc:1:2107:3d4f:958a:fa5f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac1fa431529sm165373366b.148.2025.03.04.17.00.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Mar 2025 17:00:22 -0800 (PST) Message-ID: <71c1db26-f147-4578-89ae-c5b95da0ec9a@openvpn.net> Date: Wed, 5 Mar 2025 02:00:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v21 20/24] ovpn: implement key add/get/del/swap via netlink To: Sabrina Dubroca Cc: netdev@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Shuah Khan , ryazanov.s.a@gmail.com, Andrew Lunn , Simon Horman , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Xiao Liang References: <20250304-b4-ovpn-tmp-v21-0-d3cbb74bb581@openvpn.net> <20250304-b4-ovpn-tmp-v21-20-d3cbb74bb581@openvpn.net> <07c73e1d-3c9c-46c7-92cd-28d728929d18@openvpn.net> Content-Language: en-US From: Antonio Quartulli Autocrypt: addr=antonio@openvpn.net; keydata= xsFNBFN3k+ABEADEvXdJZVUfqxGOKByfkExNpKzFzAwHYjhOb3MTlzSLlVKLRIHxe/Etj13I X6tcViNYiIiJxmeHAH7FUj/yAISW56lynAEt7OdkGpZf3HGXRQz1Xi0PWuUINa4QW+ipaKmv voR4b1wZQ9cZ787KLmu10VF1duHW/IewDx9GUQIzChqQVI3lSHRCo90Z/NQ75ZL/rbR3UHB+ EWLIh8Lz1cdE47VaVyX6f0yr3Itx0ZuyIWPrctlHwV5bUdA4JnyY3QvJh4yJPYh9I69HZWsj qplU2WxEfM6+OlaM9iKOUhVxjpkFXheD57EGdVkuG0YhizVF4p9MKGB42D70pfS3EiYdTaKf WzbiFUunOHLJ4hyAi75d4ugxU02DsUjw/0t0kfHtj2V0x1169Hp/NTW1jkqgPWtIsjn+dkde dG9mXk5QrvbpihgpcmNbtloSdkRZ02lsxkUzpG8U64X8WK6LuRz7BZ7p5t/WzaR/hCdOiQCG RNup2UTNDrZpWxpwadXMnJsyJcVX4BAKaWGsm5IQyXXBUdguHVa7To/JIBlhjlKackKWoBnI Ojl8VQhVLcD551iJ61w4aQH6bHxdTjz65MT2OrW/mFZbtIwWSeif6axrYpVCyERIDEKrX5AV rOmGEaUGsCd16FueoaM2Hf96BH3SI3/q2w+g058RedLOZVZtyQARAQABzSdBbnRvbmlvIFF1 YXJ0dWxsaSA8YW50b25pb0BvcGVudnBuLm5ldD7Cwa0EEwEIAFcCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFCRWQ2TIWIQTKvaEoIBfCZyGYhcdI8My2j1nRTAUCYRUquBgYaGtwczov L2tleXMub3BlbnBncC5vcmcACgkQSPDMto9Z0UzmcxAAjzLeD47We0R4A/14oDKlZxXO0mKL fCzaWFsdhQCDhZkgxoHkYRektK2cEOh4Vd+CnfDcPs/iZ1i2+Zl+va79s4fcUhRReuwi7VCg 7nHiYSNC7qZo84Wzjz3RoGYyJ6MKLRn3zqAxUtFECoS074/JX1sLG0Z3hi19MBmJ/teM84GY IbSvRwZu+VkJgIvZonFZjbwF7XyoSIiEJWQC+AKvwtEBNoVOMuH0tZsgqcgMqGs6lLn66RK4 tMV1aNeX6R+dGSiu11i+9pm7sw8tAmsfu3kQpyk4SB3AJ0jtXrQRESFa1+iemJtt+RaSE5LK 5sGLAO+oN+DlE0mRNDQowS6q/GBhPCjjbTMcMfRoWPCpHZZfKpv5iefXnZ/xVj7ugYdV2T7z r6VL2BRPNvvkgbLZgIlkWyfxRnGh683h4vTqRqTb1wka5pmyBNAv7vCgqrwfvaV1m7J9O4B5 PuRjYRelmCygQBTXFeJAVJvuh2efFknMh41R01PP2ulXAQuVYEztq3t3Ycw6+HeqjbeqTF8C DboqYeIM18HgkOqRrn3VuwnKFNdzyBmgYh/zZx/dJ3yWQi/kfhR6TawAwz6GdbQGiu5fsx5t u14WBxmzNf9tXK7hnXcI24Z1z6e5jG6U2Swtmi8sGSh6fqV4dBKmhobEoS7Xl496JN2NKuaX jeWsF2rOwE0EZmhJFwEIAOAWiIj1EYkbikxXSSP3AazkI+Y/ICzdFDmiXXrYnf/mYEzORB0K vqNRQOdLyjbLKPQwSjYEt1uqwKaD1LRLbA7FpktAShDK4yIljkxhvDI8semfQ5WE/1Jj/I/Q U+4VXhkd6UvvpyQt/LiWvyAfvExPEvhiMnsg2zkQbBQ/M4Ns7ck0zQ4BTAVzW/GqoT2z03mg p1FhxkfzHMKPQ6ImEpuY5cZTQwrBUgWif6HzCtQJL7Ipa2fFnDaIHQeiJG0RXl/g9x3YlwWG sxOFrpWWsh6GI0Mo2W2nkinEIts48+wNDBCMcMlOaMYpyAI7fT5ziDuG2CBA060ZT7qqdl6b aXUAEQEAAcLBfAQYAQgAJhYhBMq9oSggF8JnIZiFx0jwzLaPWdFMBQJmaEkXAhsMBQkB4TOA AAoJEEjwzLaPWdFMbRUP/0t5FrjF8KY6uCU4Tx029NYKDN9zJr0CVwSGsNfC8WWonKs66QE1 pd6xBVoBzu5InFRWa2ed6d6vBw2BaJHC0aMg3iwwBbEgPn4Jx89QfczFMJvFm+MNc2DLDrqN zaQSqBzQ5SvUjxh8lQ+iqAhi0MPv4e2YbXD0ROyO+ITRgQVZBVXoPm4IJGYWgmVmxP34oUQh BM7ipfCVbcOFU5OPhd9/jn1BCHzir+/i0fY2Z/aexMYHwXUMha/itvsBHGcIEYKk7PL9FEfs wlbq+vWoCtUTUc0AjDgB76AcUVxxJtxxpyvES9aFxWD7Qc+dnGJnfxVJI0zbN2b37fX138Bf 27NuKpokv0sBnNEtsD7TY4gBz4QhvRNSBli0E5bGUbkM31rh4Iz21Qk0cCwR9D/vwQVsgPvG ioRqhvFWtLsEt/xKolOmUWA/jP0p8wnQ+3jY6a/DJ+o5LnVFzFqbK3fSojKbfr3bY33iZTSj DX9A4BcohRyqhnpNYyHL36gaOnNnOc+uXFCdoQkI531hXjzIsVs2OlfRufuDrWwAv+em2uOT BnRX9nFx9kPSO42TkFK55Dr5EDeBO3v33recscuB8VVN5xvh0GV57Qre+9sJrEq7Es9W609a +M0yRJWJEjFnMa/jsGZ+QyLD5QTL6SGuZ9gKI3W1SfFZOzV7hHsxPTZ6 Organization: OpenVPN Inc. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/03/2025 00:09, Sabrina Dubroca wrote: > 2025-03-04, 13:11:28 +0100, Antonio Quartulli wrote: >> On 04/03/2025 13:00, Sabrina Dubroca wrote: >>> 2025-03-04, 01:33:50 +0100, Antonio Quartulli wrote: >>>> int ovpn_nl_key_new_doit(struct sk_buff *skb, struct genl_info *info) >>>> { >>> ... >>>> + pkr.slot = nla_get_u8(attrs[OVPN_A_KEYCONF_SLOT]); >>>> + pkr.key.key_id = nla_get_u16(attrs[OVPN_A_KEYCONF_KEY_ID]); >>>> + pkr.key.cipher_alg = nla_get_u16(attrs[OVPN_A_KEYCONF_CIPHER_ALG]); >>> >>> >>> [...] >>>> +static int ovpn_nl_send_key(struct sk_buff *skb, const struct genl_info *info, >>>> + u32 peer_id, enum ovpn_key_slot slot, >>>> + const struct ovpn_key_config *keyconf) >>>> +{ >>> ... >>>> + if (nla_put_u32(skb, OVPN_A_KEYCONF_SLOT, slot) || >>>> + nla_put_u32(skb, OVPN_A_KEYCONF_KEY_ID, keyconf->key_id) || >>>> + nla_put_u32(skb, OVPN_A_KEYCONF_CIPHER_ALG, keyconf->cipher_alg)) >>> >>> That's a bit inconsistent. nla_put_u32 matches the generated policy, >>> but the nla_get_u{8,16} don't (and nla_get_u16 also doesn't match "u8 >>> key_id" it's getting stored into). >>> >>> [also kind of curious that the policy/spec uses U32 with max values of 1/2/7] >> >> From https://www.kernel.org/doc/html/next/userspace-api/netlink/specs.html#fix-width-integer-types >> >> "Note that types smaller than 32 bit should be avoided as using them does >> not save any memory in Netlink messages (due to alignment)." >> >> Hence I went for u32 attributes, although values stored into them are much >> smaller. > > Right. What's wrong with key_id being u8 tough? I am a bit reluctant to change all key_id fields/variables to u32, just because the netlink APIs prefers using u32 instead of u8. Keeping variables/fields u8 allows to understand what values we're going to store internally. And thanks to the netlink policy we know that no larger value will be attempted to be saved, even if the field is actually u32. Cheers, -- Antonio Quartulli OpenVPN Inc.