From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751828AbdIVEG2 (ORCPT ); Fri, 22 Sep 2017 00:06:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43938 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbdIVEG1 (ORCPT ); Fri, 22 Sep 2017 00:06:27 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DA58F882FB Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jasowang@redhat.com Subject: Re: [PATCH net-next 3/3] virtio-net: support XDP_REDIRECT To: John Fastabend , mst@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1505814163-7315-1-git-send-email-jasowang@redhat.com> <1505814163-7315-3-git-send-email-jasowang@redhat.com> <59C2E588.6060203@gmail.com> From: Jason Wang Message-ID: <71c435e1-1a2a-014c-97fc-34469c487a2d@redhat.com> Date: Fri, 22 Sep 2017 12:06:20 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <59C2E588.6060203@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 22 Sep 2017 04:06:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年09月21日 06:02, John Fastabend wrote: > On 09/19/2017 02:42 AM, Jason Wang wrote: >> This patch tries to add XDP_REDIRECT for virtio-net. The changes are >> not complex as we could use exist XDP_TX helpers for most of the >> work. The rest is passing the XDP_TX to NAPI handler for implementing >> batching. >> >> Cc: John Fastabend >> Signed-off-by: Jason Wang >> --- > [...] > >> @@ -678,12 +711,20 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, >> } >> break; >> case XDP_TX: >> - if (unlikely(!virtnet_xdp_xmit(vi, &xdp))) >> + if (unlikely(!__virtnet_xdp_xmit(vi, &xdp))) >> trace_xdp_exception(vi->dev, xdp_prog, act); >> + else >> + *xdp_xmit = true; >> if (unlikely(xdp_page != page)) >> goto err_xdp; >> rcu_read_unlock(); >> goto xdp_xmit; >> + case XDP_REDIRECT: >> + err = xdp_do_redirect(dev, &xdp, xdp_prog); >> + if (err) >> + *xdp_xmit = true; > Is this a typo? Should above be > > if (!err) > *xdp_xmit = true; > > this would match the pattern in receive_small and also make more sense. Right, will post a fix. > >> + rcu_read_unlock(); >> + goto xdp_xmit; >> default: >> bpf_warn_invalid_xdp_action(act); >> case XDP_ABORTED: >> @@ -788,7 +829,7 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, >> } >> > [...] > > Otherwise looks good to me thanks for doing this. > > .John > Thanks for the reviewing.