mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Sa, Nuno" <Nuno.Sa@analog.com>,
	"Olivier Moysan" <olivier.moysan@foss.st.com>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Schmitt, Marcelo" <Marcelo.Schmitt@analog.com>,
	"Mike Looijmans" <mike.looijmans@topic.nl>,
	"Marius Cristea" <marius.cristea@microchip.com>,
	"Dumitru Ceclan" <mitrutzceclan@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Alisa-Dariana Roman" <alisadariana@gmail.com>,
	"Ivan Mikhaylov" <fr0st61te@gmail.com>,
	"Cuciurean, Sergiu" <Sergiu.Cuciurean@analog.com>,
	"Bogdan, Dragos" <Dragos.Bogdan@analog.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH v2 6/7] iio: adc: ad485x: add ad485x driver
Date: Thu, 10 Oct 2024 12:05:11 -0500	[thread overview]
Message-ID: <71c4a073-1b5e-42d3-8fee-a2a5215d5856@baylibre.com> (raw)
In-Reply-To: <CY4PR03MB33992F19FF780FF86234426A9B7E2@CY4PR03MB3399.namprd03.prod.outlook.com>

On 10/8/24 5:48 AM, Miclaus, Antoniu wrote:
>>> +static int ad485x_get_calibscale(struct ad485x_state *st, int ch, int *val, int
>> *val2)
>>> +{
>>> +       unsigned int reg_val;
>>> +       int gain;
>>
>> Should be u8 gain[2] and...
> 
> As discussed in previous patch series, the bulk operations won't work for these
> chips. The CS needs to be raised between each byte read/written.
> 

So the datasheet is wrong and Streaming Instruction Mode doesn't actually work?

There is also Nonstreaming Instruction Mode if we need to read/write nonconsecutive
registers without deasserting CS.


  parent reply	other threads:[~2024-10-10 17:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 14:07 [PATCH v2 1/7] iio: backend: add API for interface get Antoniu Miclaus
2024-10-04 14:07 ` [PATCH v2 2/7] iio: backend: add support for data size set Antoniu Miclaus
2024-10-04 14:07 ` [PATCH v2 3/7] iio: adc: adi-axi-adc: add interface type Antoniu Miclaus
2024-10-04 14:07 ` [PATCH v2 4/7] iio: adc: adi-axi-adc: set data format Antoniu Miclaus
2024-10-04 14:07 ` [PATCH v2 5/7] dt-bindings: iio: adc: add ad485x Antoniu Miclaus
2024-10-04 15:18   ` Conor Dooley
2024-10-05 16:04   ` David Lechner
2024-10-05 17:07   ` Jonathan Cameron
2024-10-04 14:07 ` [PATCH v2 6/7] iio: adc: ad485x: add ad485x driver Antoniu Miclaus
2024-10-05 17:34   ` Jonathan Cameron
2024-10-05 18:53   ` Andy Shevchenko
2024-10-08 10:48     ` Miclaus, Antoniu
2024-10-08 15:57       ` Andy Shevchenko
2024-10-10 17:05       ` David Lechner [this message]
2024-10-11 11:27         ` Miclaus, Antoniu
2024-10-11 13:47           ` David Lechner
2024-10-08 11:37     ` Miclaus, Antoniu
2024-10-08 15:58       ` Andy Shevchenko
2024-10-07 18:18   ` kernel test robot
2024-10-09  7:50   ` Uwe Kleine-König
2024-10-04 14:07 ` [PATCH v2 7/7] Documentation: ABI: testing: ad485x: add ABI docs Antoniu Miclaus
2024-10-05 17:36   ` Jonathan Cameron
2024-10-11 12:24     ` Nuno Sá
2024-10-05 16:49 ` [PATCH v2 1/7] iio: backend: add API for interface get David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71c4a073-1b5e-42d3-8fee-a2a5215d5856@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=Antoniu.Miclaus@analog.com \
    --cc=Dragos.Bogdan@analog.com \
    --cc=Marcelo.Schmitt@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=Nuno.Sa@analog.com \
    --cc=Sergiu.Cuciurean@analog.com \
    --cc=alisadariana@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fr0st61te@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=marius.cristea@microchip.com \
    --cc=mike.looijmans@topic.nl \
    --cc=mitrutzceclan@gmail.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=robh@kernel.org \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®