From: Sven Stegemann <sven@stegemann.de>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+e62c9db591c30e174662@syzkaller.appspotmail.com,
syzbot+d199b52665b6c3069b94@syzkaller.appspotmail.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next] net: kcm: Fix race condition in kcm_unattach()
Date: Tue, 12 Aug 2025 21:27:00 +0200 [thread overview]
Message-ID: <71c79b47-d44f-45da-9558-770690addb79@stegemann.de> (raw)
In-Reply-To: <194e4774-a931-4ce4-af63-4610da7c4350@redhat.com>
On 8/12/2025 2:54 PM, Paolo Abeni wrote:
> On 8/9/25 8:36 AM, Sven Stegemann wrote:
>> @@ -1714,6 +1708,7 @@ static int kcm_release(struct socket *sock)
>> /* Cancel work. After this point there should be no outside references
>> * to the kcm socket.
>> */
>> + disable_work(&kcm->tx_work);
>> cancel_work_sync(&kcm->tx_work);
>
> The patch looks functionally correct, but I guess it would be cleaner
> simply replacing:
>
> cancel_work_sync(&kcm->tx_work);
>
> with:
>
> disable_work_sync(&kcm->tx_work);
Thank you, that's a good point.
I just submitted a cleaned up version of the patch.
prev parent reply other threads:[~2025-08-12 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 6:36 Sven Stegemann
2025-08-09 7:25 ` Sven Stegemann
2025-08-09 7:56 ` Hillf Danton
2025-08-09 11:08 ` [syzbot] [net?] WARNING: ODEBUG bug in __sk_destruct (3) syzbot
2025-08-12 12:54 ` [PATCH net-next] net: kcm: Fix race condition in kcm_unattach() Paolo Abeni
2025-08-12 19:27 ` Sven Stegemann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71c79b47-d44f-45da-9558-770690addb79@stegemann.de \
--to=sven@stegemann.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+d199b52665b6c3069b94@syzkaller.appspotmail.com \
--cc=syzbot+e62c9db591c30e174662@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®