From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D74C433EF for ; Thu, 14 Jul 2022 12:33:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239250AbiGNMdN (ORCPT ); Thu, 14 Jul 2022 08:33:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239014AbiGNMdL (ORCPT ); Thu, 14 Jul 2022 08:33:11 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EC15D42AEF for ; Thu, 14 Jul 2022 05:33:10 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2EFC813D5; Thu, 14 Jul 2022 05:33:11 -0700 (PDT) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 83B333F792; Thu, 14 Jul 2022 05:33:09 -0700 (PDT) Message-ID: <71c7d48c-8ce8-9d43-d578-2a3c15dbd64b@arm.com> Date: Thu, 14 Jul 2022 14:33:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 06/10] sched/fair: delete superfluous SKIP_AGE_LOAD Content-Language: en-US To: Chengming Zhou , mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org References: <20220713040430.25778-1-zhouchengming@bytedance.com> <20220713040430.25778-7-zhouchengming@bytedance.com> From: Dietmar Eggemann In-Reply-To: <20220713040430.25778-7-zhouchengming@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/07/2022 06:04, Chengming Zhou wrote: > There are three types of attach_entity_cfs_rq(): > > 1. task migrate to CPU > 2. task move to cgroup > 3. task switched to fair from !fair > > The case1 and case2 already have sched_avg last_update_time > reset to 0 when attach_entity_cfs_rq(). > > We will make case3 also have last_update_time reset to 0 when > attach_entity_cfs_rq() in the following patches. > > So it makes no difference whether SKIP_AGE_LOAD is set or not. Wouldn't this patch make more sense after 09/10? [...]