From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 366C93D3D02 for ; Thu, 16 Jul 2026 22:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784240171; cv=none; b=RMiWui1O+95VE/m/i0lhaCxLIlLDEQmcXeIHsIJWvUwnm3lV1J7Z79CPTAy+80dRB+pyA4546MqySBYOtk3sA6PP2+aNHpkM2Ka+74RvSb81X2G8IN6eyx4BL8171cVM52lqS8tFhxtHdcque5+2ow92NA4Kmm6GfIBDt1AcYPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784240171; c=relaxed/simple; bh=nVcYram5qpUVW7KgNAVqxKC45xcHyj3dMYgE2oW7dlk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZCPruCy0fBTGl4eHvB8Z3yvubQKwlQ2Am2NPZKky4i7AFeZhuB1UtUGDnRYiNHjSwgv2uuPByF4A1/XFYZDcwNjq+XijYInMeoLmbek8fT/Q4BzN4KOyvNCSc/9gD5gOo4wtoIPtUvNo94YnNaaa6bbI+IpsjVo8J2x/OHgS6uw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ghDfFKCb; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ghDfFKCb" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-4566a5bc186so599023fac.1 for ; Thu, 16 Jul 2026 15:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1784240168; x=1784844968; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=g1sBmXlOpVH98WdcMMDI8e0pxb+Bu4b2dLUtCYrsF68=; b=ghDfFKCbau3DOaQ/h9B/Ze4QQJCFSSf4qcfRdbBuZePEZiEBdzBE6Nub9Bn3hc1VOc bxEi/yqjUQKXzfXe6xYFNYPIrb7zFmhrRqsEBTD726s5QRUanv6akDKQOiF44A7b4oQw 2BhT9eJ7/RkRI0RncZOhqTpXKRIfex0DkokCs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784240168; x=1784844968; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=g1sBmXlOpVH98WdcMMDI8e0pxb+Bu4b2dLUtCYrsF68=; b=CUKkJF//YaAW5NvPoY0HIC7D6JV5v41yLey61+BL0iGTS6GJyQMKjOTfvh0K/tvHXu HR3OzAqjurCe6NZ6ME1hJKi2yRqQkNyfc/Uem1Sv07nJNmJ0K4bEz+7+qHhNTYFLvtZG HVyz7b5lk0+52K0zRAzoODJewvbCt0hEpGCdXmeXoaX5uVE6KXkxl3kbyqYK5WSnYCjl F3Qwk4G7qX6KGzz6bwFFXvYNZgf14F8nhXb0A19A5vWw5D1aJ740f87usMhtnUvzzeLP w/cvriM11KrrdP7dzzxnUCSWzcGuriSW/NSspe+isHb49qitqIjsKFYYivDocM7Vz9OE 1YJQ== X-Forwarded-Encrypted: i=1; AHgh+Rq2ejk57AbngMAJosgBzlOzQccOhgdpnhS2OSHkk24TMntP4MJsCJaU0sGZOGLQ2S+aqsj91HGpyqVkTwk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7xoX/kLtRTjOJIsefA/ZOKtG45YU+yqiKVsky8nhxwB9o6MID cnqc2GNXpPEqaqjKq6n20pP8vVlgQZEkZPOHoDo/kCxtdEd+bG8ZWz885JXLZFOQCKg= X-Gm-Gg: AfdE7ckD+defUj0EUX4bbZMJ1VyAsdNuVNtyZ+X/g5xvEyw+BoFIrDUM4WU+2V9c0pM W1v2zsR5+FxafBWQ088Xp08k0PCzarFkd+Thgx+6HEk6dTy4ElfPUz4wL1B0Z3zL8c4Ofw4cWe0 p3EmNk8M7LCFtVqwLMKqGMaFkabJpF0Blv9XtH8F/pnP7mLaiGZuba5J9ORfSkDf0RYQ1nEBRdd 1CZOqBg7zA7tJbTsk6g81csgjoQ/HzPmwCq0aFWqOfe9Ing1M8XOlUvyTJajnO5hgBf5SgHMT5/ rYwqUVcAqnREKwp3a74VY2zxBbk640mW7b+8P3aonK3ykmfvX9zEZ6swr7rmjl6N4+9Ovah6e0U L8j0Ti+MMzHFQtOED8ySX9h1nNXuPcnT0z6zPZV57I7iYQO6QN6f9Cf1hSu5GlmHS2lmw+EwXrc Y8x0gqjxmgRPQ= X-Received: by 2002:a05:6870:950d:b0:455:c1d1:9cc0 with SMTP id 586e51a60fabf-456828aadadmr731648fac.19.1784240167924; Thu, 16 Jul 2026 15:16:07 -0700 (PDT) Received: from [192.168.1.128] ([38.15.57.99]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-455ad91df9esm14010377fac.9.2026.07.16.15.16.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 15:16:07 -0700 (PDT) Message-ID: <71c8ae0d-cc20-4b99-92c6-69641b2a0f85@linuxfoundation.org> Date: Thu, 16 Jul 2026 16:16:04 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cpupower: Fix NULL pointer dereference on allocation failure To: Malaya Kumar Rout , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: mrout@redhat.com, me@brighamcampbell.com, Thomas Renninger , Shuah Khan , "John B. Wyatt IV" , John Kacur , Brahadambal Srinivasan , Shuah Khan References: <20260704084303.86113-1-malayarout91@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260704084303.86113-1-malayarout91@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/4/26 02:43, Malaya Kumar Rout wrote: > The bitmask_alloc() function can return NULL if memory allocation fails, > but the code in main() does not check the return values before using the > allocated bitmasks. This can lead to a NULL pointer dereference when > bitmask_setall() or bitmask_parselist() is called with NULL pointers. > > Add proper NULL checks after bitmask allocations and exit gracefully with > an error message if allocation fails. > > Fixes: 748f0d70087c ("cpupower: Provide online and offline CPU information") > Signed-off-by: Malaya Kumar Rout > --- > tools/power/cpupower/utils/cpupower.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/tools/power/cpupower/utils/cpupower.c b/tools/power/cpupower/utils/cpupower.c > index 9ec973165af1..8f7b18b8bb43 100644 > --- a/tools/power/cpupower/utils/cpupower.c > +++ b/tools/power/cpupower/utils/cpupower.c > @@ -184,6 +184,17 @@ int main(int argc, const char *argv[]) > online_cpus = bitmask_alloc(sysconf(_SC_NPROCESSORS_CONF)); > offline_cpus = bitmask_alloc(sysconf(_SC_NPROCESSORS_CONF)); > > + if (!cpus_chosen || !online_cpus || !offline_cpus) { > + fprintf(stderr, _("Failed to allocate bitmasks\n")); > + if (cpus_chosen) > + bitmask_free(cpus_chosen); > + if (online_cpus) > + bitmask_free(online_cpus); > + if (offline_cpus) > + bitmask_free(offline_cpus); > + return EXIT_FAILURE; > + } > + > argc--; > argv += 1; > Usually these small allocations don't fail to warrant checks. thanks, -- Shuah