From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F8C228D831 for ; Fri, 9 May 2025 09:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746783953; cv=none; b=d4NjeQ95Es2fDvi5B+5LOOz5E+PFA3ul98uPwzP5iidWBwttsO2SS+yBcP5ndrjO3EY/beMmgorGBdwEkyZlEBEiUqCmxaWI/QVcz1CNKV2sZ1vwwGRYH6SY8TbUfBpOxFn/Du1t5R9dKKm0Xmo0bWAnMd8myFOu18epMRAmVL4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746783953; c=relaxed/simple; bh=vEzeCbOr7rTbW3vMJ3X1Zk3anzpiN0GrGnLgFbq6fqc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jnCNJObYxQIslDu5fcLwoX3ponJpm1KAEBsvJBLoQ8DehLE6FkFSlN2y9vuX2L/6pv55gFOvHTaJHkhWcaSwWbfBoT+tocQK2lWtx2iFerKoXAxh+pxrWnxNUccDuLVpGTWIaVFPOzgda5euR8QF3+hQvfbJLbQf5KRSqlJDufs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e2tLwoeA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e2tLwoeA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746783950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bu/8JLoeCoD1WqiQs57tUFU7TywIqe2UBHBIdfA/PFw=; b=e2tLwoeA/CSp3LNGIdBOhtqMdyVUDJY2F/Thxi03Q+CWIV+BtSPEmLgChVLF0us0khwwOf MvaEhkIN40bnU/n1hM6iYEaDIGq2lUpX2ssIefZpBg024b3ZBjkKI0/D2YzTnCApYhYrly nh3ChDVdao9f3UsZEi0HdYjeg/V9WjY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-BH4aIRRZNAyDXfgJ3YC9pQ-1; Fri, 09 May 2025 05:45:48 -0400 X-MC-Unique: BH4aIRRZNAyDXfgJ3YC9pQ-1 X-Mimecast-MFC-AGG-ID: BH4aIRRZNAyDXfgJ3YC9pQ_1746783947 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39c1b1c0969so1148142f8f.1 for ; Fri, 09 May 2025 02:45:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746783947; x=1747388747; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bu/8JLoeCoD1WqiQs57tUFU7TywIqe2UBHBIdfA/PFw=; b=sJu2LW4UnJgNOMQtlThhqapxE4XRhP1QxRXHwJ9ZvgXbcmazfYLncWkVvEsnMdirhS 6uYFR/TQqj8k8KD+TD3PcoZZ+K8M6IXSpm+xm+SNejp8+Kf8mCDjpOOqyQahfyAmC+yR yigO0Sqb8X7Ci6WzqeNQDRjZJ9QRS+ifvCRb/u6JSZf82J3Chcv21tSoLFBgJHK/r1Es WnqKGaqVBPHMafl4U7iH1pm7UN1Ocsc+IJqs3jX4yT1/CIE3h9whddByrXxpiccM6kbq tltSo10xoz7+MlfY1cH0pNkNEbPtfEOlnQ/BXezTZK3C33l7CTvHX9HVupQ78PZu9Rmk 2uFQ== X-Forwarded-Encrypted: i=1; AJvYcCUnqnURUPBpE7ZoxqYllz8gD0HYJlRr+n3C1MFndDuF/uQg3a5QiRCSMLzX+06BW7fC8SYeIYhRAfNp/i8=@vger.kernel.org X-Gm-Message-State: AOJu0YyAkr5QPgz7x8eW2GtC9xKo8IhALSZ19zDUmBJD5sx28u2rUDYS KUNZHiGMuMr2nKahafA4TIPiQA61mIJxhVJzu8FvTQyY51GFSs5h1clpm9FDm4sznSjhnmdacnk Ma+j4Vuw2xQK4KVC1V6MnKcAPXfY2eVQs9aMGehY6GTD8LkrPb3XfUZbvRLKWLg== X-Gm-Gg: ASbGnctDohyBuR5jzPJeciS/tpkv7i1bpHnWDgE+YClaqymqNNCYfoi8hoD8hRNTXQh mYQGoc9z/IrEkDzmkaxNp4Yhaa9xI8XAeNV6vphaOkCTDfGnpDX0BVPR16suzOFIr1X6FMdBU0e nFyFBWhKOJnSVNj7+u1OVJs7rEKB/6yaEXtGOTJ18uRbjSlnr7IZ/NxxBD52bO1LM+V86KULqmS mcDMIX3wVNgF39K99l5OH2UcxMD3u3NMzkn5dBQeN3GSjJvS7zqvLwv4KzcWiyQ3pBC/I206IHt 200QIjvPjOd5CBMrS9pTcRAbCVaNThYB3RWoILMHqVCh059SL6wN3t4IwmlfyB68dec4MFYEFo1 1pxKjqYtVPVj1diqNEGtOFqdgapM7cSRE1BciSNE= X-Received: by 2002:a05:6000:3107:b0:39e:db6a:4744 with SMTP id ffacd0b85a97d-3a1f646d9abmr2212125f8f.32.1746783947559; Fri, 09 May 2025 02:45:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEqWyAH3LOt/3cZP9Rvihrl0+ejLa3IRZjY7TLv9wiabkFRe6nuDbo+0JpbmOS1yW5BiT5eqA== X-Received: by 2002:a05:6000:3107:b0:39e:db6a:4744 with SMTP id ffacd0b85a97d-3a1f646d9abmr2212107f8f.32.1746783947216; Fri, 09 May 2025 02:45:47 -0700 (PDT) Received: from ?IPV6:2003:d8:2f45:5500:8267:647f:4209:dedd? (p200300d82f4555008267647f4209dedd.dip0.t-ipconnect.de. [2003:d8:2f45:5500:8267:647f:4209:dedd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f57de087sm2762774f8f.16.2025.05.09.02.45.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 02:45:46 -0700 (PDT) Message-ID: <71cb8335-ad53-409a-b947-d7ded8a3ef02@redhat.com> Date: Fri, 9 May 2025 11:45:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] mm/vma: remove mmap() retry merge To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , Matthew Wilcox References: From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07.05.25 13:03, Lorenzo Stoakes wrote: > We have now introduced a mechanism that obviates the need for a reattempted > merge via the mmap_prepare() file hook, so eliminate this functionality > altogether. > > The retry merge logic has been the cause of a great deal of complexity in > the past and required a great deal of careful manoeuvring of code to ensure > its continued and correct functionality. > > It has also recently been involved in an issue surrounding maple tree > state, which again points to its problematic nature. > > We make it much easier to reason about mmap() logic by eliminating this and > simply writing a VMA once. This also opens the doors to future optimisation > and improvement in the mmap() logic. > > For any device or file system which encounters unwanted VMA fragmentation > as a result of this change (that is, having not implemented .mmap_prepare > hooks), the issue is easily resolvable by doing so. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb