mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hanjun Guo <guohanjun@huawei.com>
To: Will Deacon <will@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-acpi@vger.kernel.org>,
	Pavan Kondeti <pavan.kondeti@oss.qualcomm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH] ACPI: GTDT: Correctly number platform devices for MMIO timers
Date: Sat, 29 Nov 2025 14:02:34 +0800	[thread overview]
Message-ID: <71cbdfbc-9281-b0d8-1590-ac666f4f5194@huawei.com> (raw)
In-Reply-To: <aShpQ4iDceJ7-Nzs@willie-the-truck>

Hi Will,

On 2025/11/27 23:07, Will Deacon wrote:
> Hey Hanjun,
> 
> On Fri, Nov 21, 2025 at 09:14:04PM +0800, Hanjun Guo wrote:
>> On 2025/11/21 16:55, Marc Zyngier wrote:
>>> On Fri, 21 Nov 2025 02:53:17 +0000,
>>> Hanjun Guo <guohanjun@huawei.com> wrote:
>>>>
>>>> On 2025/10/30 19:01, Marc Zyngier wrote:
>>>>> Use the actual timer counter instead of the watchdog counter.
>>>>>
>>>>> Fixes: 5669d92f3efa4 ("ACPI: GTDT: Generate platform devices for MMIO timers")
>>>>> Reported-by: Pavan Kondeti <pavan.kondeti@oss.qualcomm.com>
>>>>> Signed-off-by: Marc Zyngier <maz@kernel.org>
>>>>> Cc: Hanjun Guo <guohanjun@huawei.com>
>>>>> Cc: Sudeep Holla <sudeep.holla@arm.com>
>>>>> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
>>>>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>>>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>>>> Cc: Mark Rutland <mark.rutland@arm.com>
>>>>> ---
>>>>>     drivers/acpi/arm64/gtdt.c | 4 ++--
>>>>>     1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
>>>>> index fd995a1d3d248..8cc8af8fd408c 100644
>>>>> --- a/drivers/acpi/arm64/gtdt.c
>>>>> +++ b/drivers/acpi/arm64/gtdt.c
>>>>> @@ -430,10 +430,10 @@ static int __init gtdt_platform_timer_init(void)
>>>>>     				continue;
>>>>>       			pdev = platform_device_register_data(NULL,
>>>>> "gtdt-arm-mmio-timer",
>>>>> -							     gwdt_count, &atm,
>>>>> +							     mmio_timer_count, &atm,
>>>>>     							     sizeof(atm));
>>>>>     			if (IS_ERR(pdev)) {
>>>>> -				pr_err("Can't register timer %d\n", gwdt_count);
>>>>> +				pr_err("Can't register timer %d\n", mmio_timer_count);
>>>>>     				continue;
>>>>>     			}
>>>>
>>>> "typo" I think :)
>>>>
>>>> Acked-by: Hanjun Guo <guohanjun@huawei.com>
>>>>
>>>> Will this go via ARM64 tree?
>>>
>>> Is that where the ACPI updates are routed to? This fixes a patch that
>>> was routed tip, so I'd have expected this to go via the same route.
>>>
>>> In any case, I've added Catalin and Will on Cc.
>>
>> Yes, ARM64 ACPI code merged via ARM64 tree.
> 
> Catalin and I were chatting the other day and we wondered whether it's
> worth adding something to MAINTAINERS so that we get CC'd on arm64 ACPI
> patches without you having to add us in manually? We wouldn't merge
> anything without an Ack from somebody listed under the "ACPI FOR ARM64"
> entry but it would mean that we get picked up by get_maintainer.pl.
> 
> What do you think?

Looks great to me!

> 
> I can't tell whether this would be best as an F: line under the arm64
> architecture entry, or adding us as R:/M: for the ACPI/arm64 entry.

How about adding M: for the ACPI/arm64 entry? I can send a patch
for this change if you and Catalin agree with it.

Thanks
Hanjun

  reply	other threads:[~2025-11-29  6:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-30 11:01 Marc Zyngier
2025-11-20 13:58 ` Marc Zyngier
2025-11-21  2:53 ` Hanjun Guo
2025-11-21  8:55   ` Marc Zyngier
2025-11-21 13:14     ` Hanjun Guo
2025-11-27 15:07       ` Will Deacon
2025-11-29  6:02         ` Hanjun Guo [this message]
2025-12-01 13:34           ` Will Deacon
2025-11-24 14:41 ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71cbdfbc-9281-b0d8-1590-ac666f4f5194@huawei.com \
    --to=guohanjun@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=pavan.kondeti@oss.qualcomm.com \
    --cc=rafael@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®