From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6AFC241CA2; Tue, 15 Apr 2025 10:57:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744714641; cv=none; b=H4hUz3hy3YnIKtg4t+n/8aNdMchOE/a+7FT1EXLQ1/1AsVEvfy+XxIsBDzQd4TvQn+G/lOXjem7z5r77WmW1DtP7lUTe5zF4zSOmQG9EQl/m8lMpHNaeKPH1onyjfrPpFXSRNIQdGspefSkW3y+FoUlndA+u5W8Z2vsUCNRNiXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744714641; c=relaxed/simple; bh=I4v2Dk3UXXCfyD10RjI9laeeZkWMimGScChJK688VCE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DlgOsKF1Nnqu5oGucgdEIkNgx+3nY1Xk7FzxoMqOzS8cGUMh4jTjOOMASwso4HOWLA9hg3D64jIgfaWiX2fa/VDhR20hRxac1HMcp8YcSoTolNQ3cdjGyBGQ7GwYKTdvW73Z7m/mcS1ASz8DrNdNX7NBpUIXh+s0+bX19+HCZBw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=os9JNntI; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="os9JNntI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1744714638; bh=I4v2Dk3UXXCfyD10RjI9laeeZkWMimGScChJK688VCE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=os9JNntIE8193OeW6CQMrCMc8/CUvgVYvmEzYGxuN95MMzFM5t5niYaZgYnfFl7W0 TqKcv5Nug8q8ZKutEzdoSAtZIpJdETZZa71/3h3Dw6lai6zmplII4OphofJwgx0VJk W4yx5o1p8Doh0ocJoy84PFrtW2EYQ2EHEIkHTQyxX3nJJMwoDITgiOI5bmKJeQhUUQ OlODgGe8c1XdZN69zlA/Fghhlicp8ZBcD2u/oakoDIeZAAfMq4fGMXUysc24FejvWx rlZxRPFzs/xZnzlw8p+w2sm44d4QxsuBEsA7iUkTf6CIbZmpvz4bZGPiEeUbYMjwhq 6ACYLBwKhzM9Q== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 590C017E03B6; Tue, 15 Apr 2025 12:57:17 +0200 (CEST) Message-ID: <71cc71a2-7872-419f-8413-dba3b7313894@collabora.com> Date: Tue, 15 Apr 2025 12:57:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: mediatek: mt7988a-bpi-r4: allow hw variants of bpi-r4 To: frank-w@public-files.de, Daniel Golle Cc: Frank Wunderlich , Matthias Brugger , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org References: <20250412102109.101094-1-linux@fw-web.de> <36fe0778-399a-4406-8516-54b968cd9073@collabora.com> <8fe762e3-a9eb-4a9c-81a2-b7a10539b615@collabora.com> <48DEC6CC-A81B-4DD7-9F55-CA1179FBA2F2@public-files.de> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <48DEC6CC-A81B-4DD7-9F55-CA1179FBA2F2@public-files.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 15/04/25 12:30, Frank Wunderlich ha scritto: > Am 15. April 2025 11:56:37 MESZ schrieb AngeloGioacchino Del Regno : >> Il 15/04/25 10:07, Frank Wunderlich ha scritto: >>> Am 15. April 2025 09:36:43 MESZ schrieb AngeloGioacchino Del Regno : >>>> Il 14/04/25 14:32, Daniel Golle ha scritto: >>>>> On Mon, Apr 14, 2025 at 11:27:23AM +0200, AngeloGioacchino Del Regno wrote: >>>>>> Il 12/04/25 12:21, Frank Wunderlich ha scritto: >>>>>>> From: Frank Wunderlich >>>>>>> >>>>>>> Sinovoip has released other variants of Bananapi-R4 board. >>>>>>> The known changes affecting only the LAN SFP+ slot which is replaced >>>>>>> by a 2.5G phy with optional PoE. >>>>>>> >>>>>>> Just move the common parts to a new dtsi and keep differences (only >>>>>>> i2c for lan-sfp) in dts. >>> >>>>>> This should at least have some different compatible, if not probably also a >>>>>> different model string - as it's a different device. >>>>>> >>>>>> compatible = "bananapi,bpi-r4-2g5", "bananapi,bpi-r4", "mediatek,mt7988a"; >>>>> >>>>> Imho it doesn't make sense to declare compatibility with the >>>>> "bananapi,bpi-r4" as the "bananapi,bpi-r4-2g5" is NOT compatible with the >>>>> "bananapi,bpi-r4". It's a different board and using firmware meant for the >>>>> "bananapi,bpi-r4-2g5" on the "bananapi,bpi-r4" (or vice versa) will result >>>>> in a non-working Ethernet port. >>>>> >>>> >>>> Is this device a BananaPi R4 variant, or is it a completely different device? >>> >>> The only difference is that sfp-lan is replaced by RJ45 socket with mt7988 internal phy. >>> >> >> Perfect, then: >> - The only difference is one routing >> - The base board is the same >> - Same hw project >> - The two machines are compatible with each other >> ...bar one difference >> >> ...then the compatibles shall be as I said before :-) >> >>>> If this is a completely different device, then it's not even a BananaPi R4, >>>> otherwise this is compatible with BananaPi R4, with a small variation :-) >>> >>> Sinovoip now announces a R4Pro with some more changes (e.g. an external 2.5g switch),but we have no detailed shematic yet. It looks they also plan a R4lite which is based on different SoC (afair mt7987),but this is for sure different device (and so not using this bpi-r4.dtsi). >> >> In that case, R4Lite shall not be compatible with R4, as the name may be the >> same, but in practice it's a different machine. >> >>> >>> But basicly all are named BPi-R4. I guess R4Pro will also get own dts as too much changed. >> >> If R4pro is a redesign of the R4 board, that would not be compatible, as it >> would not be the same base design; otherwise, I'm sure you have well understood >> how it works for the compatibles, anyway :D > > Yes, should i use 3 const in the binding (as i do not expect another hw variant of current R4) or still enum for the first compatible? Use 3 consts please :-) Besides, if a variant comes up later, we can always change the first const to an enum, so no worries. > >> Cheers! >> >>> >>>> Cheers, >>>> Angelo >>> >>> >>> regards Frank >> >> > > > regards Frank