From: "Corentin Chary" <corentin.chary@gmail.com>
To: "Randy Dunlap" <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>,
acpi4asus-user@lists.sourceforge.net
Subject: Re: [PATCH -mm] eeepc: depends on RFKILL
Date: Tue, 16 Sep 2008 09:05:56 +0200 [thread overview]
Message-ID: <71cd59b00809160005t62bbeb7ek984a47e61b452049@mail.gmail.com> (raw)
In-Reply-To: <20080915125258.77b14e2b.randy.dunlap@oracle.com>
Yep, it should depends on RFKILL, and I should start porting
asus-laptop to rfkill.
Thanks for this patch.
On Mon, Sep 15, 2008 at 9:52 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> EEEPC_LAPTOP uses RFKILL, so the former should depend on RFKILL.
> Build errors happen when EEEPC_LAPTOP=y and RFKILL=m.
>
> eeepc-laptop.c:(.text+0xd5a7b): undefined reference to `rfkill_allocate'
> eeepc-laptop.c:(.text+0xd5b04): undefined reference to `rfkill_register'
> eeepc-laptop.c:(.text+0xd5b48): undefined reference to `rfkill_allocate'
> eeepc-laptop.c:(.text+0xd5bd4): undefined reference to `rfkill_register'
> eeepc-laptop.c:(.text+0xd5ece): undefined reference to `rfkill_unregister'
> eeepc-laptop.c:(.text+0xd5ef6): undefined reference to `rfkill_unregister'
> make[1]: *** [.tmp_vmlinux1] Error 1
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Corentin Chary <corentincj@iksaif.net>
> ---
> drivers/misc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-2.6.27-rc5-mm1.orig/drivers/misc/Kconfig
> +++ linux-2.6.27-rc5-mm1/drivers/misc/Kconfig
> @@ -410,6 +410,7 @@ config EEEPC_LAPTOP
> depends on BACKLIGHT_CLASS_DEVICE
> depends on HWMON
> depends on EXPERIMENTAL
> + depends on RFKILL
> ---help---
> This driver supports the Fn-Fx keys on Eee PC laptops.
> It also adds the ability to switch camera/wlan on/off.
>
prev parent reply other threads:[~2008-09-16 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 19:52 Randy Dunlap
2008-09-16 7:05 ` Corentin Chary [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71cd59b00809160005t62bbeb7ek984a47e61b452049@mail.gmail.com \
--to=corentin.chary@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®