mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Corentin Chary <corentin.chary@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: acpi4asus-user@lists.sourceforge.net, len.brown@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eeepc-laptop: enable camera by default
Date: Fri, 5 Jun 2009 15:02:28 +0200	[thread overview]
Message-ID: <71cd59b00906050602s5c9b9a31ne11b6aaf7546f58c@mail.gmail.com> (raw)
In-Reply-To: <1244205844.23533.21.camel@penberg-laptop>

On Fri, Jun 5, 2009 at 2:44 PM, Pekka Enberg<penberg@cs.helsinki.fi> wrote:
> Hi Corentin,
>
> On Fri, 2009-06-05 at 13:46 +0200, Corentin Chary wrote:
>> First, I think a one line
>> set_acpi(CM_ASL_CAMERA, 1);
>> with a small comment is better. (If it fails, it's because there no
>> camera, so we don't mind).
>
> OK, I've included an updated version of the patch.
>
> On Fri, 2009-06-05 at 13:46 +0200, Corentin Chary wrote:
>> Anyway, I'm not sure it's a good idea to enable the camera by default.
>> It depends how many power the camera is using (when idle). Coud you
>> check that (with power top maybe ?).
>
> People who prefer power savings over functional camera can always
> disable it. If you look at the amount of "my camera doesn't" work bug
> reports, I think it's pretty evident that we should enable it by default
> or provide a config option that does it.

Ok, your right, I'll apply that one

> That said, I am more than happy to measure this but I need a little bit
> more information to get started as I have never used powertop. So what
> is it exactly you want me to do?

PowerTop (with a corretly configured kernel) will give you a power
usage estimate.

CONFIG_NO_HZ=y
CONFIG_TIMER_STATS=y
CONFIG_DEBUG_KERNEL=y

For propers results, shutdown all services and just keep a shell
(without X or network).
You can also test that with and without the camera driver.

-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org

  reply	other threads:[~2009-06-05 13:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-05  8:59 Pekka J Enberg
2009-06-05 11:46 ` Corentin Chary
2009-06-05 12:44   ` Pekka Enberg
2009-06-05 13:02     ` Corentin Chary [this message]
2009-06-05 13:39       ` Alan Jenkins
2009-06-05 13:51       ` Pekka Enberg
2009-06-05 13:54         ` Pekka Enberg
2009-06-05 13:58         ` Corentin Chary
2009-06-05 14:38         ` Alan Jenkins
2009-06-05 14:50           ` Pekka Enberg
2009-06-05 14:55             ` Alan Jenkins
2009-06-05 15:08               ` Alan Jenkins
2009-06-05 15:14                 ` Pekka Enberg
2009-06-07 14:54                 ` Darren Salt
2009-06-07 15:41                   ` Alan Jenkins
2009-06-07 23:28                     ` Matthew Garrett
2009-06-08  3:03                       ` Alan Stern
2009-06-08  3:07                         ` Matthew Garrett
2009-06-08  3:10                           ` Alan Stern
2009-06-08 15:00                             ` Matthew Garrett
2009-06-08 20:44                               ` Alan Stern
2009-06-05 15:13               ` Alan Stern
2009-06-05 15:22                 ` Pekka Enberg
2009-06-05 21:01   ` Woody Suwalski
2009-06-06  7:12     ` Corentin Chary
2009-06-06  8:04       ` Alan Jenkins
2009-06-05 20:08 ` Andrew Morton
2009-06-06  7:25   ` Corentin Chary
2009-06-06  7:31     ` Andrew Morton
2009-06-06  7:52       ` Corentin Chary
2009-06-06  9:17         ` Pekka Enberg
2009-06-06 10:17           ` Corentin Chary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71cd59b00906050602s5c9b9a31ne11b6aaf7546f58c@mail.gmail.com \
    --to=corentin.chary@gmail.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®